Revert "Reland "Remove references to Observatory (#118577)"" #121555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
framework
CaseyHillers
approved these changes
Feb 27, 2023
goderbauer
added
the
autosubmit
auto-submit
bot
deleted the
revert-121215-reland_remove_observatory_references
branch
Contributor
|
Thanks for the revert! @goderbauer can you also cc me next time :) Would love to include this change in the roll earlier |
Member
Author
|
@XilaiZhang Sure, what kind of changes are you interested in? Just any kind of rollback? |
Contributor
|
for sure, rollbacks are very helpful! It would be easier to include in the roll than cherry picking the roll back afterwards |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #121215
This commit was breaking the ability to run tests straight from IntelliJ: When right-clicking a test and selecting
Run fooit just spins indefinitely on the "Instantiating tests..." step. When I backed out this change locally, the problem went away.