Cleanup material/tabs.dart documentation #121524
Conversation
flutter-dashboard
bot
added
f: material design
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| // release mode: the viewport temporarily may have a dimension of zero | ||
| // before the actual dimension is calculated. In that scenario, setting | ||
| // the actual dimension would cause a strange scroll effect without this | ||
| // guard because the super call below would starts a ballistic scroll activity. |
There was a problem hiding this comment.
While you're fixing up the docs here, would starts a ballistic scroll activity should be would start a ballistic scroll activity.
There was a problem hiding this comment.
@navaronbracke Thanks! I will fix this too.
|
test-exempt: documentation These fixes are awesome. |
bleroux
added
the
autosubmit
3 participants
Description
The documentation in
material/tabs.dartneeds some cleanup. For instance:TabBaris referencing itself.indicatorPaddingrelated documentation needs improvements related to some logic changes added in Tab bar improvements #63683.Related Issue
Fixes #121523
Tests
Documentation only.