Skip to content

Fix finding JDK in current Android Studio (cherry-pick) #121504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itsjustkevin merged 1 commit into from
Mar 1, 2023
Merged

Fix finding JDK in current Android Studio (cherry-pick) #121504

itsjustkevin merged 1 commit into from
Mar 1, 2023

Conversation

@gnprice
Copy link
Member

@gnprice gnprice commented Feb 27, 2023

Cherry-pick of aed9b4a / #120107, to fix #106674 on the stable branch.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 27, 2023
This was referenced Feb 27, 2023
Closed
Closed
christopherfujino
christopherfujino approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin itsjustkevin merged commit 12cb4eb into flutter:flutter-3.7-candidate.1 Mar 1, 2023
@gnprice gnprice deleted the pr-cp-jdk branch March 1, 2023 18:36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
12cb4eb7a Fix unable to find bundled Java version (#120107) (flutter/…
e80264f 
…flutter#121504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
12cb4eb7a Fix unable to find bundled Java version (#120107) (flutter/…
eeca9a3 
…flutter#121504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
12cb4eb7a Fix unable to find bundled Java version (#120107) (flutter/…
82b7050 
…flutter#121504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
12cb4eb7a Fix unable to find bundled Java version (#120107) (flutter/…
3703817 
…flutter#121504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2023
@engine-flutter-autoroll
12cb4eb7a Fix unable to find bundled Java version (#120107) (flutter/…
0b6b9d3 
…flutter#121504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gnprice @christopherfujino @itsjustkevin