Give error on too many arguments to flutter config
#121494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flutter#121467. If `flutter config` receives any positional arguments, then something is wrong; one way or another, the command isn't what the developer intended. Give an error and let the developer fix the command, rather than silently doing the wrong thing. The most likely cause of this error is that the developer intended to pass a path that has spaces in it, and the shell split the path into several arguments at the spaces. This has produced a couple of reports in the tracker. So give a hint aimed at this possibility.
flutter-dashboard
bot
added
the
tool
christopherfujino
approved these changes
Feb 27, 2023
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
nice fix, thanks!
christopherfujino
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121467.
If
flutter configreceives any positional arguments, then something is wrong; one way or another, the command isn't what the developer intended. Give an error and let the developer fix the command, rather than silently doing the wrong thing.The most likely cause of this error is that the developer intended to pass a path that has spaces in it, and the shell split the path into several arguments at the spaces. This has produced a couple of reports in the tracker. So give a hint aimed at this possibility.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.