Skip to content

Bottom appbar/sheet shadow property #121406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
esouthren merged 17 commits into from
Mar 6, 2023
Merged

Bottom appbar/sheet shadow property #121406

esouthren merged 17 commits into from
Mar 6, 2023

Conversation

@esouthren
Copy link
Contributor

@esouthren esouthren commented Feb 24, 2023

Revised re-land of #119819. Fixes #118150 and #118244.

Instead of hard-defaulting to no shadow in M3, we add a shadowColor property to bottomAppBar and bottomSheet, and their respective themes.

The M3 default is then set to Colors.transparent shadow, but can be overridden by users.

Updated M3 defaults:
Screenshot 2023-02-24 3 04 29 PM

Internal testing has been conducted and g3fix created (cl/512056372).

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 24, 2023
@esouthren esouthren marked this pull request as ready for review February 24, 2023 17:51
guidezpl
guidezpl reviewed Feb 27, 2023
View reviewed changes
@esouthren esouthren requested a review from guidezpl February 27, 2023 13:37
HansMuller
HansMuller reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a shadowColor theme property is a good move. Just small small-stuff feedback.

@esouthren esouthren requested a review from HansMuller March 1, 2023 11:59
HansMuller
HansMuller approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esouthren esouthren merged commit d696b05 into flutter:master Mar 6, 2023
@esouthren esouthren deleted the bottom_sheet_shadow_property branch March 6, 2023 11:56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2023
@engine-flutter-autoroll
d696b05 Bottom appbar/sheet shadow property (flutter/flutter#121406)
9a38c36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2023
@engine-flutter-autoroll
d696b05 Bottom appbar/sheet shadow property (flutter/flutter#121406)
65c7ae1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
d696b05 Bottom appbar/sheet shadow property (flutter/flutter#121406)
e244de9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
d696b05 Bottom appbar/sheet shadow property (flutter/flutter#121406)
7fc96b6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
d696b05 Bottom appbar/sheet shadow property (flutter/flutter#121406)
1aa9d31
@cyanglaz cyanglaz mentioned this pull request Mar 8, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
QuncCccccc
QuncCccccc reviewed Mar 13, 2023
View reviewed changes
packages/flutter/lib/src/material/bottom_app_bar.dart
Color? get surfaceTintColor => Theme.of(context).colorScheme.surfaceTint;

@override
Color get shadowColor => Colors.transparent;
Copy link
Contributor

@QuncCccccc QuncCccccc Mar 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shadowColor should have same type Color? as the template. Fixing this in PR: #122548 #122557 :)

@guidezpl guidezpl mentioned this pull request Mar 13, 2023
Closed
8 tasks
@QuncCccccc QuncCccccc mentioned this pull request Mar 13, 2023
Merged
8 tasks
@chrisbobbe chrisbobbe mentioned this pull request Mar 22, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d696b05 Bottom appbar/sheet shadow property (flutter/flutter#121406)
719beee
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d696b05 Bottom appbar/sheet shadow property (flutter/flutter#121406)
5311cba
@TahaTesser TahaTesser mentioned this pull request May 29, 2023
Closed
@TahaTesser TahaTesser mentioned this pull request Sep 26, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc left review comments

@guidezpl guidezpl Awaiting requested review from guidezpl

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BottomAppBar does not match M3 spec

4 participants

@esouthren @HansMuller @guidezpl @QuncCccccc