Skip to content

[conductor] Remove cherrypick option #121405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 27, 2023
Merged

[conductor] Remove cherrypick option #121405

auto-submit merged 1 commit into from
Feb 27, 2023

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Feb 24, 2023 •
edited
Loading

Cleanup as this flag is no longer used.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 24, 2023
@CaseyHillers CaseyHillers marked this pull request as ready for review February 27, 2023 04:58
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@auto-submit auto-submit bot merged commit d193f05 into flutter:master Feb 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d193f05 [conductor] Remove cherrypick option (flutter/flutter#121405)
30ca9dc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d193f05 [conductor] Remove cherrypick option (flutter/flutter#121405)
4bd54ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d193f05 [conductor] Remove cherrypick option (flutter/flutter#121405)
87a8f50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d193f05 [conductor] Remove cherrypick option (flutter/flutter#121405)
568f533
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d193f05 [conductor] Remove cherrypick option (flutter/flutter#121405)
fff7316
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d193f05 [conductor] Remove cherrypick option (flutter/flutter#121405)
1c9f4c5
@itsjustkevin
Copy link
Contributor

itsjustkevin commented Feb 28, 2023

Conductor failing on an assertion. Output below:

Repository engine is checked out at revision "0f359063c487ee70787e58b4b011cbb3c2f53fd6".
Unhandled exception:
'package:conductor_core/src/repository.dart': Failed assertion: line 843 pos 12: 'newRevision.length == 40': is not true.
#0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61)
#1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5)
#2      EngineRepository.updateDartRevision (package:conductor_core/src/repository.dart:843:12)
#3      StartContext.run (package:conductor_core/src/start.dart:308:20)
<asynchronous suspension>
#4      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#5      main (file:///Users/kevinjchisholm/release/flutter/dev/conductor/core/bin/cli.dart:78:5)
<asynchronous suspension>

CaseyHillers added a commit that referenced this pull request Feb 28, 2023
@CaseyHillers
Revert "[conductor] Remove cherrypick option (#121405)"
ccc1915 
This reverts commit d193f05.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d193f05 [conductor] Remove cherrypick option (flutter/flutter#121405)
d56d6e7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d193f05 [conductor] Remove cherrypick option (flutter/flutter#121405)
94b4fdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsjustkevin itsjustkevin itsjustkevin approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaseyHillers @itsjustkevin