Skip to content

Add support for application exit requests #121378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 19 commits into from
Mar 17, 2023
Merged

Add support for application exit requests #121378

auto-submit merged 19 commits into from
Mar 17, 2023

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Feb 24, 2023 •
edited
Loading

Description

This adds support for handling an application exit request from the engine.

Related PRs

Related Issues

Tests

  • Added tests for the example, for the listener, and for the exitApplication call on ServicesBinding.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 24, 2023
@gspencergoog gspencergoog mentioned this pull request Feb 24, 2023
Merged
@gspencergoog gspencergoog force-pushed the application_exit branch 3 times, most recently from c84dfab to b8a77ae Compare February 27, 2023 23:51
robert-ancell
robert-ancell reviewed Mar 2, 2023
View reviewed changes
@gspencergoog gspencergoog force-pushed the application_exit branch 2 times, most recently from 8a6f4b2 to 613a839 Compare March 3, 2023 19:29
gspencergoog
gspencergoog commented Mar 3, 2023
View reviewed changes
@gspencergoog gspencergoog mentioned this pull request Mar 7, 2023
Merged
@gspencergoog gspencergoog force-pushed the application_exit branch 4 times, most recently from 31952bf to a685df2 Compare March 7, 2023 20:48
@gspencergoog gspencergoog requested a review from goderbauer March 7, 2023 21:17
@gspencergoog gspencergoog marked this pull request as ready for review March 7, 2023 21:21
@gspencergoog
Copy link
Contributor Author

gspencergoog commented Mar 7, 2023

Okay, I think this is ready for a review.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 7, 2023
robert-ancell
robert-ancell approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Note the CI seems to have failed due to some trivial formatting issues.

goderbauer
goderbauer reviewed Mar 8, 2023
View reviewed changes
@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 17, 2023

auto label is removed for flutter/flutter, pr: 121378, due to - The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023
@auto-submit auto-submit bot merged commit bcdab11 into flutter:master Mar 17, 2023
@gspencergoog gspencergoog mentioned this pull request Mar 17, 2023
Merged
@HansMuller HansMuller mentioned this pull request Mar 17, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2023
@engine-flutter-autoroll
bcdab11 Add support for application exit requests (flutter/flutter#12…
8232ea6 
…1378)
@gspencergoog gspencergoog deleted the application_exit branch April 7, 2023 17:32
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
bcdab11 Add support for application exit requests (flutter/flutter#12…
b9b431b 
…1378)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
bcdab11 Add support for application exit requests (flutter/flutter#12…
8bb9116 
…1378)
@JSUYA JSUYA mentioned this pull request Aug 28, 2023
Merged
@JSUYA JSUYA mentioned this pull request Sep 8, 2023
Closed
4 tasks
@darshankawar darshankawar mentioned this pull request Jan 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert-ancell robert-ancell robert-ancell approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gspencergoog @robert-ancell @goderbauer