Skip to content

Conversation

@christopherfujino
Copy link
Contributor

Fixes #120691

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 24, 2023
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2023
@auto-submit auto-submit bot merged commit 6b3f958 into flutter:master Feb 24, 2023
@christopherfujino christopherfujino deleted the show-web-server-in-devices branch February 25, 2023 09:46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@DanTup
Copy link
Contributor

DanTup commented Feb 27, 2023

@christopherfujino FWIW this flag was used by VS Code, and now flutter daemon --show-web-service-device (which is configured by the "dart.flutterShowWebServerDevice" setting) just terminates and results in this:

Screenshot 2023-02-27 at 13 52 54

Is it possible we can keep this flag as a no-op for a while?

@DanTup
Copy link
Contributor

DanTup commented Feb 27, 2023

(btw, it was my understanding that this flag had been added specifically to hide the web-server device for most users, because they would select it instead of Chrome in the IDE and then get stuck because they didn't understand the flow with the Dart Debug extension - have opinions around this changed?)

@christopherfujino
Copy link
Contributor Author

(btw, it was my understanding that this flag had been added specifically to hide the web-server device for most users, because they would select it instead of Chrome in the IDE and then get stuck because they didn't understand the flow with the Dart Debug extension - have opinions around this changed?)

Ahh, what happened was no one we asked remembered this context. Let me revert for now to unblock dart-code and so we can discuss whether or not we're concerned about confusing dart debug extensions users.

@DanTup
Copy link
Contributor

DanTup commented Feb 27, 2023

@christopherfujino np! Let me know if you do decide to go ahead with it and I can migrate Dart-Code off it for relevant versions (although, we should retain the flag for a little while as a no-op to help the transition for older plugins).

@christopherfujino
Copy link
Contributor Author

@christopherfujino np! Let me know if you do decide to go ahead with it and I can migrate Dart-Code off it for relevant versions (although, we should retain the flag for a little while as a no-op to help the transition for older plugins).

Yes, definitely, both on keeping you involved in the discussion and about migrating the command to be no-op. I should have made it no-op in the first place, but I assumed nobody ever used this flag :P

@DanTup
Copy link
Contributor

DanTup commented Feb 27, 2023

but I assumed nobody ever used this flag :P

To be fair, this flag isn't passed by default in Dart-Code for most users. You either have to opt-in, or be running in a remote workspace (where we assume web-server is probably what you need and not Chrome, because if we spawn Chrome you might not see it). So not a massive break, but definitely non-zero :-)

@christopherfujino
Copy link
Contributor Author

but I assumed nobody ever used this flag :P

To be fair, this flag isn't passed by default in Dart-Code for most users. You either have to opt-in, or be running in a remote workspace (where we assume web-server is probably what you need and not Chrome, because if we spawn Chrome you might not see it). So not a massive break, but definitely non-zero :-)

ahh yes, I did know about the remote workspace workflow--but forgot.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
auto-submit bot pushed a commit that referenced this pull request Feb 27, 2023
Revert "[flutter_tools] show web-server in flutter devices"
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[web:tool] support -d web-server or equivalent way to serve a web app in a simple browser-agnostic way

3 participants