-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[flutter_tools] show web-server in flutter devices #121373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] show web-server in flutter devices #121373
Conversation
yjbanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@christopherfujino FWIW this flag was used by VS Code, and now Is it possible we can keep this flag as a no-op for a while? |
|
(btw, it was my understanding that this flag had been added specifically to hide the web-server device for most users, because they would select it instead of Chrome in the IDE and then get stuck because they didn't understand the flow with the Dart Debug extension - have opinions around this changed?) |
Ahh, what happened was no one we asked remembered this context. Let me revert for now to unblock dart-code and so we can discuss whether or not we're concerned about confusing dart debug extensions users. |
This reverts commit 6b3f958.
|
@christopherfujino np! Let me know if you do decide to go ahead with it and I can migrate Dart-Code off it for relevant versions (although, we should retain the flag for a little while as a no-op to help the transition for older plugins). |
Yes, definitely, both on keeping you involved in the discussion and about migrating the command to be no-op. I should have made it no-op in the first place, but I assumed nobody ever used this flag :P |
To be fair, this flag isn't passed by default in Dart-Code for most users. You either have to opt-in, or be running in a remote workspace (where we assume web-server is probably what you need and not Chrome, because if we spawn Chrome you might not see it). So not a massive break, but definitely non-zero :-) |
ahh yes, I did know about the remote workspace workflow--but forgot. |


Fixes #120691