-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Change mouse cursor to be SystemMouseCursors.click when not editable #121353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QuncCccccc
merged 2 commits into
flutter:master
from
QuncCccccc:change_mouse_cursor_when_unfocused
Feb 23, 2023
Merged
Change mouse cursor to be SystemMouseCursors.click when not editable #121353
QuncCccccc
merged 2 commits into
flutter:master
from
QuncCccccc:change_mouse_cursor_when_unfocused
Feb 23, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
773d738 to
81c69cf
Compare
HansMuller
approved these changes
Feb 23, 2023
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix. LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
fixes [DropdownMenu cursor in disabled state](#144611) This was added in #121353 ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, home: Scaffold( body: Center( child: Column( mainAxisSize: MainAxisSize.min, children: <Widget>[ const Spacer(), const Text('enabled: true,\nrequestFocusOnTap: true,'), const SizedBox(height: 16), DropdownMenu<String>( enabled: true, initialSelection: 'First', requestFocusOnTap: true, width: 200, dropdownMenuEntries: ['First', 'Second', 'Third'] .map((e) => DropdownMenuEntry(value: e, label: e)) .toList(), ), const Text('Expected: text cursor'), const Spacer(), const Text('enabled: true,\nrequestFocusOnTap: false,'), const SizedBox(height: 16), DropdownMenu<String>( enabled: true, initialSelection: 'First', requestFocusOnTap: false, width: 200, dropdownMenuEntries: ['First', 'Second', 'Third'] .map((e) => DropdownMenuEntry(value: e, label: e)) .toList(), // label: const Text('requestFocusOnTap: false'), ), const Text('Expected: clickable cursor'), const Spacer(), const Text('enabled: false,\nrequestFocusOnTap: true,'), const SizedBox(height: 16), DropdownMenu<String>( enabled: false, initialSelection: 'First', requestFocusOnTap: true, width: 200, dropdownMenuEntries: ['First', 'Second', 'Third'] .map((e) => DropdownMenuEntry(value: e, label: e)) .toList(), ), const Text('Expected: deferred cursor'), const Spacer(), const Text('enabled: false,\nrequestFocusOnTap: false,'), const SizedBox(height: 16), DropdownMenu<String>( enabled: false, initialSelection: 'First', requestFocusOnTap: false, width: 200, dropdownMenuEntries: ['First', 'Second', 'Third'] .map((e) => DropdownMenuEntry(value: e, label: e)) .toList(), ), const Text('Expected: deferred cursor'), const Spacer(), ], ), ), ), ); } } ``` </details> ### Preview 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes comment on #121062
This PR is to add a small change on the mouse cursor of the
DropdownMenu. On desktop platforms, when therequestFocusOnTapis set to false, the mouse cursor should becomeSystemMouseCursors.clickto indicate this field is clickable, instead of editable.Pre-launch Checklist
///).