Skip to content

Update test font #121306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Mar 6, 2023
Merged

Update test font #121306

auto-submit merged 8 commits into from
Mar 6, 2023

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Feb 23, 2023 •
edited
Loading

Migrate framework tests before I can make the new test font the default.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 23, 2023
@LongCatIsLooong LongCatIsLooong mentioned this pull request Feb 23, 2023
Merged
8 tasks
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review March 4, 2023 01:34
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. labels Mar 4, 2023
justinmc
justinmc approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Why are we changing the test font? Will it still be a blocky kind of font like Ahem?

It looks great that we don't have to specify "Ahem" everywhere, we don't need to use moreOrLessEquals, etc.

packages/flutter/test/material/input_decorator_test.dart

// The label reduces the amount of space available for text, so the
// center is slightly lower.
expect(tester.getTopLeft(find.text(text)).dy, moreOrLessEquals(298.0, epsilon: .0001));
Copy link
Contributor

@justinmc justinmc Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that we can get rid of some moreOrLessEquals.

@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Mar 6, 2023

Yeah mostly because this font gives accurate metrics (unless fontSize * scaleFactor is something like 1/3 then loss of precision is inevitable). The outlines of the glyphs and the glyph mapping are very similar to Ahem (see: flutter/engine#39809). I'll create a wiki page after the new font is made the default.

@justinmc
Copy link
Contributor

justinmc commented Mar 6, 2023

Sounds good, thanks!

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2023
@auto-submit auto-submit bot merged commit 9f69a36 into flutter:master Mar 6, 2023
@LongCatIsLooong LongCatIsLooong deleted the update-font branch March 6, 2023 21:57
LongCatIsLooong added a commit that referenced this pull request Mar 6, 2023
@LongCatIsLooong
Revert "Update test font (#121306)"
6c24f47 
This reverts commit 9f69a36.
@LongCatIsLooong LongCatIsLooong mentioned this pull request Mar 6, 2023
Merged
LongCatIsLooong added a commit that referenced this pull request Mar 6, 2023
@LongCatIsLooong
Revert "Update test font (#121306)" (#122053)
33ffdd7 
This reverts commit 9f69a36.
LongCatIsLooong added a commit that referenced this pull request Mar 6, 2023
@LongCatIsLooong
Revert "Revert "Update test font (#121306)" (#122053)"
bb2a893 
This reverts commit 33ffdd7.
@LongCatIsLooong LongCatIsLooong mentioned this pull request Mar 7, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
9f69a36 Update test font (flutter/flutter#121306)
f2d2e73
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
9f69a36 Update test font (flutter/flutter#121306)
f6ab6d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
9f69a36 Update test font (flutter/flutter#121306)
531e934
@cyanglaz cyanglaz mentioned this pull request Mar 8, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
auto-submit bot pushed a commit that referenced this pull request Mar 9, 2023
@LongCatIsLooong
Reland "Update test font (#121306)" (#122068)
f4551e6 
Reland "Update test font (#121306)"
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@LongCatIsLooong @hannah-hyj
Reland "Update test font (flutter#121306)" (flutter#122068)
a473a5b 
Reland "Update test font (flutter#121306)"
@HansMuller HansMuller mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
9f69a36 Update test font (flutter/flutter#121306)
34ad4c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
9f69a36 Update test font (flutter/flutter#121306)
b1ad7ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@Renzo-Olivares Renzo-Olivares Awaiting requested review from Renzo-Olivares

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @justinmc