Skip to content

Add a note about updating and fix env variable #121293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Feb 24, 2023
Merged

Add a note about updating and fix env variable #121293

auto-submit merged 4 commits into from
Feb 24, 2023

Conversation

@ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Feb 23, 2023 •
edited
Loading

Some changes to add to the dockerfile suggested in the initial Pull request. They were not added then in an effort to unblock the tree.

List which issues are fixed by this PR. You must list at least one issue.
Fixes #121287

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 23, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 23, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

christopherfujino
christopherfujino reviewed Feb 23, 2023
View reviewed changes
dev/ci/docker_linux/Dockerfile Outdated
ENV JAVA_HOME="/usr/lib/jvm/adoptopenjdk-11-hotspot-amd64"

RUN export CLASSPATH='/usr/share/jaxb/lib'
ENV CLASSPATH="/usr/share/jaxb/lib"
Copy link
Contributor

@christopherfujino christopherfujino Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this line since it seems to be passing without it?

Copy link
Contributor

@christopherfujino christopherfujino Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or rather, it passes when it's not affecting subsequent steps

Copy link
Contributor Author

@ricardoamador ricardoamador Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good point. Let me see what happens if it is removed.

christopherfujino
christopherfujino approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2023
@auto-submit auto-submit bot merged commit 9e6214f into flutter:master Feb 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
e7048ed 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
98405bf 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
7e6160c 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
f8ee7e4 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
58fe295 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
c218de5 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
1a9f11c 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
7bafa0a 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
7aa7230 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
5ea6cac 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
fb556b9 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
e28fb41 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
f609b31 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
f5b95c6 
…er#121293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
aee6aa3 
…er#121293)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
ecbc478 
…er#121293)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
9e6214f Add a note about updating and fix env variable (flutter/flutt…
140ef37 
…er#121293)
@ricardoamador ricardoamador deleted the dockerfile_enhancements branch September 25, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup the dev/ci/docker_linux/Dockerfile with changes requested from previous review

2 participants

@ricardoamador @christopherfujino