Skip to content

Add getInheritedWidgetOfExactType to BuildContext #121276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Feb 23, 2023
Merged

Add getInheritedWidgetOfExactType to BuildContext #121276

auto-submit merged 4 commits into from
Feb 23, 2023

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Feb 22, 2023

Description

This adds BuildContext.getInheritedWidgetOfExactType, which is identical to dependOnInheritedWidgetOfExactType, except that it doesn't create a dependency.

This avoids needing to use getElementForInheritedWidgetOfExactType and then get its widget and cast it to the appropriate widget type, which makes for cleaner code, and there's no chance you'll cast it to a different type than what you were looking for.

Tests

  • Added a test to make sure that it fetches the ancestor, and that it doesn't create a dependency.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 22, 2023
@gspencergoog gspencergoog changed the title Add getInheritedWidgetOfExactType to BuildContext Add getInheritedWidgetOfExactType to BuildContext Feb 22, 2023
@flutter-dashboard flutter-dashboard bot added f: focus Focus traversal, gaining or losing focus f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. labels Feb 22, 2023
goderbauer
goderbauer approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 23, 2023
@auto-submit auto-submit bot merged commit a50bdcf into flutter:master Feb 23, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
c968a8f 
…r/flutter#121276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
73b1445 
…r/flutter#121276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
d3a1abd 
…r/flutter#121276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
aef45d8 
…r/flutter#121276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
32d2f0b 
…r/flutter#121276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
9c661a3 
…r/flutter#121276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
15caa93 
…r/flutter#121276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
c6fb373 
…r/flutter#121276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
03d7738 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
83c3dea 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
163e4dc 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
fd30a63 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
654c274 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
93899bc 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
ff46bbf 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
17f12c0 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
f7518ef 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
37c263a 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
bff6728 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
ad74961 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
e19293e 
…r/flutter#121276)
@HansMuller HansMuller mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
e481c8f 
…r/flutter#121276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a50bdcf Add getInheritedWidgetOfExactType to BuildContext (flutte…
d34a1c2 
…r/flutter#121276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: focus Focus traversal, gaining or losing focus f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gspencergoog @goderbauer