Skip to content

Add adaptive RefreshIndicator #121249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MitchellGoodwin merged 1 commit into from
Feb 24, 2023
Merged

Add adaptive RefreshIndicator #121249

MitchellGoodwin merged 1 commit into from
Feb 24, 2023

Conversation

@MitchellGoodwin
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin commented Feb 22, 2023 •
edited
Loading

Addresses #119361. Adds an adaptive constructor to RefreshIndicator in order to conditionally show either a Material or Cupertino spinning progress indicator on pull down.

How it look when it runs on Material platforms:

Screen.Recording.2023-02-22.at.9.49.31.AM.mov

How it looks when it runs on Cupertino platforms:

Screen.Recording.2023-02-22.at.9.45.37.AM.mov

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 22, 2023
@MitchellGoodwin MitchellGoodwin force-pushed the adaptive-refresh-indicator branch from 9d66909 to 77adf15 Compare February 23, 2023 17:02
@MitchellGoodwin MitchellGoodwin marked this pull request as ready for review February 23, 2023 18:05
QuncCccccc
QuncCccccc approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MitchellGoodwin MitchellGoodwin merged commit cb67ecd into flutter:master Feb 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
2e28e66
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
8922ffb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
8f81543
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
e370604
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
fcd4e36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
f18ee4b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
1c2f4b4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
c40d7a3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
a04d93c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
93e3833
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
d3be3d4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
992ecc4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
000991b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
1198d20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
ef449f9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
cb67ecd Add adaptive RefreshIndicator (flutter/flutter#121249)
47721ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MitchellGoodwin @QuncCccccc