Skip to content

Do not swallow the error from the licenses acceptance #121243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ricardoamador merged 1 commit into from
Feb 22, 2023
Merged

Do not swallow the error from the licenses acceptance #121243

ricardoamador merged 1 commit into from
Feb 22, 2023

Conversation

@ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Feb 22, 2023

Do not swallow the output so we can see the error from the licenses acceptance script.

List which issues are fixed by this PR. You must list at least one issue.
#121242

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 22, 2023
nehalvpatel
nehalvpatel approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@nehalvpatel nehalvpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should let us see the issue

@ricardoamador
Copy link
Contributor Author

ricardoamador commented Feb 22, 2023

Need to merge this to help triage an issue.

@ricardoamador ricardoamador merged commit d816e72 into flutter:master Feb 22, 2023
@nehalvpatel nehalvpatel mentioned this pull request Feb 22, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
65bd3b8 
…r/flutter#121243)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
50516c0 
…r/flutter#121243)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
c92dc88 
…r/flutter#121243)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
1452787 
…r/flutter#121243)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
fc8bd59 
…r/flutter#121243)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
05cbe8e 
…r/flutter#121243)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
fd50acd 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
9ecb5e3 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
52c1b8e 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
26955ff 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
ffecd69 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
bf637fe 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
ab80893 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
350ce17 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
6a0a128 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
46ee98c 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
d1ef8da 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
0564910 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
80549c9 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
fb2c0dd 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
bc1c40b 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
1eb18a4 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
562271d 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
7fa1ff4 
…r/flutter#121243)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d816e72 Do not swallow the error from the licenses acceptance (flutte…
6f81ac8 
…r/flutter#121243)
@ricardoamador ricardoamador deleted the license_error_output branch September 25, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drewroengoogle drewroengoogle Awaiting requested review from drewroengoogle

1 more reviewer

@nehalvpatel nehalvpatel nehalvpatel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ricardoamador @nehalvpatel