Skip to content

[flutter_tools] Include mode in app.start event, and forward app.start to DAP clients #121239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Apr 5, 2023
Merged

[flutter_tools] Include mode in app.start event, and forward app.start to DAP clients #121239

auto-submit merged 3 commits into from
Apr 5, 2023

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Feb 22, 2023 •
edited
Loading

This will allow DAP clients to know the final device ID and also the mode an app is running in (something it currently guesses, but may not be accurate).

Required to improve some messages in VS Code when trying to open DevTools when running in a mode that doesn't support it (Dart-Code/Dart-Code#4273):

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 22, 2023
@DanTup DanTup mentioned this pull request Feb 22, 2023
Closed
@DanTup DanTup force-pushed the pass-app-start-with-mode branch from 1bd2f52 to bce1456 Compare February 25, 2023 09:51
@DanTup
[flutter_tools] Include mode in app.start event, and forward app.star…
aca9b10 
…t to DAP clients

This will allow DAP clients to know the final device ID and also the mode an app is running in (something it currently guesses, but may not be accurate).

May help with Dart-Code/Dart-Code#4273.
@DanTup DanTup force-pushed the pass-app-start-with-mode branch from bce1456 to aca9b10 Compare March 30, 2023 12:52
@DanTup DanTup marked this pull request as ready for review March 30, 2023 12:53
DanTup added a commit to Dart-Code/Dart-Code that referenced this pull request Mar 30, 2023
@DanTup
Improve error message if Flutter tells us the mode/device it's runnin…
c7be875 
…g on

Fixes #4273.

Also requires flutter/flutter#121239.
christopherfujino
christopherfujino approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanTup
Copy link
Contributor Author

DanTup commented Apr 4, 2023

@christopherfujino could you check what the Google Testing failure is?

@DanTup DanTup added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 4, 2023

auto label is removed for flutter/flutter, pr: 121239, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 4, 2023 •
edited
Loading

The check says to rebase...let's see if we get a valid run now...

@DanTup DanTup added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@DanTup
Copy link
Contributor Author

DanTup commented Apr 4, 2023

I think it just always says that now when the PR is out of date (which is almost always given how often master is commited to). Still, another both run might get lucky if it was an unrelated flake 😄

Thanks!

@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 5, 2023

I think it just always says that now when the PR is out of date (which is almost always given how often master is commited to). Still, another both run might get lucky if it was an unrelated flake 😄

I mean the google testing check, I've definitely seen it say either pass or fail this week, even if the branch point is out of date.

@auto-submit auto-submit bot merged commit 1a6a20c into flutter:master Apr 5, 2023
@DanTup
Copy link
Contributor Author

DanTup commented Apr 5, 2023 •
edited
Loading

I mean the google testing check

Oh, gotcha! I thought you meant GitHub (it seems to have a button for rebasing much more visibly than it used to), I'm not familiar with the Google Testing stuff.

Anyway, looks like it worked - thanks! :-)

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
1a6a20c [flutter_tools] Include mode in app.start event, and forward …
dd4d887 
…app.start to DAP clients (flutter/flutter#121239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
1a6a20c [flutter_tools] Include mode in app.start event, and forward …
d74dfb5 
…app.start to DAP clients (flutter/flutter#121239)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@DanTup @exaby73
[flutter_tools] Include mode in app.start event, and forward app.star…
685b313 
…t to DAP clients (flutter#121239)

[flutter_tools] Include mode in app.start event, and forward app.start to DAP clients
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
1a6a20c [flutter_tools] Include mode in app.start event, and forward …
d9cbfb2 
…app.start to DAP clients (flutter/flutter#121239)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
1a6a20c [flutter_tools] Include mode in app.start event, and forward …
190f6e8 
…app.start to DAP clients (flutter/flutter#121239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanTup @christopherfujino