Add ResizeImage.policy #121154
Merged
Add ResizeImage.policy #121154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
tvolkert
force-pushed
the
resize_image
branch
from
08896f5 to
39292d5
Compare
dnfield
approved these changes
Feb 21, 2023
Contributor
There was a problem hiding this comment.
It'd be nice to be more specific about how the new aspect ratio is applied.
Maybe
output image will have the spedified width and height, with the aspect ratio of the new width and height regardless of whether it matches the intrinsic aspect ratio of the image's width and height.
Contributor
There was a problem hiding this comment.
nit:
This may result in a different aspect ratio than the aspect ratio specified by the target width and height, if for example the height gets clamped downwards but the width does not.
Contributor
There was a problem hiding this comment.
Also, consider mentioning that this is similar to [BoxFit.fill] with consideration for null values on width and height, so setting one of those to null would end up corresponding to [BoxFit.fitWidth] or [BoxFit.fitHeight].
Consider mentioning that the fit member is similar to [BoxFit.contain].
I'm not sure if that would confuse more people or just lead to asking why we don't use BoxFit here, but to me having that linkage helps.
tvolkert
force-pushed
the
resize_image
branch
from
5cbb5cb to
aef56fd
Compare
tvolkert
force-pushed
the
resize_image
branch
from
aef56fd to
86ff3c8
Compare
This adds a new `ResizeImage.policy` property that controls how `ResizeImage` will interpret its `width` and `height` properties. The existing behavior is preserved via `ResizeImagePolicy.exact` (default), but there is now the option to use `ResizeImagePolicy.fit`, which satisfies the use case outlined in #118543. The API doc assets were added in flutter/assets-for-api-docs#209 Fixes #118543
tvolkert
force-pushed
the
resize_image
branch
from
86ff3c8 to
c720d39
Compare
tvolkert
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
ResizeImage.policyproperty that controls howResizeImagewill interpret itswidthandheightproperties. The existing behavior is preserved viaResizeImagePolicy.exact(default), but there is now the option to useResizeImagePolicy.fit, which satisfies the use case outlined in #118543.The API doc assets were added in flutter/assets-for-api-docs#209
Fixes #118543
Pre-launch Checklist
///).