Skip to content

Rename WindowPadding to ViewPadding #121152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Feb 22, 2023
Merged

Rename WindowPadding to ViewPadding #121152

auto-submit merged 3 commits into from
Feb 22, 2023

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Feb 21, 2023 •
edited
Loading

Follow-up to flutter/engine#39737.
Part of #116929.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 21, 2023
goderbauer
goderbauer commented Feb 21, 2023
View reviewed changes
packages/flutter/lib/fix_data/fix_painting.yaml
@@ -0,0 +1,32 @@
# Copyright 2014 The Flutter Authors. All rights reserved.
Copy link
Member Author

@goderbauer goderbauer Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piinks Is there anything else I need to do when writing the first fix for a new library? I also added tests in packages/flutter/test_fixes/painting/.

@goderbauer goderbauer marked this pull request as ready for review February 21, 2023 18:03
@flutter-dashboard flutter-dashboard bot added f: gestures flutter/packages/flutter/gestures repository. c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Feb 21, 2023
@goderbauer goderbauer mentioned this pull request Feb 21, 2023
Merged
loic-sharma
loic-sharma approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Consider getting a second review from someone that's done a Dart fix before if you have any concerns with the YAML. Otherwise, :shipit:

@goderbauer goderbauer requested a review from Piinks February 21, 2023 18:35
Piinks
Piinks approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/flutter/lib/fix_data/fix_gestures.yaml
# https://dart.dev/go/data-driven-fixes.

# * Fixes in this file are [for CLASS] from the <XXX> library. *
# * Fixes in this file are from the Gestures library. *
Copy link
Contributor

@Piinks Piinks Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. :)

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submit auto-submit bot merged commit 5ccb4d4 into flutter:master Feb 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
1cce814
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
f55237a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
49c5283
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
955f4c8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
6d6b1ab
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
0dc4838
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
9ff057a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
5fd3419
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
f2db07a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
cf4ec5f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
c63313f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
9413af6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
44c1932
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
2ce4ba3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
34bb9a7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
b1831b0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
a93a98a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
cb5c230
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
e59827d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
a13a026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
de58f2c
@HansMuller HansMuller mentioned this pull request Mar 2, 2023
Closed
@goderbauer goderbauer deleted the viewpadding branch March 3, 2023 18:20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
07a5e15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
5ccb4d4 Rename WindowPadding to ViewPadding (flutter/flutter#121152)
aff29a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @loic-sharma @Piinks