Skip to content

[web] Unify line boundary expectations on web and non-web #121006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Feb 21, 2023
Merged

[web] Unify line boundary expectations on web and non-web #121006

auto-submit merged 4 commits into from
Feb 21, 2023

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Feb 17, 2023

Follow up on #121005

Depends on flutter/engine#39693

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 17, 2023
Renzo-Olivares
Renzo-Olivares approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit auto-submit bot merged commit 902d86e into flutter:master Feb 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
902d86e09 [web] Unify line boundary expectations on web and non-web (f…
9386425 
…lutter/flutter#121006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
902d86e09 [web] Unify line boundary expectations on web and non-web (f…
0f76dca 
…lutter/flutter#121006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
902d86e09 [web] Unify line boundary expectations on web and non-web (f…
6552baf 
…lutter/flutter#121006)
This was referenced Feb 22, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
902d86e09 [web] Unify line boundary expectations on web and non-web (f…
0de087c 
…lutter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
b9ade53 
…utter/flutter#121006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
afd9400 
…utter/flutter#121006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
b0c6063 
…utter/flutter#121006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
9f26c91 
…utter/flutter#121006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
50e8785 
…utter/flutter#121006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
9ce086c 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
00fff39 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
6b516f8 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
4b3c82e 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
14be7a3 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
5fcf66d 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
7376c24 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
2b8e3a8 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
77cc10b 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
25cf28c 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
de5a8aa 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
731414b 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
fe2b31b 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
e758155 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
9f6d731 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
6c255f7 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
f370570 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
feafbd9 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
1f66d1b 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
6f7ac58 
…utter/flutter#121006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
902d86e [web] Unify line boundary expectations on web and non-web (fl…
f73c0fb 
…utter/flutter#121006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdebbar @Renzo-Olivares