Skip to content

Deprecate BindingBase.window #120998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Mar 21, 2023
Merged

Deprecate BindingBase.window #120998

auto-submit merged 5 commits into from
Mar 21, 2023

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Feb 17, 2023 •
edited
Loading

Part of #116929.

Migration Guide: flutter/website#8283

Also adds ignores required for flutter/engine#39302.

To be submitted after deprecations for flutter_test.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 17, 2023
@goderbauer
Copy link
Member Author

goderbauer commented Feb 17, 2023

@pdblasi-google This is my suggestion for the deprecation message on BindingBase.window. Just sending it your way since we talked about giving TestWidgetsFlutterBinding.window a more specific doc comment override to cover the testing details of this overall deprecation.

@goderbauer goderbauer mentioned this pull request Feb 17, 2023
Closed
33 tasks
@goderbauer goderbauer force-pushed the deprecateWindow branch 4 times, most recently from 0f2847f to f66fc71 Compare March 10, 2023 00:23
@flutter-dashboard flutter-dashboard bot added the a: tests "flutter test", flutter_test, or one of our tests label Mar 10, 2023
@goderbauer goderbauer force-pushed the deprecateWindow branch 2 times, most recently from d109cfc to f0e08e3 Compare March 15, 2023 20:43
@goderbauer goderbauer marked this pull request as ready for review March 15, 2023 20:44
@goderbauer goderbauer requested a review from loic-sharma March 15, 2023 20:44
@goderbauer goderbauer mentioned this pull request Mar 15, 2023
Merged
loic-sharma
loic-sharma reviewed Mar 15, 2023
View reviewed changes
packages/flutter/lib/src/foundation/binding.dart Outdated
Comment on lines +187 to +189
Copy link
Member

@loic-sharma loic-sharma Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider:

Suggested change
/// If a [BuildContext] is available, consider looking up the current
/// [FlutterView] associated with that context via [View.of]. It gives access
/// If a [BuildContext] is available, you can get the context's
/// current [FlutterView] via [View.of]. It gives access

I don't feel strongly about this

Copy link
Member Author

@goderbauer goderbauer Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am gonna leave this as-is since our style guide doesn't like to use the word "you": https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#use-the-passive-voice-recommend-do-not-require-never-say-things-are-simple

loic-sharma
loic-sharma reviewed Mar 15, 2023
View reviewed changes
packages/flutter/lib/src/foundation/binding.dart Outdated
Comment on lines 189 to 190
Copy link
Member

@loic-sharma loic-sharma Mar 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the language you use below in the See also section:

Suggested change
/// to the same functionality as this deprecated property. However, some
/// functionality has moved to the [PlatformDispatcher], which should be
/// to the same functionality as this deprecated property. The
/// platform-specific functionality has moved ....

I don't feel strongly about this

loic-sharma
loic-sharma reviewed Mar 15, 2023
View reviewed changes
packages/flutter/lib/src/foundation/binding.dart Outdated
Copy link
Member

@loic-sharma loic-sharma Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider simpler language for non-native speakers:

Suggested change
/// [platformDispatcher] exposed by this binding can be consulted directly for
/// [platformDispatcher] exposed by this binding can be used directly for

loic-sharma
loic-sharma approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit a9073f7 into flutter:master Mar 21, 2023
@goderbauer goderbauer deleted the deprecateWindow branch March 21, 2023 21:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
43673b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
db9ef1f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
cb9a6de
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
ba47017
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
e157d53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
4207a5c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
9f71cb4
This was referenced Mar 23, 2023
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
7eeeddc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
82a9271
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
650c8be
@HansMuller HansMuller mentioned this pull request Mar 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
df06ba1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a9073f7 Deprecate BindingBase.window (flutter/flutter#120998)
1adeef6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @loic-sharma