Skip to content

allow passing --file-reporter option to test running refs #69425 #120716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Feb 21, 2023
Merged

allow passing --file-reporter option to test running refs #69425 #120716

auto-submit merged 3 commits into from
Feb 21, 2023

Conversation

@mateusfccp
Copy link
Contributor

@mateusfccp mateusfccp commented Feb 14, 2023 •
edited
Loading

Allow passing --file-reporter option to test runner so that both machine and human readable output can be observed in a CI setting.

Supersedes #111969.

Fixes #69425.

Note: I did not made the initial commit. It was made entirely by @daniel-v, so all credits goes to him. I rebased his patch and I'm going to continue the PR process by fixing tests/checks and reacting to reviewers.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 14, 2023
@mateusfccp mateusfccp force-pushed the expose-test-file-reporter branch from f1a0b0d to 9bfbd1c Compare February 14, 2023 23:46
@mateusfccp mateusfccp marked this pull request as ready for review February 15, 2023 00:57
@mateusfccp mateusfccp mentioned this pull request Feb 15, 2023
Closed
8 tasks
@mateusfccp
Copy link
Contributor Author

mateusfccp commented Feb 15, 2023

For some reason, the Linux web_canvaskit_tests_5 check is locked in progress, but the dashboard says it completed: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_canvaskit_tests_5/22458/overview

@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 16, 2023

@Jasguerrero can you review this one?

@mateusfccp mateusfccp force-pushed the expose-test-file-reporter branch from 9bfbd1c to 0e1bae7 Compare February 19, 2023 18:54
Jasguerrero
Jasguerrero approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jasguerrero Jasguerrero added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 20, 2023

auto label is removed for flutter/flutter, pr: 120716, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 20, 2023

auto label is removed for flutter/flutter, pr: 120716, due to Validations Fail.

@andrewkolos andrewkolos self-requested a review February 21, 2023 16:50
andrewkolos
andrewkolos approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit auto-submit bot merged commit ebbc94b into flutter:master Feb 21, 2023
@mateusfccp mateusfccp deleted the expose-test-file-reporter branch February 21, 2023 17:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
ebbc94bc2 allow passing --file-reporter option to test running refs #…
3c1b9bf 
…69425 (flutter/flutter#120716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
ebbc94bc2 allow passing --file-reporter option to test running refs #…
3c442bb 
…69425 (flutter/flutter#120716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
ebbc94bc2 allow passing --file-reporter option to test running refs #…
52a40d8 
…69425 (flutter/flutter#120716)
This was referenced Feb 22, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
ebbc94bc2 allow passing --file-reporter option to test running refs #…
ed07392 
…69425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
6b4c15f 
…425 (flutter/flutter#120716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
cd34f06 
…425 (flutter/flutter#120716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
7255727 
…425 (flutter/flutter#120716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
619ef66 
…425 (flutter/flutter#120716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
b4bda9a 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
2795b92 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
afc613e 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
9e77264 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
6e6183d 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
c7f8d21 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
f7dc77a 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
917fca8 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
7d56f6b 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
ecb74f5 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
780e61d 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
13b16a4 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
c115f2b 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
2e4d9d6 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
38d424b 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
cb92f69 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
b90e9d6 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
8275c49 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
800d141 
…425 (flutter/flutter#120716)
@christopherfujino christopherfujino mentioned this pull request Mar 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
921a5a3 
…425 (flutter/flutter#120716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
ebbc94b allow passing --file-reporter option to test running refs #69…
0033310 
…425 (flutter/flutter#120716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes

+1 more reviewer

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flutter Test should support multiple reporters

4 participants

@mateusfccp @christopherfujino @andrewkolos @Jasguerrero