Predictive back support for root routes #120385

justinmc · 2023-02-09T19:04:03Z

This PR aims to support Android's predictive back gesture when popping the entire Flutter app. Predictive route transitions between routes inside of a Flutter app will come later.

Trying it out

If you want to try this feature yourself, here are the necessary steps:

Run Android 33 or above.
Enable the feature flag for predictive back on the device under "Developer
options".
Create a Flutter project, or clone my example project.
Set android:enableOnBackInvokedCallback="true" in
android/app/src/main/AndroidManifest.xml (already done in the example project).
Check out this branch.
Run the app. Perform a back gesture (swipe from the left side of the
screen).

You should see the predictive back animation like in the animation above and be able to commit or cancel it.

go_router support

go_router works with predictive back out of the box because it uses a Navigator internally that dispatches NavigationNotifications!

~~go_router can be supported by adding a listener to the router and updating SystemNavigator.setFrameworkHandlesBack.~~

Similar to with nested Navigators, nested go_routers is supported by using a PopScope widget.

Full example of nested go_routers

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:go_router/go_router.dart';

import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';

void main() => runApp(_MyApp());

class _MyApp extends StatelessWidget {
  final GoRouter router = GoRouter(
    routes: <RouteBase>[
      GoRoute(
        path: '/',
        builder: (BuildContext context, GoRouterState state) => _HomePage(),
      ),
      GoRoute(
        path: '/nested_navigators',
        builder: (BuildContext context, GoRouterState state) => _NestedGoRoutersPage(),
      ),
    ],
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: router,
    );
  }
}

class _HomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Nested Navigators Example'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text('Home Page'),
            const Text('A system back gesture here will exit the app.'),
            const SizedBox(height: 20.0),
            ListTile(
              title: const Text('Nested go_router route'),
              subtitle: const Text('This route has another go_router in addition to the one used with MaterialApp above.'),
              onTap: () {
                context.push('/nested_navigators');
              },
            ),
          ],
        ),
      ),
    );
  }
}

class _NestedGoRoutersPage extends StatefulWidget {
  @override
  State<_NestedGoRoutersPage> createState() => _NestedGoRoutersPageState();
}

class _NestedGoRoutersPageState extends State<_NestedGoRoutersPage> {
  late final GoRouter _router;
  final GlobalKey<NavigatorState> _nestedNavigatorKey = GlobalKey<NavigatorState>();

  // If the nested navigator has routes that can be popped, then we want to
  // block the root navigator from handling the pop so that the nested navigator
  // can handle it instead.
  bool get _popEnabled {
    // canPop will throw an error if called before build. Is this the best way
    // to avoid that?
    return _nestedNavigatorKey.currentState == null ? true : !_router.canPop();
  }

  void _onRouterChanged() {
    // Here the _router reports the location correctly, but canPop is still out
    // of date.  Hence the post frame callback.
    SchedulerBinding.instance.addPostFrameCallback((Duration duration) {
      setState(() {});
    });
  }

  @override
  void initState() {
    super.initState();

    final BuildContext rootContext = context;
    _router = GoRouter(
      navigatorKey: _nestedNavigatorKey,
      routes: [
        GoRoute(
          path: '/',
          builder: (BuildContext context, GoRouterState state) => _LinksPage(
            title: 'Nested once - home route',
            backgroundColor: Colors.indigo,
            onBack: () {
              rootContext.pop();
            },
            buttons: <Widget>[
              TextButton(
                onPressed: () {
                  context.push('/two');
                },
                child: const Text('Go to another route in this nested Navigator'),
              ),
            ],
          ),
        ),
        GoRoute(
          path: '/two',
          builder: (BuildContext context, GoRouterState state) => _LinksPage(
            backgroundColor: Colors.indigo.withBlue(255),
            title: 'Nested once - page two',
          ),
        ),
      ],
    );

    _router.addListener(_onRouterChanged);
  }

  @override
  void dispose() {
    _router.removeListener(_onRouterChanged);
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return PopScope(
      popEnabled: _popEnabled,
      onPopped: (bool success) {
        if (success) {
          return;
        }
        _router.pop();
      },
      child: Router<Object>.withConfig(
        restorationScopeId: 'router-2',
        config: _router,
      ),
    );
  }
}

class _LinksPage extends StatelessWidget {
  const _LinksPage ({
    required this.backgroundColor,
    this.buttons = const <Widget>[],
    this.onBack,
    required this.title,
  });

  final Color backgroundColor;
  final List<Widget> buttons;
  final VoidCallback? onBack;
  final String title;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: backgroundColor,
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(title),
            //const Text('A system back here will go back to Nested Navigators Page One'),
            ...buttons,
            TextButton(
              onPressed: onBack ?? () {
                context.pop();
              },
              child: const Text('Go back'),
            ),
          ],
        ),
      ),
    );
  }
}

Resources

Fixes #109513
Depends on engine PR flutter/engine#39208 ✔️
Design doc: https://docs.google.com/document/d/1BGCWy1_LRrXEB6qeqTAKlk-U2CZlKJ5xI97g45U7azk/edit#
Migration guide: flutter/website#8952

… stack has multiple routes

…nfra and replacing it with ahead-of-time

…le cases.

…ute in this PR

flutter/flutter@2ba9f7b...ad0aa8d 2023-08-07 [email protected] Roll Flutter Engine from b10891e0d8d8 to 5b47c0577060 (1 revision) (flutter/flutter#132040) 2023-08-07 [email protected] Roll Flutter Engine from 4304d6180264 to b10891e0d8d8 (1 revision) (flutter/flutter#132037) 2023-08-07 [email protected] Roll Flutter Engine from eb91441398a1 to 4304d6180264 (1 revision) (flutter/flutter#132031) 2023-08-07 [email protected] Constrain _RenderScaledInlineWidget child size in computeDryLayout (flutter/flutter#131765) 2023-08-07 [email protected] Roll Flutter Engine from 15b5707af406 to eb91441398a1 (1 revision) (flutter/flutter#132025) 2023-08-07 [email protected] Roll Flutter Engine from a1d513f78bbb to 15b5707af406 (2 revisions) (flutter/flutter#132020) 2023-08-06 [email protected] Roll Flutter Engine from c9bd380ccbb0 to a1d513f78bbb (1 revision) (flutter/flutter#132015) 2023-08-06 [email protected] Roll Flutter Engine from 060c95f94364 to c9bd380ccbb0 (1 revision) (flutter/flutter#132008) 2023-08-06 [email protected] Roll Flutter Engine from af7aaae2f1f9 to 060c95f94364 (1 revision) (flutter/flutter#132006) 2023-08-06 [email protected] Roll Flutter Engine from cdafc05a7217 to af7aaae2f1f9 (2 revisions) (flutter/flutter#132004) 2023-08-05 [email protected] Roll Flutter Engine from b512df490c94 to cdafc05a7217 (1 revision) (flutter/flutter#131996) 2023-08-05 [email protected] Take paint offset into account for inline children hit test in Editable (flutter/flutter#131675) 2023-08-05 [email protected] Roll Flutter Engine from d26b8c8fb60c to b512df490c94 (1 revision) (flutter/flutter#131987) 2023-08-05 [email protected] Roll Flutter Engine from 2ce2913acbe4 to d26b8c8fb60c (1 revision) (flutter/flutter#131986) 2023-08-05 [email protected] Roll Flutter Engine from 628b086265f2 to 2ce2913acbe4 (1 revision) (flutter/flutter#131983) 2023-08-05 [email protected] Roll Flutter Engine from 7302a678e58e to 628b086265f2 (1 revision) (flutter/flutter#131976) 2023-08-05 [email protected] Roll Flutter Engine from 138a1ea9a692 to 7302a678e58e (2 revisions) (flutter/flutter#131975) 2023-08-05 [email protected] Roll Flutter Engine from a0d650e37f5d to 138a1ea9a692 (2 revisions) (flutter/flutter#131972) 2023-08-05 [email protected] Add TODO to refactor error handling. (flutter/flutter#131878) 2023-08-05 [email protected] Manual roll Flutter Engine from 4f4734cd48da to a0d650e37f5d (3 revisions) (flutter/flutter#131967) 2023-08-05 [email protected] Mark the ci_yaml roller task so that it is not backfilled. (flutter/flutter#131966) 2023-08-05 [email protected] mark linux packages_autoroller flaky because of token issue (flutter/flutter#131970) 2023-08-04 [email protected] Sped up the time to find macrobenchmarks. (flutter/flutter#131959) 2023-08-04 [email protected] Roll Flutter Engine from c254deb8fbda to 4f4734cd48da (2 revisions) (flutter/flutter#131955) 2023-08-04 [email protected] Roll Flutter Engine from a7bea8621f4b to c254deb8fbda (3 revisions) (flutter/flutter#131950) 2023-08-04 [email protected] Predictive back support for root routes (flutter/flutter#120385) 2023-08-04 [email protected] Roll Flutter Engine from e9f80bff0703 to a7bea8621f4b (3 revisions) (flutter/flutter#131948) 2023-08-04 [email protected] Roll Flutter Engine from badca1f7f8c9 to e9f80bff0703 (6 revisions) (flutter/flutter#131943) 2023-08-04 [email protected] Mention `showTimePicker` function be can be used to show dialog with the time picker in the `TimePickerDialog` docs (flutter/flutter#131932) 2023-08-04 [email protected] Check for simulator runtime in flutter doctor (flutter/flutter#131795) 2023-08-04 [email protected] Roll Packages from d00c1f9 to ce53da1 (3 revisions) (flutter/flutter#131935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Breaking google testing revert of: #120385 b/295065534

Breaking google testing revert of: #120385 b/295065534 *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat Co-authored-by: Jesús S Guerrero <[email protected]>

Breaking google testing revert of: flutter#120385 b/295065534

This reverts commit 2728ba0.

Root predictive back (#120385) was reverted in #132167. This PR is an attempt to reland it. The reversion happened due to failed Google tests (b/295073110).

## Description This PR upgrades to Flutter v3.16.3. We faced the following breaking changes: * [Deprecated just-in-time navigation pop APIs for Android Predictive Back](https://docs.flutter.dev/release/breaking-changes/android-predictive-back) * [The ThemeData.useMaterial3 property is now set to true by default](https://docs.flutter.dev/release/breaking-changes/material-3-default) ## Material 3 For now, we just opt out of Material 3 because it requires some more manual migration and isn't our current focus (#1159). ## Predictive Back > Android 14 introduced the [Predictive Back feature](https://developer.android.com/guide/navigation/predictive-back-gesture), which allows the user to peek behind the current route during a valid back gesture and decide whether to continue back or to cancel the gesture. This was incompatible with Flutter’s navigation APIs that allow the developer to cancel a back gesture after it is received. > > With predictive back, the back animation begins immediately when the user initiates the gesture and before it has been committed. There is no opportunity for the Flutter app to decide whether it’s allowed to happen at that time. It must be known ahead of time. > > For this reason, all APIs that allow a Flutter app developer to cancel a back navigation at the time that a back gesture is received are now deprecated. They have been replaced with equivalent APIs that maintain a boolean state at all times that dictates whether or not back navigation is possible. When it is, the predictive back animation happens as usual. Otherwise, navigation is stopped. In both cases, the app developer is informed that a back was attempted and whether it was successful. From https://docs.flutter.dev/release/breaking-changes/android-predictive-back#background We mostly have used `WillPopScope` for confirmation dialogs, so the migration looked like this: ```dart WillPopScope( onWillPop: () async { final bool? shouldPop = await _showBackDialog(); return shouldPop ?? false; }, child: child, ) ``` to ```dart return PopScope( canPop: false, onPopInvoked: (bool didPop) async { if (didPop) { return; } final NavigatorState navigator = Navigator.of(context); final bool? shouldPop = await _showBackDialog(); if (shouldPop ?? false) { navigator.pop(); } }, child: child, ) ``` https://docs.flutter.dev/release/breaking-changes/android-predictive-back#migrating-a-back-confirmation-dialog ### Run the application with predictive back 1. Run Android 33 or above. 2. Enable the feature flag for predictive back on the device under “Developer options”. This will be unnecessary on future versions of Android. 3. Set `android:enableOnBackInvokedCallback="true"` in android/app/src/main/AndroidManifest.xml. If needed, refer to [Android’s full guide](https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture) for migrating Android apps to support predictive back. 4. Make sure you’re using version 3.14.0-7.0.pre of Flutter or greater. 5. Run the app and perform a back gesture (swipe from the left side of the screen). https://docs.flutter.dev/release/breaking-changes/android-predictive-back#supporting-predictive-back Unfortunately, I wasn't able to get predictive back animations running in a Flutter app. They work for me in the native settings app, but not in a Flutter app (even with the example app). I think it shouldn't be that a big deal because it should work that way as we have it. Here is a demo of how it should look: flutter/flutter#120385. ## Testing I tested the changes manually. --------- Co-authored-by: Jonas Sander <[email protected]>

onNavigationNotification was not being passed through when using the router in MaterialApp and CupertinoApp. I believe this was just an oversight on my part when I wrote #120385. This PR passes them through. Fixes #139903 @maRci0002 Would this totally fix your issue #139903?

parthpatel-simbiotik · 2024-02-13T08:01:27Z

This may've caused issues in new flutter app supposed to run on android 7.

Issues are as below

2024-02-13 13:28:31.588 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art 2024-02-13 13:28:31.589 7001-7001 art pid-7001 I Rejecting re-init on previously-failed class java.lang.Class<io.flutter.embedding.android.f$a>: java.lang.NoClassDefFoundError: Failed resolution of: Landroid/window/OnBackInvokedCallback;
pid-7001 I at java.lang.Object java.lang.Class.newInstance!() (Class.java:-2)
pid-7001 I at android.app.Activity android.app.Instrumentation.newActivity(java.lang.ClassLoader, java.lang.String, android.content.Intent) (Instrumentation.java:1078)
pid-7001 I at android.app.Activity android.app.ActivityThread.performLaunchActivity(android.app.ActivityThread$ActivityClientRecord, android.content.Intent) (ActivityThread.java:2557)
pid-7001 I at void android.app.ActivityThread.handleLaunchActivity(android.app.ActivityThread$ActivityClientRecord, android.content.Intent, java.lang.String) (ActivityThread.java:2726)
pid-7001 I at void android.app.ActivityThread.-wrap12(android.app.ActivityThread, android.app.ActivityThread$ActivityClientRecord, android.content.Intent, java.lang.String) (ActivityThread.java:-1)
pid-7001 I at void android.app.ActivityThread$H.handleMessage(android.os.Message) (ActivityThread.java:1477)
pid-7001 I at void android.os.Handler.dispatchMessage(android.os.Message) (Handler.java:102)
pid-7001 I at void android.os.Looper.loop() (Looper.java:154)
pid-7001 I at void android.app.ActivityThread.main(java.lang.String[]) (ActivityThread.java:6119)
pid-7001 I at java.lang.Object java.lang.reflect.Method.invoke!(java.lang.Object, java.lang.Object[]) (Method.java:-2)
pid-7001 I at void com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run() (ZygoteInit.java:886)
pid-7001 I at void com.android.internal.os.ZygoteInit.main(java.lang.String[]) (ZygoteInit.java:776)
pid-7001 I Caused by: java.lang.ClassNotFoundException: Didn't find class "android.window.OnBackInvokedCallback" on path: DexPathList[[zip file "/data/app/com.dashparking.displayapp-2/base.apk"],nativeLibraryDirectories=[/data/app/com.dashparking.displayapp-2/lib/arm64, /data/app/com.dashparking.displayapp-2/base.apk!/lib/arm64-v8a, /system/lib64, /vendor/lib64]]
pid-7001 I at java.lang.Class dalvik.system.BaseDexClassLoader.findClass(java.lang.String) (BaseDexClassLoader.java:56)
pid-7001 I at java.lang.Class java.lang.ClassLoader.loadClass(java.lang.String, boolean) (ClassLoader.java:380)
pid-7001 I at java.lang.Class java.lang.ClassLoader.loadClass(java.lang.String) (ClassLoader.java:312)
pid-7001 I at java.lang.Object java.lang.Class.newInstance!() (Class.java:-2)
pid-7001 I at android.app.Activity android.app.Instrumentation.newActivity(java.lang.ClassLoader, java.lang.String, android.content.Intent) (Instrumentation.java:1078)
pid-7001 I at android.app.Activity android.app.ActivityThread.performLaunchActivity(android.app.ActivityThread$ActivityClientRecord, android.content.Intent) (ActivityThread.java:2557)
pid-7001 I at void android.app.ActivityThread.handleLaunchActivity(android.app.ActivityThread$ActivityClientRecord, android.content.Intent, java.lang.String) (ActivityThread.java:2726)
pid-7001 I at void android.app.ActivityThread.-wrap12(android.app.ActivityThread, android.app.ActivityThread$ActivityClientRecord, android.content.Intent, java.lang.String) (ActivityThread.java:-1)
pid-7001 I at void android.app.ActivityThread$H.handleMessage(android.os.Message) (ActivityThread.java:1477)
pid-7001 I at void android.os.Handler.dispatchMessage(android.os.Message) (Handler.java:102)
pid-7001 I at void android.os.Looper.loop() (Looper.java:154)
pid-7001 I at void android.app.ActivityThread.main(java.lang.String[]) (ActivityThread.java:6119)
pid-7001 I at java.lang.Object java.lang.reflect.Method.invoke!(java.lang.Object, java.lang.Object[]) (Method.java:-2)
pid-7001 I at void com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run() (ZygoteInit.java:886)
pid-7001 I at void com.android.internal.os.ZygoteInit.main(java.lang.String[]) (ZygoteInit.java:776)
pid-7001 I

justinmc · 2024-02-14T20:21:33Z

@parthpatel-simbiotik Can you file a new issue for that?

A platform channel method that update the engine with whether the nav…

564afc0

… stack has multiple routes

justinmc added platform-android Android applications specifically f: routes Navigator, Router, and related APIs. labels Feb 9, 2023

justinmc self-assigned this Feb 9, 2023

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 9, 2023

WIP Investigating deprecating WillPopScope and related just-in-time i…

998a251

…nfra and replacing it with ahead-of-time

justinmc force-pushed the predictive-back-root branch from 2e3afaa to 998a251 Compare March 6, 2023 21:14

justinmc added 10 commits March 6, 2023 17:03

WIP a hacked-together CanPopScope, needs to be tried out

5f81b63

CanPopScope works to disable/enable predictive back, at least in simp…

261cd23

…le cases.

Rename hasMultiple to frameworkHandlesPop

780dc5f

Migrate Form to CanPopScope

110a564

Merge branch 'master' into predictive-back-root

dd9541c

Working parallel popEnabled to willPop

3b4d4b8

Merge branch 'master' into predictive-back-root

f045f5a

onPop added to CanPopScope, and About page migrated off of WillPopScope

b915a56

onPop works. Used to build example of nested Navigators

ccb62c5

WIP investigating nested canpopscopes

984ea50

flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Mar 13, 2023

justinmc added 9 commits March 13, 2023 12:08

Works for a normal single Navigator

97fa69b

Use root Navigator to handle nested Navigators

82b93b5

A little bit of code cleanup and docs

73c312b

Fix CanPopState having no effect when returning from another route

9c1680a

Fix bug where CanPopScope updated Navigator when being removed

0718eea

Fix About page

cace51e

Some code cleanup as I figure out how to avoid messing with willPopRo…

449b068

…ute in this PR

nested_navigators example

1a671ef

Ensure that WillPopScope still continues working until removed.

a391efa

justinmc force-pushed the predictive-back-root branch from 7939a36 to a391efa Compare March 27, 2023 19:39

justinmc added 2 commits March 28, 2023 14:40

Fix bug where Navigator was looked up after dispose

7cea8ae

Confirmation dialog example, and added onPop to Form to make it work

d15306a

engine-flutter-autoroll mentioned this pull request Aug 6, 2023

Roll Flutter from 2ba9f7bdfe16 to 310e91146694 (24 revisions) flutter/packages#4655

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2023

dedd100 Predictive back support for root routes (flutter/flutter#120385)

f87b2f4

engine-flutter-autoroll mentioned this pull request Aug 7, 2023

Roll Flutter from 2ba9f7bdfe16 to ad0aa8de7512 (31 revisions) flutter/packages#4659

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2023

dedd100 Predictive back support for root routes (flutter/flutter#120385)

17638ce

justinmc mentioned this pull request Aug 7, 2023

Remove Iterator from _History #132101

Merged

Jasguerrero mentioned this pull request Aug 8, 2023

Revert of #120385 #132167

Merged

Jasguerrero added a commit that referenced this pull request Aug 8, 2023

Revert of #120385 (#132167)

2728ba0

Breaking google testing revert of: #120385 b/295065534

CaseyHillers mentioned this pull request Aug 9, 2023

Revert of #120385 (#132167) #132243

Merged

8 tasks

CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Aug 9, 2023

Revert of flutter#120385 (flutter#132167)

376e391

Breaking google testing revert of: flutter#120385 b/295065534

justinmc added a commit that referenced this pull request Aug 9, 2023

Revert "Revert of #120385 (#132167)"

2195a06

This reverts commit 2728ba0.

justinmc mentioned this pull request Aug 9, 2023

Reland root predictive back #132249

Merged

HansMuller mentioned this pull request Aug 11, 2023

Flutter Framework Team: Notable Commits #121415

Closed

auto-submit bot pushed a commit that referenced this pull request Aug 17, 2023

Reland root predictive back (#132249)

f68d03f

Root predictive back (#120385) was reverted in #132167. This PR is an attempt to reland it. The reversion happened due to failed Google tests (b/295073110).

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

dedd100 Predictive back support for root routes (flutter/flutter#120385)

5f208d2

nilsreichardt mentioned this pull request Dec 3, 2023

Upgrade to Flutter v3.16.3 SharezoneApp/sharezone-app#1164

Merged

maRci002 mentioned this pull request Dec 13, 2023

Nested Navigator breaks Predictive Back (PopScope) #139903

Closed

2 tasks

justinmc mentioned this pull request Jan 25, 2024

onNavigationNotification for *App.router #142190

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Predictive back support for root routes #120385

Predictive back support for root routes #120385

Uh oh!

justinmc commented Feb 9, 2023 •

edited

Loading

Uh oh!

parthpatel-simbiotik commented Feb 13, 2024

Uh oh!

justinmc commented Feb 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Predictive back support for root routes #120385

Predictive back support for root routes #120385

Uh oh!

Conversation

justinmc commented Feb 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trying it out

go_router support

Resources

Uh oh!

parthpatel-simbiotik commented Feb 13, 2024

Uh oh!

justinmc commented Feb 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

justinmc commented Feb 9, 2023 •

edited

Loading