[cp] Stop recursively including assets from asset folders #120209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
|
|
||
| testWithoutContext('wildcard directories do not include subdirectories', () async { | ||
| final Platform platform = FakePlatform(); | ||
| final FileSystem fs = MemoryFileSystem.test(); |
Contributor
There was a problem hiding this comment.
This test failed on ToT and had to be reverted. To make this more stable, you'll need to change this to use testUsingContext and getFlutterRoot()
jonahwilliams
suggested changes
Feb 8, 2023
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Test needs to be fixed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 9, 2023
…#3185) * 9bbe247fc Fix lexer issue where select/plural/other/underscores cannot be in identifier names. (#119190) (flutter/flutter#119862) * 4c3796466 [cp] Stop recursively including assets from asset folders (flutter/flutter#120209) * 994429713 Roll engine version. (flutter/flutter#120324)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick for #120167. Fixes: #120208.
Pre-launch Checklist
///).