Skip to content

Conversation

@acumen1005
Copy link
Contributor

@acumen1005 acumen1005 commented Feb 6, 2023

  1. in iOS show the selection overlay and handlers when clicking Copy or Select All .
  2. in Android clear the selection when clicking Copy, keep to show the selection and handlers when clicking Select All.

Fixes #120080

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 6, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Feb 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@acumen1005 acumen1005 force-pushed the selection-overlay-issue branch from 2965964 to af1ec71 Compare February 6, 2023 14:11
@acumen1005 acumen1005 force-pushed the selection-overlay-issue branch from 6fd5c46 to 996c335 Compare February 9, 2023 13:58
@acumen1005 acumen1005 changed the title [WIP] Fix bug with clicking Copy or Select All within contextMenu Fix bug with clicking Copy or Select All within contextMenu Feb 9, 2023
@goderbauer goderbauer requested a review from chunhtai February 14, 2023 23:19
@chunhtai chunhtai requested a review from hannah-hyj February 27, 2023 18:30
@chunhtai
Copy link
Contributor

cc @Hangyujin for secondary review

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

I'm worried that desktop platforms might not be working correctly (see my comment below). Otherwise I think this looks good.

@acumen1005
Copy link
Contributor Author

Thank you for fixing this!

I'm worried that desktop platforms might not be working correctly (see my comment below). Otherwise I think this looks good.

thank you for your comments, I replied these comments~

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes! I think there's one more desktop behavior fix we can do here, plus some desktop tests (commented below). Everything else looks good.

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment about the desktop test, let me know if it doesn't make sense. I think that's the only thing needed before we can merge this.

Thanks for your quick responses here!

@acumen1005
Copy link
Contributor Author

I added a comment about the desktop test, let me know if it doesn't make sense. I think that's the only thing needed before we can merge this.

Thanks for your quick responses here!

Thank you for giving me so much advice~

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SelectionArea] Two weird behaves when clicking Copy or Select All in contextMenu

3 participants