-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix bug with clicking Copy or Select All within contextMenu
#120081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with clicking Copy or Select All within contextMenu
#120081
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
2965964 to
af1ec71
Compare
6fd5c46 to
996c335
Compare
Copy or Select All within contextMenuCopy or Select All within contextMenu
|
cc @Hangyujin for secondary review |
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
I'm worried that desktop platforms might not be working correctly (see my comment below). Otherwise I think this looks good.
thank you for your comments, I replied these comments~ |
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes! I think there's one more desktop behavior fix we can do here, plus some desktop tests (commented below). Everything else looks good.
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment about the desktop test, let me know if it doesn't make sense. I think that's the only thing needed before we can merge this.
Thanks for your quick responses here!
Thank you for giving me so much advice~ |
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
CopyorSelect All.Copy, keep to show the selection and handlers when clickingSelect All.Fixes #120080
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.