Skip to content

Provide default constraints for M3 bottom sheets #120065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 10 commits into from
Apr 27, 2023
Merged

Provide default constraints for M3 bottom sheets #120065

guidezpl merged 10 commits into from
Apr 27, 2023

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Feb 6, 2023 •
edited
Loading

This PR constrains M3 bottom sheets to 640dp max width by default. constraints can be used to provide different minWidth and maxWidth.

This is not a breaking change per the breaking change policy.

Part of #118619
Part of #111448

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 6, 2023
@guidezpl guidezpl marked this pull request as ready for review February 6, 2023 15:23
@guidezpl guidezpl linked an issue Feb 6, 2023 that may be closed by this pull request
Add missing m3 max width/height constraints #118619
Open
2 tasks
esouthren
esouthren reviewed Feb 6, 2023
View reviewed changes
dev/tools/gen_defaults/lib/bottom_sheet_template.dart
Color? get surfaceTintColor => ${componentColor("md.comp.sheet.bottom.docked.container.surface-tint-layer")};
@override
BoxConstraints? get constraints => const BoxConstraints(maxWidth: 640.0);
Copy link
Contributor

@esouthren esouthren Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we talk to the Tokens team about tokenizing this, since the value appears in the spec (https://m3.material.io/components/bottom-sheets/specs#3b256f38-c4fd-44e5-ba46-c5858b626ec7)?

Copy link
Member Author

@guidezpl guidezpl Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked last year about it (b/254925602) but all they're considering for now is spacing.

Copy link
Member Author

@guidezpl guidezpl Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, everything would be a token!

esouthren
esouthren approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@esouthren esouthren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hannah-hyj
hannah-hyj approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidezpl guidezpl merged commit 1f602cb into flutter:master Apr 27, 2023
@guidezpl guidezpl deleted the constrain-bottom-sheets branch April 27, 2023 07:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
1d5abd0 
…tter#120065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
8923f3b 
…tter#120065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
dddc9c8 
…tter#120065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
6874a1c 
…tter#120065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
6e23b16 
…tter#120065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
08ef9b6 
…tter#120065)
@HansMuller HansMuller mentioned this pull request Apr 28, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
ef24e12 
…tter#120065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
b2b963f 
…tter#120065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
af8e8fb 
…tter#120065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
05a85dc 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
7b1bb80 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
b7e8b8b 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
5077347 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
07414c6 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
612c3a9 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
ac80988 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
6abc930 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
677d0a5 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
5193322 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
bc634a4 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
9948ba2 
…tter#120065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
1f602cb Provide default constraints for M3 bottom sheets (flutter/flu…
cbf7892 
…tter#120065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannah-hyj hannah-hyj hannah-hyj approved these changes

+1 more reviewer

@esouthren esouthren esouthren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add missing m3 max width/height constraints

3 participants

@guidezpl @esouthren @hannah-hyj