-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix the maths for floating pinned app bars. #11996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Hixie as far as I remember Please let me know if you need more info or sample to reproduce that issue |
|
I couldn't find an equivalent error in RenderSliverFloatingPersistentHeader. If you have an example that would be very useful. |
|
I have checked with latest version of Flutter, looks like there was some changes since my PR. changing maxExtent to minExtent in render class does not affect NestedScrollView anymore. Please use Gist from @HansMuller for testing: https://gist.github.com/HansMuller/facae02ce97892eaa2f159ea50c45e61 Issue easy to replicate with |
|
@nonameden I don't really understand that issue. Can you file a bug for it? Then we can handle it separately. |
|
Already did: #11222 |
|
Great, thanks. That looks like a separate issue. |
|
Yep, but before it was fixable with |
|
LGTM |
No description provided.