Skip to content

Migrate activation issue template to Github form issues #119916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 26 commits into from
Feb 28, 2023
Merged

Migrate activation issue template to Github form issues #119916

auto-submit merged 26 commits into from
Feb 28, 2023

Conversation

@exaby73
Copy link
Member

@exaby73 exaby73 commented Feb 3, 2023 •
edited
Loading

Closes #119914

New form preview

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@google-cla
Copy link

google-cla bot commented Feb 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@exaby73 exaby73 force-pushed the bug-report-issue-template branch 2 times, most recently from ee5669e to 0c217e8 Compare February 3, 2023 12:17
@darshankawar
Copy link
Member

darshankawar commented Feb 3, 2023

Please add screenshot of the updated template so that team member(s) reviewing this would see a preview of changes made as part of this PR.

@exaby73
Copy link
Member Author

exaby73 commented Feb 3, 2023

@darshankawar Added a screenshot to #119916 (comment)

@goderbauer goderbauer added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 7, 2023
stuartmorgan-g
stuartmorgan-g requested changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the CI failures, it looks like this code and these links will need to be updated as well.

@exaby73
Copy link
Member Author

exaby73 commented Feb 15, 2023

Updated the screenshot of the form preview to reflect the changes I pushed

@exaby73 exaby73 force-pushed the bug-report-issue-template branch 2 times, most recently from 6f43094 to f505adb Compare February 23, 2023 11:14
stuartmorgan-g
stuartmorgan-g reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting back to this review. It looks like you ran the autoformatter on the Dart code, which makes it really hard to review the changes there (and violates this repo's style guide). Could you revert the autoformat changes?

@bleroux bleroux force-pushed the bug-report-issue-template branch from 370a774 to 4121063 Compare February 27, 2023 13:35
stuartmorgan-g
stuartmorgan-g approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of wording/grammar nits I missed before, but otherwise it looks great; LGTM!

.github/ISSUE_TEMPLATE/1_activation.yml Outdated
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This should say "them" instead of "it" since it's referring to "the logs".

.github/ISSUE_TEMPLATE/1_activation.yml Outdated
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: how about just "Please do not upload screenshots of text."? It's possible to misread this as written as saying not to upload text output.

@bleroux bleroux force-pushed the bug-report-issue-template branch from 4121063 to 7469955 Compare February 27, 2023 16:09
@bleroux bleroux force-pushed the bug-report-issue-template branch from 7469955 to 9a40a8e Compare February 27, 2023 22:56
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit auto-submit bot merged commit e5a382e into flutter:master Feb 28, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2023
@engine-flutter-autoroll
e5a382e Migrate activation issue template to Github form issues (flut…
9ae0f81 
…ter/flutter#119916)
@bleroux bleroux deleted the bug-report-issue-template branch March 1, 2023 08:59
bartekpacia added a commit to leancodepl/patrol that referenced this pull request Mar 26, 2023
@bartekpacia
improve bug report template
c93bc35 
Inspired by flutter/flutter#119916
@bartekpacia bartekpacia mentioned this pull request Mar 26, 2023
Merged
bartekpacia added a commit to leancodepl/patrol that referenced this pull request Mar 26, 2023
@bartekpacia
improve bug report template
eef2d0b 
Inspired by flutter/flutter#119916
bartekpacia added a commit to leancodepl/patrol that referenced this pull request Mar 26, 2023
@bartekpacia
improve bug report template
b172290 
Inspired by flutter/flutter#119916
bartekpacia added a commit to leancodepl/patrol that referenced this pull request Mar 26, 2023
@bartekpacia
improve bug report template (#1122)
4ea777a 
Inspired by flutter/flutter#119916
bartekpacia added a commit to leancodepl/patrol that referenced this pull request Mar 26, 2023
@bartekpacia
improve bug report template (#1122)
f6fb209 
Inspired by flutter/flutter#119916
@bartekpacia bartekpacia mentioned this pull request Mar 26, 2023
Merged
bartekpacia added a commit to leancodepl/patrol that referenced this pull request Mar 26, 2023
@bartekpacia
improve bug report template (#1122)
845114a 
Inspired by flutter/flutter#119916
bartekpacia added a commit to leancodepl/patrol that referenced this pull request Mar 26, 2023
@bartekpacia
improve bug report template (#1125)
742aa66 
* improve bug report template (#1122)

Inspired by flutter/flutter#119916

* delete bug_report.md

* reword description of reproduction steps
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
e5a382e Migrate activation issue template to Github form issues (flut…
61eb1c4 
…ter/flutter#119916)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
e5a382e Migrate activation issue template to Github form issues (flut…
5a94675 
…ter/flutter#119916)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate "Activation / Installing Flutter" issue template to Github forms

5 participants

@exaby73 @darshankawar @stuartmorgan-g @bleroux @goderbauer