[CP] Fix lexer issue where select/plural/other/underscores cannot be in identifier names #119862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
Contributor
|
@thkim1011 can you help us wit a rebase? |
thkim1011
force-pushed
the
tae/cp-lexer
branch
from
0eef89a to
10829d8
Compare
godofredoc
approved these changes
Feb 8, 2023
Contributor
|
Landing with codesign failures as they are not supposed to pass in presubmit. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2023
…t be in identifier names. (#119190) (flutter/flutter#119862)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2023
…t be in identifier names. (#119190) (flutter/flutter#119862)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 9, 2023
…#3185) * 9bbe247fc Fix lexer issue where select/plural/other/underscores cannot be in identifier names. (#119190) (flutter/flutter#119862) * 4c3796466 [cp] Stop recursively including assets from asset folders (flutter/flutter#120209) * 994429713 Roll engine version. (flutter/flutter#120324)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2023
…t be in identifier names. (#119190) (flutter/flutter#119862)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 10, 2023
…t be in identifier names. (#119190) (flutter/flutter#119862)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 22, 2023
…t be in identifier names. (#119190) (flutter/flutter#119862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been reports of builds failing due to a bug in the lexer for the ICU messageFormat syntax parser. Original PR: #119190.