Run Mac hostonly tests on any available arch #119762

jmagman · 2023-02-01T23:12:10Z

M1 capacity has now been added. Another attempt at #109889.

Allow Mac hostonly (not devicelab or benchmark) tests to run on any available architecture, not just x64 Intel machines.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2023-02-01T23:12:54Z

.ci.yaml

      os: Mac-12
      device_type: none
-      cpu: x86 # TODO(jmagman): https://github.com/flutter/flutter/issues/112130
+      cpu: arm64


This line will be removed before merge. I've temporarily set this to arm to force all "Mac" tests to run there to validate they pass on this PR.

jmagman · 2023-02-01T23:13:24Z

.ci.yaml

-    dimensions:
-      cpu: "arm64"


I believe this is redundant since Mac_arm64 is specified.

jmagman · 2023-02-02T00:17:31Z

Mac plugin_test_ios timed out at 30 minutes, even though it's only taking 14 minutes in prod. Will keep that one on x64 while it's being investigated: #119764

I also can't move the web tests onto arm due to a Chrome cipd tag issue: #110113 (comment)

jmagman · 2023-02-02T00:50:26Z

.ci.yaml

-    dimensions:
-      cpu: "arm64"


I believe this is redundant since Mac_arm64 is specified.

jmagman · 2023-02-02T00:50:36Z

.ci.yaml

    recipe: flutter/flutter_drone
    timeout: 60
    properties:
-      cpu: arm64


jmagman · 2023-02-02T00:51:33Z

Reverted the changes to force "Mac" tests to run on arm, as well as the web tests that bumped Chrome version (will address that in another PR with input from the web team).

This is ready to review!

jmagman · 2023-02-02T03:09:44Z

This caused the hostonly Mac benchmarks to run on bots with different specs: #119780

This reverts commit 475fc4a.

) This reverts commit 475fc4a.

…#119762)

* 254a796 Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (flutter/flutter#119729) * 1573c12 Marks Mac_android microbenchmarks to be unflaky (flutter/flutter#119727) * 5613ab0 remove unnecessary parens (flutter/flutter#119736) * 1305a50 Roll Flutter Engine from c08a286d60e9 to ba3adb74d952 (5 revisions) (flutter/flutter#119741) * 484d881 [conductor] update console link (flutter/flutter#118338) * 73124dc Fix `ListTileThemeData.copyWith` doesn't override correct properties (flutter/flutter#119738) * bc8927c 2b8dd4e5c Use Windows high contrast black/white theme with `MaterialApp` themes (flutter/engine#39206) (flutter/flutter#119747) * 578edfc Catch errors thrown while handling pointer events (flutter/flutter#119577) * 8fd5d4e Remove deprecated SystemNavigator.routeUpdated method (flutter/flutter#119187) * 7a926dc Deprecate MediaQuery[Data].fromWindow (flutter/flutter#119647) * cd118da Update a test expectation that depended on an SkParagraph fix (flutter/flutter#119756) * 4ae2d3b 🔥 Do not format the messages file for `gen-l10n` (flutter/flutter#119596) * 8f5949e Roll Flutter Engine from 2b8dd4e5c699 to a12d102773dd (2 revisions) (flutter/flutter#119758) * 4c99da6 Avoid printing blank lines between "Another exception was thrown:" messages. (flutter/flutter#119587) * 2ecf4ae Update the counter app to enable Material 3 (flutter/flutter#118835) * 0b8486d 29d09845f Roll Dart SDK from b47964e5d575 to 1c219a91e637 (1 revision) (flutter/engine#39324) (flutter/flutter#119763) * ca7b7e3 Roll Flutter Engine from 29d09845f21e to 97d27ff59459 (2 revisions) (flutter/flutter#119765) * 475fc4a Run Mac hostonly tests on any available arch (flutter/flutter#119762) * 322d10e 18118e10a Add iOS spring animation objc files (flutter/engine#38801) (flutter/flutter#119768) * f767f86 check if directory exists before listing content (flutter/flutter#119748) * 34730c7 Revert "Run Mac hostonly tests on any available arch (#119762)" (flutter/flutter#119784) * f9daa9a Roll Flutter Engine from 18118e10a0a5 to 679c4b42e222 (4 revisions) (flutter/flutter#119783) * fd76ef0 Reland "Add API for discovering assets" (flutter/flutter#119277) * ca0596e Fix `pub get --unknown-flag` (flutter/flutter#119622) * 9abb6d7 Roll Plugins from 9da327c to 9302d87 (11 revisions) (flutter/flutter#119825) * 9eafbcc Roll Flutter Engine from 679c4b42e222 to 388890a98e5b (6 revisions) (flutter/flutter#119830) * 1ee8799 Revert "[Re-land] Exposed tooltip longPress (#118796)" (flutter/flutter#119832) * 07b51a0 Add missing variants and *new* indicators to `useMaterial3` docs (flutter/flutter#119799) * 201380a e9e601c7c [web] Hide autofill overlay (flutter/engine#39294) (flutter/flutter#119833) * 1c0065c 27f55219d Roll Fuchsia Linux SDK from QxkjqmRgowkk_n2NZ... to pWloCaRzjLEAUvQEz... (flutter/engine#39339) (flutter/flutter#119838) * e7d934a Marks Linux_android android_choreographer_do_frame_test to be flaky (flutter/flutter#119721) * 3f986e4 Roll Flutter Engine from 27f55219df79 to ae38c9585a61 (2 revisions) (flutter/flutter#119840) * b0f1714 Make Flex,Row,Column const for real (flutter/flutter#119673) * d4b6898 [web] Put all index.html operations in one place (flutter/flutter#118188) * d63987f Parser machine logs (flutter/flutter#118707) * 22bbdf0 Android defines target update (flutter/flutter#119766) * 8387c23 [flutter_tools] Use base DAP detach and ensure correct output (flutter/flutter#119076) * d820aec Manual pub roll with dwds fix (flutter/flutter#119575) * 72f9cf5 Roll Flutter Engine from ae38c9585a61 to 616ecd8be3de (3 revisions) (flutter/flutter#119859) * cfdc358 roll packages (flutter/flutter#119865) * d875899 Bump test Chrome version for Mac arm support (flutter/flutter#119773) * 9b86a48 Fix gets removedItem instead of its index (flutter/flutter#119638) * 66b2ca6 Roll Flutter Engine from 616ecd8be3de to 2871970337df (3 revisions) (flutter/flutter#119870) * c626460 Make `_focusDebug` not interpolate in debug mode (flutter/flutter#119680) * a27802e flutter_tool: remove explicit length header in HTTP response (flutter/flutter#119869) * 3570cce Remove deprecated kind in GestureRecognizer et al (flutter/flutter#119572) * bc45b18 2696fff87 Roll Skia from c2d81db3ef41 to 4f0166baf5a4 (13 revisions) (flutter/engine#39348) (flutter/flutter#119879) * f3effce Roll Flutter Engine from 2696fff8716d to e3fe6dade964 (3 revisions) (flutter/flutter#119892) * 69421c1 [framework] use shader tiling instead of repeated calls to drawImage (flutter/flutter#119495) * 6b83eff Roll Flutter Engine from e3fe6dade964 to 655530e3fd15 (5 revisions) (flutter/flutter#119905) * a5d8a4a 67d35267c [Impeller] Use minimal coverage for stencil restores after overdraw prevention (flutter/engine#39358) (flutter/flutter#119910) * fc8ea56 0fb48ce5b Roll Dart SDK from 69452c5012d9 to be795cc64bd7 (1 revision) (flutter/engine#39360) (flutter/flutter#119926) * e0b2138 Dispose OverlayEntry in TooltipState. (flutter/flutter#117291) * c5e8757 Add M3 support for iconbuttons in error state in TextFields (flutter/flutter#119925)

jmagman added 2 commits February 1, 2023 15:06

Run Mac hostonly presubmit tests on any available arch

ce3466e

Force all Mac tests to run on arm64 to validate in presubmit

b9d07ca

jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Feb 1, 2023

jmagman requested a review from keyonghan as a code owner February 1, 2023 23:12

jmagman commented Feb 1, 2023

View reviewed changes

.ci.yaml

Comment on lines -4917 to -4918

dimensions:

cpu: "arm64"

Copy link

Member Author

jmagman Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is redundant since Mac_arm64 is specified.

jmagman mentioned this pull request Feb 1, 2023

Allow web Chrome tests to run on arm64 Macs #110113

Closed

Go back to web tests on x64

94cb149

jmagman mentioned this pull request Feb 2, 2023

Running Mac plugin_test_ios on an arm Mac times out #119764

Closed

jmagman added 3 commits February 1, 2023 16:18

Run plugin_test_ios on x64

af7868b

Try Chrome 110 on arm

849b336

Revert chrome bump, remove forcing arm64

8e4e49e

jmagman commented Feb 2, 2023

View reviewed changes

jmagman requested a review from yusuf-goog February 2, 2023 00:51

Update issue number

5e05186

yusuf-goog approved these changes Feb 2, 2023

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2023

auto-submit bot merged commit 475fc4a into flutter:master Feb 2, 2023

jmagman deleted the hostonly-arch branch February 2, 2023 02:37

This was referenced Feb 2, 2023

Bump test Chrome version for Mac arm support #119773

Merged

Mac benchmark tests are running on different spec bots #119780

Closed

jmagman mentioned this pull request Feb 2, 2023

Only run Mac devicelab recipe tests on x64 #119781

Closed

8 tasks

jmagman added a commit that referenced this pull request Feb 2, 2023

Revert "Run Mac hostonly tests on any available arch (#119762)"

69dbc3a

This reverts commit 475fc4a.

jmagman mentioned this pull request Feb 2, 2023

Revert "Run Mac hostonly tests on any available arch" #119784

Merged

auto-submit bot mentioned this pull request Feb 2, 2023

Review request for Revert PR flutter/flutter#119784 #119785

Closed

auto-submit bot pushed a commit that referenced this pull request Feb 2, 2023

Revert "Run Mac hostonly tests on any available arch (#119762)" (#119784

34730c7

) This reverts commit 475fc4a.

engine-flutter-autoroll mentioned this pull request Feb 2, 2023

Roll Flutter from 1573c12963c6 to 9abb6d7076bd (23 revisions) flutter/packages#3147

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

dfb1268

…#119762)

engine-flutter-autoroll mentioned this pull request Feb 2, 2023

Roll Flutter from d27880801435 to 9abb6d7076bd (25 revisions) flutter/plugins#7083

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

e25d9fe

…#119762)

engine-flutter-autoroll mentioned this pull request Feb 2, 2023

Roll Flutter from 1573c12963c6 to 9eafbcc8bea9 (24 revisions) flutter/packages#3150

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

637af54

…#119762)

engine-flutter-autoroll mentioned this pull request Feb 2, 2023

Roll Flutter from d27880801435 to 9eafbcc8bea9 (26 revisions) flutter/plugins#7085

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

861bf3d

…#119762)

engine-flutter-autoroll mentioned this pull request Feb 2, 2023

Roll Flutter from 1573c12963c6 to 1ee87990dc76 (25 revisions) flutter/packages#3151

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

a7f2e49

…#119762)

engine-flutter-autoroll mentioned this pull request Feb 2, 2023

Roll Flutter from 1573c12963c6 to 07b51a0dbbfb (26 revisions) flutter/packages#3152

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

4448079

…#119762)

engine-flutter-autoroll mentioned this pull request Feb 2, 2023

Roll Flutter from 1573c12963c6 to 201380ab2698 (27 revisions) flutter/packages#3153

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

c9753de

…#119762)

engine-flutter-autoroll mentioned this pull request Feb 2, 2023

Roll Flutter from d27880801435 to 201380ab2698 (29 revisions) flutter/plugins#7086

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

b813c5c

…#119762)

engine-flutter-autoroll mentioned this pull request Feb 2, 2023

Roll Flutter from d27880801435 to e7d934a01466 (31 revisions) flutter/plugins#7088

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

57815c4

…#119762)

This was referenced Feb 3, 2023

Running Mac framework_tests* on arm64 Macs flakes with "Skia Gold received an unapproved image in post-submit" #119880

Open

Run Mac hostonly tests on any available arch #119884

Merged

engine-flutter-autoroll mentioned this pull request Feb 3, 2023

Roll Flutter from d27880801435 to c5e8757fcb79 (54 revisions) flutter/plugins#7092

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 3, 2023

475fc4a Run Mac hostonly tests on any available arch (flutter/flutter…

cdfa610

…#119762)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Run Mac hostonly tests on any available arch #119762

Run Mac hostonly tests on any available arch #119762

Uh oh!

jmagman commented Feb 1, 2023

Uh oh!

jmagman Feb 1, 2023

Uh oh!

jmagman Feb 1, 2023

Uh oh!

jmagman commented Feb 2, 2023

Uh oh!

jmagman Feb 2, 2023

Uh oh!

jmagman Feb 2, 2023

Uh oh!

jmagman commented Feb 2, 2023 •

edited

Loading

Uh oh!

jmagman commented Feb 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Run Mac hostonly tests on any available arch #119762

Run Mac hostonly tests on any available arch #119762

Uh oh!

Conversation

jmagman commented Feb 1, 2023

Pre-launch Checklist

Uh oh!

jmagman Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman commented Feb 2, 2023

Uh oh!

jmagman Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman commented Feb 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Feb 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jmagman commented Feb 2, 2023 •

edited

Loading