CP: Fix null check error in DWDS #119745
Merged
CP: Fix null check error in DWDS #119745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
Member
|
Presubmit failure looks unrelated, but GitHub is also saying that this PR needs a rebase, so maybe that's the issue? |
Contributor
Author
Mac verify_binaries_codesigned will usually fail on a cherrypick PR, as the engine binaries won't be codesigned until the release is prepared. I will check upstream and probably rebase. |
godofredoc
approved these changes
Feb 4, 2023
Contributor
|
Ignoring the test failures as they should not be running on release candidate branches. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 8, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 8, 2023
…#3180) * 200bc35ec Make gen-l10n error handling independent of logger state (#119644) (flutter/flutter#119679) * 7c2870772 cherrypick fix to dwds (flutter/flutter#119745) * 80f3571a8 check if directory exists before listing content (#119748) (flutter/flutter#119946) * 78d09b68d Do not run customer testing on release candidate branches. (#119979) (flutter/flutter#119984) * c6ab0a013 Cherry pick NavigationBar ink ripple fixes (flutter/flutter#119553) * 22908563c Verify Mac artifact codesigning on x64 and arm64 (flutter/flutter#120153) * 32fb2f948 Update Engine revision to f40b73f8a4d5bc2bf50b21e3c0fb478b8f282486 for stable release 3.7.2 (flutter/flutter#120263)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicks of a subset of the upstream DWDS change dart-lang/webdev@be616cd to fix #119084