Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jan 28, 2023

Fixes #119385
Cherrypick of #116622

* init

* add comment

* make error more actionable
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 28, 2023
@christopherfujino christopherfujino changed the title Throw error when plural case had undefined behavior (#116622) CP: Throw error when plural case had undefined behavior (#116622) Jan 28, 2023
@christopherfujino
Copy link
Contributor Author

All of the CI failures look to me like infra-issues related to the branch point, and not the change in question, except possibly customer_testing:

>> flutter analyze --no-fatal-infos
| Analyzing tests...
|
|   error • The method 'toleranceFor' isn't defined for the type '_SnappingScrollPhysics' • lib/pages/home.dart:985:23 • undefined_method
|
| 1 issue found. (ran in 23.7s)
ERROR: One or more tests from flutter_gallery failed.
Deleting temporary directory...
Contact: [email protected]

I'll check if this had to be fixed upstream around the time the original fix landed.

@XilaiZhang XilaiZhang merged commit ff6e9d4 into flutter:flutter-3.7-candidate.1 Feb 1, 2023
@christopherfujino christopherfujino deleted the 3.7.0-cherrypicks branch February 1, 2023 18:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 2, 2023
…#3143)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 3, 2023
stuartmorgan-g pushed a commit to flutter/plugins that referenced this pull request Feb 3, 2023
…#7091)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
waegari pushed a commit to waegari/flutter_plugins that referenced this pull request Jul 3, 2025
…flutter#7091)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants