Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation #119199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
LongCatIsLooong
commented
Jan 25, 2023
| ); | ||
|
|
||
| final Finder tooltip1 = find.byType(Tooltip); | ||
| await tester.pump(const Duration(days: 1)); |
Contributor
Author
There was a problem hiding this comment.
These tests (radio/switch/check box) were assuming the OverlayEntry tooltip updates when the Tooltip widget updates so I had to add code to wait for the previous tooltip to dismiss.
Contributor
|
The _revealLastTooltip was to deal with nested widgets which each had a tooltip on them so that only the deepest one would be shown. See the before/after videos in this PR: |
Contributor
Author
|
Ah because MouseRegion doesn't notify you when you move from the inner MouseRegion to the outer one? |
LongCatIsLooong
force-pushed
the
tooltip-cleanup
branch
from
8e7d961 to
986560c
Compare
LongCatIsLooong
force-pushed
the
tooltip-cleanup
branch
from
986560c to
adc0176
Compare
Contributor
Yes. |
LongCatIsLooong
force-pushed
the
tooltip-cleanup
branch
from
8437693 to
ca0b6b3
Compare
LongCatIsLooong
force-pushed
the
tooltip-cleanup
branch
from
ca0b6b3 to
8138715
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
d: api docs
Contributor
Author
|
Hi @gspencergoog would you like to take a look at this one when you get a chance? |
gspencergoog
approved these changes
May 18, 2023
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
This looks a lot better.
| /// Signature for when a tooltip is triggered. | ||
| typedef TooltipTriggeredCallback = void Function(); | ||
|
|
||
| // A special [MouseRegion] that when nested, only the first [_ExclusiveMouseRegion] |
Contributor
There was a problem hiding this comment.
No need for the brackets in this comment, it's not a dartdoc comment, unless you want to make it one. If you did, then the links would be live in an IDE, so it might be a good idea, even though it's a private class.
Contributor
Author
There was a problem hiding this comment.
Do you mean using /// instead of //?
Contributor
Author
There was a problem hiding this comment.
Changed to ///.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2023
…Region logic & animation (flutter/flutter#119199)
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 26, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 26, 2023
…Region logic & animation (flutter/flutter#119199)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 26, 2023
Roll Flutter from 216605b to ee162e4 (53 revisions) flutter/flutter@216605b...ee162e4 2023-05-26 [email protected] Roll Packages from 995bfc5 to 9f8dcc5 (4 revisions) (flutter/flutter#127671) 2023-05-26 [email protected] Roll Flutter Engine from 474fcbbe445e to 8573f3b63a1f (1 revision) (flutter/flutter#127647) 2023-05-26 [email protected] Roll Flutter Engine from f63fcf5a274e to 474fcbbe445e (1 revision) (flutter/flutter#127644) 2023-05-26 [email protected] Roll Flutter Engine from b6fcbe31ba1a to f63fcf5a274e (1 revision) (flutter/flutter#127642) 2023-05-26 [email protected] Roll Flutter Engine from bec5da5bff7c to b6fcbe31ba1a (1 revision) (flutter/flutter#127641) 2023-05-26 [email protected] Roll Flutter Engine from 593d4d6b1f9b to bec5da5bff7c (2 revisions) (flutter/flutter#127638) 2023-05-26 [email protected] Roll Flutter Engine from f4dc96aef71b to 593d4d6b1f9b (1 revision) (flutter/flutter#127635) 2023-05-26 [email protected] Roll Flutter Engine from ff04d2fdd12b to f4dc96aef71b (2 revisions) (flutter/flutter#127633) 2023-05-26 [email protected] Remove a bad assert from tooltip implementation (flutter/flutter#127629) 2023-05-26 [email protected] Remove rounding from TextPainter (flutter/flutter#127099) 2023-05-26 [email protected] Adds `TestDisplay` API for testing `Display` features (flutter/flutter#127525) 2023-05-25 [email protected] Roll Flutter Engine from 6a4e675ab0b4 to ff04d2fdd12b (3 revisions) (flutter/flutter#127630) 2023-05-25 [email protected] Roll Flutter Engine from 99f2653cbb79 to 6a4e675ab0b4 (2 revisions) (flutter/flutter#127625) 2023-05-25 [email protected] Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/flutter#127537) 2023-05-25 [email protected] Indent markdown value on CP issue template (flutter/flutter#127623) 2023-05-25 [email protected] Roll Flutter Engine from 6ff02c17268f to 99f2653cbb79 (6 revisions) (flutter/flutter#127619) 2023-05-25 [email protected] `ProcessResultMatcher` created and used in test (flutter/flutter#127414) 2023-05-25 [email protected] Fix yaml lint issue (flutter/flutter#127600) 2023-05-25 [email protected] Roll Flutter Engine from 515a4bfc4b6e to 6ff02c17268f (1 revision) (flutter/flutter#127609) 2023-05-25 [email protected] `SearchBar` should not be impacted by overall `InputDecorationTheme` (flutter/flutter#127465) 2023-05-25 [email protected] Roll Flutter Engine from 195009b91abd to 515a4bfc4b6e (4 revisions) (flutter/flutter#127601) 2023-05-25 [email protected] Roll Flutter Engine from fb463217d1f3 to 195009b91abd (1 revision) (flutter/flutter#127591) 2023-05-25 [email protected] avoid incorrect usage of TimelineTask (flutter/flutter#127527) 2023-05-25 [email protected] Add `ScrollNotificationObserver` sample (flutter/flutter#127023) 2023-05-25 [email protected] Roll Packages from fba97fa to 995bfc5 (3 revisions) (flutter/flutter#127590) 2023-05-25 [email protected] Roll Flutter Engine from a74d9d1f4776 to fb463217d1f3 (1 revision) (flutter/flutter#127577) 2023-05-25 [email protected] Roll Flutter Engine from a7f026b03e35 to a74d9d1f4776 (1 revision) (flutter/flutter#127565) 2023-05-25 [email protected] Roll Flutter Engine from fb38bb6b1bc1 to a7f026b03e35 (1 revision) (flutter/flutter#127563) 2023-05-25 [email protected] Roll Flutter Engine from 2be736c390ee to fb38bb6b1bc1 (1 revision) (flutter/flutter#127560) 2023-05-25 [email protected] Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation (flutter/flutter#119199) 2023-05-25 [email protected] Roll Flutter Engine from 37ebad2d5c27 to 2be736c390ee (2 revisions) (flutter/flutter#127554) 2023-05-25 [email protected] Roll Flutter Engine from 62a83490ee60 to 37ebad2d5c27 (1 revision) (flutter/flutter#127551) 2023-05-25 [email protected] Roll Flutter Engine from 1bed04a4375a to 62a83490ee60 (3 revisions) (flutter/flutter#127546) 2023-05-25 [email protected] Roll Flutter Engine from 6a361090a367 to 1bed04a4375a (2 revisions) (flutter/flutter#127544) 2023-05-25 [email protected] Roll Flutter Engine from 9ba461efd3fe to 6a361090a367 (3 revisions) (flutter/flutter#127542) 2023-05-24 [email protected] Revert "Update labeler action wildcards" (flutter/flutter#127541) 2023-05-24 [email protected] [web] ui.platformViewRegistry => ui_web.platformViewRegistry (flutter/flutter#127493) 2023-05-24 [email protected] Roll Flutter Engine from c641f6307f08 to 9ba461efd3fe (6 revisions) (flutter/flutter#127536) 2023-05-24 [email protected] Add missing parameters in `TextFormField` (flutter/flutter#127020) 2023-05-24 [email protected] Update labeler action wildcards (flutter/flutter#127524) 2023-05-24 [email protected] Improve `TextPainter.layout` caching (flutter/flutter#118128) 2023-05-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 (flutter/flutter#127533) 2023-05-24 [email protected] Fix ScrollPosition overscroll precision error (flutter/flutter#127321) 2023-05-24 [email protected] `Slider.onChangeStart` & `Slider.onChangeEnd` are not called on keyboard shortcuts (flutter/flutter#126896) 2023-05-24 [email protected] Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 (flutter/flutter#127514) 2023-05-24 [email protected] Update CP template to include timeline and changelog (flutter/flutter#127507) ...
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…Region logic & animation (flutter/flutter#119199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…Region logic & animation (flutter/flutter#119199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117627
Behavior changes:
waitDuration.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.