Make MultiChildRenderObjectWidget const #119195

goderbauer · 2023-01-25T23:00:15Z

~~Submission is blocked on flutter/plugins#7030 rolling into flutter/flutter to make the Linux flutter_plugins check green.~~

Fixes #108248.
Part of #118837.

This change fixes this TODO:

flutter/packages/flutter/lib/src/widgets/framework.dart

Lines 1858 to 1860 in a45727d

    
             // TODO(goderbauer): Make this const and fix fallout, https://github.com/flutter/flutter/issues/108248 
        
             // ignore: prefer_const_constructors_in_immutables 
        
             MultiChildRenderObjectWidget({ super.key, this.children = const <Widget>[] });

Everything else is fallout from that tiny fix generated by dart fix --apply.

codecov-commenter · 2023-01-25T23:33:48Z

Codecov Report

Merging #119195 (a45727d) into master (a45727d) will not change coverage.
The diff coverage is n/a.

❗ Current head a45727d differs from pull request most recent head a4c5bb4. Consider uploading reports for the commit a4c5bb4 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           master   #119195   +/-   ##
========================================
  Coverage   91.25%    91.25%           
========================================
  Files         548       548           
  Lines       95779     95779           
========================================
  Hits        87407     87407           
  Misses       8372      8372

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

goderbauer · 2023-01-26T17:49:06Z

I ran a TGP inside Google (OCL:504695867:BASE:504695554:1674754663403:2033cca2) and everything is passing. Customer tests are passing as well. In the plugins repo three examples apps are producing a new info-level lint each, which is dealt with by flutter/plugins#7030. Overall, this seems to be a (surprisingly) safe change to make.

jonahwilliams

LGTM

auto-submit · 2023-01-31T18:11:09Z

auto label is removed for flutter/flutter, pr: 119195, due to - The status or check suite Windows tool_integration_tests_6_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-01-31T18:15:09Z

auto label is removed for flutter/flutter, pr: 119195, due to - The status or check suite Windows tool_integration_tests_6_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-01-31T19:14:06Z

auto label is removed for flutter/flutter, pr: 119195, Failed to merge pr#: 119195 with Pull request could not be merged: Pull Request is not mergeable.

gustav3d · 2023-01-31T23:01:58Z

Is there no tests for the children of Flex ?
Its enum assert is not happy if const is used :(

ERROR: lib/CarWidget.dart:78:15: Error: Constant evaluation error:
ERROR: const Column(children:
ERROR: ^
ERROR: ../flutter/packages/flutter/lib/src/widgets/basic.dart:4459:34: Context: Binary operator '==' requires receiver constant 'CrossAxisAlignment {}' of type 'Null', 'bool', 'int', 'double', or 'String', but was of type 'CrossAxisAlignment'.
ERROR: - 'CrossAxisAlignment' is from 'package:flutter/src/rendering/flex.dart' ('../flutter/packages/flutter/lib/src/rendering/flex.dart').
ERROR: }) : assert(crossAxisAlignment != CrossAxisAlignment.baseline || textBaseline != null, 'textBaseline is required if you specify the crossAxisAlignment with CrossAxisAlignment.baseline');

albertodev01 · 2023-01-31T23:25:18Z

@goderbauer I can reproduce the issue mentioned by Gustav.

You can easily reproduce the issue by using a Flex widget with a child or more.

goderbauer · 2023-01-31T23:44:53Z

Can you file an issue with repo case about this and cc me?

* 472b887 0ec8e2802 Roll Fuchsia Mac SDK from 9y7C2oamTv6Py4JSC... to EAFnGijD0l5QxaPxF... (flutter/engine#39236) (flutter/flutter#119461) * 15cd00f a7bb0e410 Roll Fuchsia Linux SDK from 1D63BqURfJdG4r3CK... to xTXbcsPr5GJvFSLha... (flutter/engine#39238) (flutter/flutter#119482) * 530c3f2 [Re-land#2] Button padding M3 (flutter/flutter#119498) * 17eb2e8 Ability to disable the browser's context menu on web (flutter/flutter#118194) * df8ad3d roll packages (flutter/flutter#119370) * b68cebd roll packages (flutter/flutter#119530) * 59d80dc [Android] Add explicit exported tag to Linux_android flavors test (flutter/flutter#117542) * 458b298 Refactoring to use `ver` command instead of `systeminfo` (flutter/flutter#119304) * 54405bf fixes PointerEventConverter to handle malformed scrolling event (flutter/flutter#118124) * e69ea6d Support flipping mouse scrolling axes through modifier keys (flutter/flutter#115610) * 92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (flutter/engine#39139) (flutter/flutter#119546) * 7477d7a Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (flutter/flutter#119529) * 6c12e39 Introduce ParagraphBoundary subclass for text editing (flutter/flutter#116549) * b227df3 Hint text semantics to be excluded in a11y read out if hintText is not visible. (flutter/flutter#119198) * 18c7f8a Fix typo in --machine help text (flutter/flutter#119563) * 329f86a Make a few values non-nullable in cupertino (flutter/flutter#119478) * c4520bc b2efe0175 [web] Expose felt flag for building CanvasKit Chromium (flutter/engine#39201) (flutter/flutter#119567) * 8898f4f Marks Mac_android run_debug_test_android to be unflaky (flutter/flutter#117468) * 1f0b6fb Remove deprecated AppBar/SliverAppBar/AppBarTheme.textTheme member (flutter/flutter#119253) * edaeec8 Roll Flutter Engine from b2efe01754ef to 5011144c0b46 (3 revisions) (flutter/flutter#119578) * 865dc5c Roll Flutter Engine from 5011144c0b46 to daa8eeb7fc0b (2 revisions) (flutter/flutter#119584) * 1148a2a Migrate EditableTextState from addPostFrameCallbacks to compositionCallbacks (flutter/flutter#119359) * 2340902 Roll Flutter Engine from daa8eeb7fc0b to 77218818138f (3 revisions) (flutter/flutter#119586) * 65900b7 Remove deprecated AnimatedSize.vsync parameter (flutter/flutter#119186) * 5b6572f Add debug diagnostics to channels integration test (flutter/flutter#119579) * 504e565 Roll Flutter Engine from 77218818138f to 9448f2966c11 (3 revisions) (flutter/flutter#119592) * 7ba4406 Revert "[Re-land#2] Button padding M3 (#119498)" (flutter/flutter#119597) * 2c34a88 Roll Flutter Engine from 9448f2966c11 to 72abe0e4b828 (3 revisions) (flutter/flutter#119603) * df0ab40 Roll Plugins from ff84c44 to 9da327c (15 revisions) (flutter/flutter#119629) * 67d07a6 [flutter_tools] Fix parsing of existing DDS URIs from exceptions (flutter/flutter#119506) * d272a3a Reland: [macos] add flavor options to tool commands (flutter/flutter#119564) * a16d82c aa00da3c1 Roll Skia from fc31f43cc40a to 3c6eb76a683a (1 revision) (flutter/engine#39280) (flutter/flutter#119605) * f6b0c6d Use first Dart VM Service found with mDNS if there are duplicates (flutter/flutter#119545) * d4c7485 Make Decoration.padding non-nullable (flutter/flutter#119581) * 2fccf4d Remove MediaQuery from WidgetsApp (flutter/flutter#119377) * 9b3b9cf Roll Flutter Engine from aa00da3c1612 to cd2e8885e491 (6 revisions) (flutter/flutter#119639) * 6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195) * e2b3d89 Fix CupertinoNavigationBar should create a backward compatible Annota… (flutter/flutter#119515) * 7bf95f4 1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (flutter/flutter#119640) * 0e22aca Add support for image insertion on Android (flutter/flutter#110052) * ff22813 separatorBuilder can't return null (flutter/flutter#119566) * 60c1f29 2471f430f Update buildroot to c02da5072d1bb2. (flutter/engine#39292) (flutter/flutter#119645) * fbe9ff3 Disable an inaccurate test assertion that will be fixed by an engine roll (flutter/flutter#119653) * 8f90e2a Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (flutter/flutter#119655) * 3884381 Make gen-l10n error handling independent of logger state (flutter/flutter#119644) * 198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flutter#119033) * dc86565 Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (flutter/flutter#119670) * 82df235 Undo making Flex,Row,Column const (flutter/flutter#119669) * 6f9a896 Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (flutter/flutter#119675) * 8d0af36 🥅 Produce warning instead of error for storage base url overrides (flutter/flutter#119595) * 3894d24 1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (flutter/flutter#119683) * a752c2f Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (flutter/flutter#119439) * e1f0b1d d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (flutter/flutter#119686) * 97d273c CupertinoThemeData equality (flutter/flutter#119480) * 4167835 5b549950f Roll Fuchsia Linux SDK from 71lEeibIyrq0V8jId... to TFcelQ5SwrzkcYK2d... (flutter/engine#39312) (flutter/flutter#119688) * b4a6e34 0d87b1562 Roll Dart SDK from 8b57d23a7246 to de03e1f41b50 (1 revision) (flutter/engine#39313) (flutter/flutter#119695) * 3af30ff Roll Flutter Engine from 0d87b156265c to c08a286d60e9 (3 revisions) (flutter/flutter#119706) * d278808 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)

* 6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195) * e2b3d89 Fix CupertinoNavigationBar should create a backward compatible Annota… (flutter/flutter#119515) * 7bf95f4 1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (flutter/flutter#119640) * 0e22aca Add support for image insertion on Android (flutter/flutter#110052) * ff22813 separatorBuilder can't return null (flutter/flutter#119566) * 60c1f29 2471f430f Update buildroot to c02da5072d1bb2. (flutter/engine#39292) (flutter/flutter#119645) * fbe9ff3 Disable an inaccurate test assertion that will be fixed by an engine roll (flutter/flutter#119653) * 8f90e2a Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (flutter/flutter#119655) * 3884381 Make gen-l10n error handling independent of logger state (flutter/flutter#119644) * 198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flutter#119033) * dc86565 Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (flutter/flutter#119670) * 82df235 Undo making Flex,Row,Column const (flutter/flutter#119669) * 6f9a896 Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (flutter/flutter#119675) * 8d0af36 🥅 Produce warning instead of error for storage base url overrides (flutter/flutter#119595) * 3894d24 1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (flutter/flutter#119683) * a752c2f Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (flutter/flutter#119439) * e1f0b1d d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (flutter/flutter#119686) * 97d273c CupertinoThemeData equality (flutter/flutter#119480) * 4167835 5b549950f Roll Fuchsia Linux SDK from 71lEeibIyrq0V8jId... to TFcelQ5SwrzkcYK2d... (flutter/engine#39312) (flutter/flutter#119688) * b4a6e34 0d87b1562 Roll Dart SDK from 8b57d23a7246 to de03e1f41b50 (1 revision) (flutter/engine#39313) (flutter/flutter#119695) * 3af30ff Roll Flutter Engine from 0d87b156265c to c08a286d60e9 (3 revisions) (flutter/flutter#119706) * d278808 [Re-land] Exposed tooltip longPress (flutter/flutter#118796) * 254a796 Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (flutter/flutter#119729) * 1573c12 Marks Mac_android microbenchmarks to be unflaky (flutter/flutter#119727)

goderbauer force-pushed the constMCROW branch 2 times, most recently from 53e0fce to a4c5bb4 Compare January 25, 2023 23:20

goderbauer mentioned this pull request Jan 26, 2023

[in_app_purchase] Prep for more const widgets flutter/plugins#7030

Merged

goderbauer requested a review from loic-sharma January 26, 2023 18:13

jonahwilliams approved these changes Jan 26, 2023

View reviewed changes

loic-sharma approved these changes Jan 26, 2023

View reviewed changes

Make MultiChildRenderObjectWidget const

19c77e5

goderbauer force-pushed the constMCROW branch from a4c5bb4 to 19c77e5 Compare January 31, 2023 17:34

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023

goderbauer merged commit 6a54059 into flutter:master Jan 31, 2023

goderbauer deleted the constMCROW branch January 31, 2023 19:14

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023

albertodev01 mentioned this pull request Jan 31, 2023

MultiChildRenderObjectWidget const ctor #92628

Closed

albertodev01 mentioned this pull request Feb 1, 2023

Issue with newly added const widgets #119664

Closed

This was referenced Feb 1, 2023

Undo making Flex,Row,Column const #119669

Merged

Make Flex,Row,Column const for real #119673

Merged

This was referenced Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to b4a6e349a25b (20 revisions) flutter/packages#3133

Closed

Roll Flutter from 0a22a1dbf475 to b4a6e349a25b (56 revisions) flutter/plugins#7075

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

ed89540

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 1, 2023

6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

cf47afb

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to 3af30ff5913f (21 revisions) flutter/packages#3134

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

dc8028a

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to d27880801435 (22 revisions) flutter/packages#3137

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

b9446f5

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 0a22a1dbf475 to d27880801435 (58 revisions) flutter/plugins#7078

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 1, 2023

6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

1356a9c

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to 254a796bc3f8 (23 revisions) flutter/packages#3138

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

8f59753

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to 1573c12963c6 (24 revisions) flutter/packages#3140

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

9bbf6a4

AlexV525 mentioned this pull request Oct 6, 2023

3.3.2 build error OpenFlutter/flutter_oktoast#102

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make MultiChildRenderObjectWidget const #119195

Make MultiChildRenderObjectWidget const #119195

Uh oh!

goderbauer commented Jan 25, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Jan 25, 2023

Uh oh!

goderbauer commented Jan 26, 2023 •

edited

Loading

Uh oh!

jonahwilliams left a comment

Uh oh!

auto-submit bot commented Jan 31, 2023

Uh oh!

auto-submit bot commented Jan 31, 2023

Uh oh!

auto-submit bot commented Jan 31, 2023

Uh oh!

gustav3d commented Jan 31, 2023

Uh oh!

albertodev01 commented Jan 31, 2023

Uh oh!

goderbauer commented Jan 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	// TODO(goderbauer): Make this const and fix fallout, https://github.com/flutter/flutter/issues/108248
	// ignore: prefer_const_constructors_in_immutables
	MultiChildRenderObjectWidget({ super.key, this.children = const <Widget>[] });

Make MultiChildRenderObjectWidget const #119195

Make MultiChildRenderObjectWidget const #119195

Uh oh!

Conversation

goderbauer commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 25, 2023

Codecov Report

Uh oh!

goderbauer commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 31, 2023

Uh oh!

auto-submit bot commented Jan 31, 2023

Uh oh!

auto-submit bot commented Jan 31, 2023

Uh oh!

gustav3d commented Jan 31, 2023

Uh oh!

albertodev01 commented Jan 31, 2023

Uh oh!

goderbauer commented Jan 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

goderbauer commented Jan 25, 2023 •

edited

Loading

goderbauer commented Jan 26, 2023 •

edited

Loading