Skip to content

Conversation

@Skylled
Copy link
Contributor

@Skylled Skylled commented Sep 1, 2017

Fixes #11890

this.backgroundColor,
this.onExpansionChanged,
this.children: const <Widget>[],
this.trailing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trailing comma

@Hixie
Copy link
Contributor

Hixie commented Sep 6, 2017

Needs a test.

@Skylled
Copy link
Contributor Author

Skylled commented Sep 7, 2017

While I'm poking around in here, is there a reason two_level_list_test.dart hasn't been renamed to expansion_tile_test.dart?

@Hixie
Copy link
Contributor

Hixie commented Sep 7, 2017

No good reason...

@Hixie
Copy link
Contributor

Hixie commented Sep 7, 2017

Test looks great, thanks!

@Hixie
Copy link
Contributor

Hixie commented Sep 14, 2017

LGTM
Thanks for your contribution! I will land this now that the tree is calm.

@Hixie Hixie merged commit 016f939 into flutter:master Sep 14, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExpansionTile optional trailing icon

3 participants