Skip to content

[flutter roll] Revert "[Re-land] Button padding m3" #118962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyHillers merged 1 commit into from
Jan 23, 2023
Merged

[flutter roll] Revert "[Re-land] Button padding m3" #118962

CaseyHillers merged 1 commit into from
Jan 23, 2023

Conversation

@XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Jan 21, 2023 •
edited
Loading

Reverts #118640

Context: https://b.corp.google.com/issues/265937608.
There seems to be a real breakage among the scuba changes introduced.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jan 21, 2023
@XilaiZhang XilaiZhang changed the title Revert "[Re-land] Button padding m3" [flutter roll] Revert "[Re-land] Button padding m3" Jan 21, 2023
@XilaiZhang
Copy link
Contributor Author

XilaiZhang commented Jan 21, 2023

closing pr. Matas will help provide a g3 fix

@XilaiZhang XilaiZhang closed this Jan 21, 2023
@XilaiZhang
Copy link
Contributor Author

XilaiZhang commented Jan 23, 2023

reopen pr in case Matas' g3 fix isn't ready

@XilaiZhang XilaiZhang reopened this Jan 23, 2023
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 23, 2023

auto label is removed for flutter/flutter, pr: 118962, due to - The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CaseyHillers
Copy link
Contributor

CaseyHillers commented Jan 23, 2023

Merging as LUCI checks are green

@CaseyHillers CaseyHillers merged commit 71a4256 into master Jan 23, 2023
@CaseyHillers CaseyHillers deleted the revert-118640-button_padding_m3 branch January 23, 2023 17:27
This was referenced Jan 24, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2023
@engine-flutter-autoroll
71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutt…
dcdeffb 
…er#118962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 24, 2023
@engine-flutter-autoroll
71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutt…
4c3fcc5 
…er#118962)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 24, 2023
@engine-flutter-autoroll
Roll Flutter from bd7bee0 to c35efda (24 revisions) (#3085)
a095576 
* 3bf7960 [web] Fix paths fetched by flutter.js (flutter/flutter#118684)

* e71e8da 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009)

* 71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962)

* 90ffb1c 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010)

* 224e6aa Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926)

* 6cd4945 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862)

* a63e19b Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863)

* 19dfde6 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910)

* 392dffe Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930)

* 5e50ed9 Test Utf8FromUtf16 (flutter/flutter#118647)

* edb571e Update README.md (flutter/flutter#118803)

* 38630b6 Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857)

* 332aed9 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023)

* 84071aa Add todo for linux defines test. (flutter/flutter#119035)

* e8b7f4b [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000)

* df44208 Remove ThemeData.buttonColor references (flutter/flutter#118658)

* 6548616 Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916)

* 59767e5 Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022)

* 1906ce5 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021)

* 720bea0 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028)

* 0de8bef Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020)

* 2e8dd9d Run integration_ui_test_test_macos in prod (flutter/flutter#118919)

* 64b4c69 roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018)

* c35efda Remove superfluous words. (flutter/flutter#119008)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Jan 24, 2023
@engine-flutter-autoroll
Roll Flutter from bd7bee0 to c35efda (24 revisions) (#7017)
80e36c2 
* 3bf7960 [web] Fix paths fetched by flutter.js (flutter/flutter#118684)

* e71e8da 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009)

* 71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962)

* 90ffb1c 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010)

* 224e6aa Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926)

* 6cd4945 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862)

* a63e19b Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863)

* 19dfde6 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910)

* 392dffe Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930)

* 5e50ed9 Test Utf8FromUtf16 (flutter/flutter#118647)

* edb571e Update README.md (flutter/flutter#118803)

* 38630b6 Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857)

* 332aed9 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023)

* 84071aa Add todo for linux defines test. (flutter/flutter#119035)

* e8b7f4b [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000)

* df44208 Remove ThemeData.buttonColor references (flutter/flutter#118658)

* 6548616 Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916)

* 59767e5 Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022)

* 1906ce5 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021)

* 720bea0 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028)

* 0de8bef Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020)

* 2e8dd9d Run integration_ui_test_test_macos in prod (flutter/flutter#118919)

* 64b4c69 roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018)

* c35efda Remove superfluous words. (flutter/flutter#119008)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#7017)
48869b3 
* 3bf7960 [web] Fix paths fetched by flutter.js (flutter/flutter#118684)

* e71e8da 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009)

* 71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962)

* 90ffb1c 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010)

* 224e6aa Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926)

* 6cd4945 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862)

* a63e19b Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863)

* 19dfde6 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910)

* 392dffe Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930)

* 5e50ed9 Test Utf8FromUtf16 (flutter/flutter#118647)

* edb571e Update README.md (flutter/flutter#118803)

* 38630b6 Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857)

* 332aed9 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023)

* 84071aa Add todo for linux defines test. (flutter/flutter#119035)

* e8b7f4b [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000)

* df44208 Remove ThemeData.buttonColor references (flutter/flutter#118658)

* 6548616 Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916)

* 59767e5 Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022)

* 1906ce5 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021)

* 720bea0 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028)

* 0de8bef Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020)

* 2e8dd9d Run integration_ui_test_test_macos in prod (flutter/flutter#118919)

* 64b4c69 roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018)

* c35efda Remove superfluous words. (flutter/flutter#119008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esouthren esouthren Awaiting requested review from esouthren

1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XilaiZhang @CaseyHillers