Remove unnecessary null checks in `flutter_tool` #118857

goderbauer · 2023-01-20T00:32:06Z

Dart 3 drops support for non-null safe code, so we can finally turn on the unnecessary_null_comparison lint and remove the unnecessary checks it flags.

The first commit contains fixes automatically applied by running dart fix --apply. The second commit contains some manual fixes on top of that.

christopherfujino · 2023-01-23T19:24:02Z

oops, forgot to finish reviewing, looking now

christopherfujino · 2023-01-23T19:50:02Z

packages/flutter_tools/lib/src/commands/attach.dart

    if ((debugPort == null && debugUri == null) || isNetworkDevice) {
      if (device is FuchsiaDevice) {
-        final String module = stringArgDeprecated('module')!;
+        final String? module = stringArgDeprecated('module');


christopherfujino · 2023-01-23T19:54:32Z

packages/flutter_tools/lib/src/commands/custom_devices.dart

        }

-        await portForwarder.unforward(forwardedPort);
+        await portForwarder.unforward(forwardedPort!);


Can you move this to an else block, lest we hit a _CastError with the bang operator?

christopherfujino · 2023-01-23T19:58:24Z

packages/flutter_tools/lib/src/commands/update_packages.dart

      while (path != null) {
        buf.write(path.to);
-        path = path.from!;
+        path = path.from;


LOL, I'm guessing if you tried to run this before this change you'd get a _CastError, good catch!

(this is a maintainer tool for diagnosing version solving problems, so not often run)

Hehe. I was very curious about how this piece of code was running before...

christopherfujino

LGTM! Thanks for this huge cleanup, including some bug fixes!

auto-submit · 2023-01-23T20:59:26Z

auto label is removed for flutter/flutter, pr: 118857, due to - The status or check suite Linux framework_tests_slow has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

…tter#118857)

* 3bf7960 [web] Fix paths fetched by flutter.js (flutter/flutter#118684) * e71e8da 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009) * 71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962) * 90ffb1c 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010) * 224e6aa Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926) * 6cd4945 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862) * a63e19b Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863) * 19dfde6 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910) * 392dffe Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930) * 5e50ed9 Test Utf8FromUtf16 (flutter/flutter#118647) * edb571e Update README.md (flutter/flutter#118803) * 38630b6 Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857) * 332aed9 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023) * 84071aa Add todo for linux defines test. (flutter/flutter#119035) * e8b7f4b [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000) * df44208 Remove ThemeData.buttonColor references (flutter/flutter#118658) * 6548616 Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916) * 59767e5 Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022) * 1906ce5 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021) * 720bea0 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028) * 0de8bef Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020) * 2e8dd9d Run integration_ui_test_test_macos in prod (flutter/flutter#118919) * 64b4c69 roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018) * c35efda Remove superfluous words. (flutter/flutter#119008)

flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 20, 2023

goderbauer force-pushed the nullCheckTool branch from 2e08f3a to 05d22b1 Compare January 20, 2023 00:46

goderbauer requested a review from christopherfujino January 20, 2023 00:46

goderbauer added 2 commits January 23, 2023 11:22

dart fix --apply

528359d

manual fixes

1df8ada

goderbauer force-pushed the nullCheckTool branch from 05d22b1 to 1df8ada Compare January 23, 2023 19:23

fix after merge conflicts

2aec173

christopherfujino reviewed Jan 23, 2023

View reviewed changes

goderbauer requested a review from christopherfujino January 23, 2023 20:51

christopherfujino approved these changes Jan 23, 2023

View reviewed changes

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2023

review

5bd7c77

goderbauer force-pushed the nullCheckTool branch from bdc8776 to 5bd7c77 Compare January 23, 2023 21:01

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2023

auto-submit bot merged commit 38630b6 into flutter:master Jan 23, 2023

This was referenced Jan 24, 2023

Roll Flutter from bd7bee0f9eb8 to c35efdaa6854 (24 revisions) flutter/packages#3085

Merged

Roll Flutter from bd7bee0f9eb8 to c35efdaa6854 (24 revisions) flutter/plugins#7017

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2023

38630b6 Remove unnecessary null checks in flutter_tool (flutter/flu…

301265d

…tter#118857)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 24, 2023

38630b6 Remove unnecessary null checks in flutter_tool (flutter/flu…

9117c38

…tter#118857)

gabrielgarciagava mentioned this pull request Jan 26, 2023

flutter pub get crashes if there is a plugin using legacy yaml format without defining androidPackage #119127

Closed

goderbauer deleted the nullCheckTool branch March 3, 2023 18:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove unnecessary null checks in `flutter_tool` #118857

Remove unnecessary null checks in `flutter_tool` #118857

Uh oh!

goderbauer commented Jan 20, 2023

Uh oh!

christopherfujino commented Jan 23, 2023

Uh oh!

christopherfujino Jan 23, 2023

Uh oh!

christopherfujino Jan 23, 2023

Uh oh!

goderbauer Jan 23, 2023

Uh oh!

christopherfujino Jan 23, 2023

Uh oh!

christopherfujino Jan 23, 2023

Uh oh!

goderbauer Jan 23, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

auto-submit bot commented Jan 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Remove unnecessary null checks in flutter_tool #118857

Remove unnecessary null checks in flutter_tool #118857

Uh oh!

Conversation

goderbauer commented Jan 20, 2023

Uh oh!

christopherfujino commented Jan 23, 2023

Uh oh!

christopherfujino Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

goderbauer Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

goderbauer Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Remove unnecessary null checks in `flutter_tool` #118857

Remove unnecessary null checks in `flutter_tool` #118857