Update the counter app to enable Material 3 #118835

gspencergoog · 2023-01-19T22:00:31Z

Description

This updates the counter app to enable Material 3 for the theming, and modifies it to include a little more color.

Related Issues

Fixes Migrate flutter counter template to Material 3 #111118

Tests

Update template generation tests.

gspencergoog · 2023-01-19T23:10:25Z

I'm including DevRel and Product representatives for review so that they can approve the look and feel, and the updated code comments I've added. This is not the final refresh, but it's still a big part of the first hour experience.

flutter-dashboard · 2023-01-20T00:10:40Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

packages/flutter_tools/templates/app/lib/main.dart.tmpl

Hixie · 2023-01-20T00:29:15Z

cc @InMatrix also

I think we need to be extremely careful about making changes here. The original template was very carefully crafted with UX research help. If we want to make additional changes, we should probably test them with UI studies.

Hixie · 2023-01-20T00:29:56Z

(some of the small fixes, especially those at the top of this PR, are probably safe, but as I was reading through the changes got more and more invasive and made me more and more nervous.)

packages/flutter_tools/templates/app/lib/main.dart.tmpl

gspencergoog · 2023-01-20T00:33:07Z

UXR studies are already planned, I've coordinated with Tao. The conclusions won't be ready until after the next stable cut, but we still want to turn on Material 3 by default before then. Simply turning on Material 3 by default, however, leaves a counter app that is an entirely white background (the app bar is also white), and seems far too plain.

Hixie · 2023-01-20T06:30:35Z

Let's separate the documentation improvements from the minimum required to bring this to material3, I think that would make the dicsussion easier.

gspencergoog · 2023-01-20T17:52:30Z

Ok, I've reverted all changes except for the required ones for turning on useMaterial3.

It looks like this now:

Hixie · 2023-01-20T22:59:55Z

packages/flutter_tools/templates/app/lib/main.dart.tmpl

should this just be the default? it seems weird that we're so unhappy with our defaults that we're overriding them in what should be the app with the biggest motivation to use all the defaults. cc @HansMuller

The default AppBar background color for Material 3 matches the body's background color (white). That's why the new version of the counter app painted a colorful star, so that changes to the theme's color scheme had a more dramatic impact. If the star has to be removed, then we wanted something that would highlight color scheme changes, and since there's already an app bar... Personally, I think the star added a little visual interest, along with highlighting color scheme changes.

packages/flutter_tools/templates/app/lib/main.dart.tmpl

Hixie · 2023-01-20T23:00:59Z

packages/flutter_tools/templates/app/lib/main.dart.tmpl

why do we believe it's time to change the template but not time to change the default for useMaterial3?

We're planning to migrate to useMaterial3:true by default in stages. In addition to publishing a migration guide and making sure that developers know what's coming, in this stage we'll make the counter app use material 3. In the following stage we'll make it true by default.

anderdobo

LGTM

…118835)

* 254a796 Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (flutter/flutter#119729) * 1573c12 Marks Mac_android microbenchmarks to be unflaky (flutter/flutter#119727) * 5613ab0 remove unnecessary parens (flutter/flutter#119736) * 1305a50 Roll Flutter Engine from c08a286d60e9 to ba3adb74d952 (5 revisions) (flutter/flutter#119741) * 484d881 [conductor] update console link (flutter/flutter#118338) * 73124dc Fix `ListTileThemeData.copyWith` doesn't override correct properties (flutter/flutter#119738) * bc8927c 2b8dd4e5c Use Windows high contrast black/white theme with `MaterialApp` themes (flutter/engine#39206) (flutter/flutter#119747) * 578edfc Catch errors thrown while handling pointer events (flutter/flutter#119577) * 8fd5d4e Remove deprecated SystemNavigator.routeUpdated method (flutter/flutter#119187) * 7a926dc Deprecate MediaQuery[Data].fromWindow (flutter/flutter#119647) * cd118da Update a test expectation that depended on an SkParagraph fix (flutter/flutter#119756) * 4ae2d3b 🔥 Do not format the messages file for `gen-l10n` (flutter/flutter#119596) * 8f5949e Roll Flutter Engine from 2b8dd4e5c699 to a12d102773dd (2 revisions) (flutter/flutter#119758) * 4c99da6 Avoid printing blank lines between "Another exception was thrown:" messages. (flutter/flutter#119587) * 2ecf4ae Update the counter app to enable Material 3 (flutter/flutter#118835) * 0b8486d 29d09845f Roll Dart SDK from b47964e5d575 to 1c219a91e637 (1 revision) (flutter/engine#39324) (flutter/flutter#119763) * ca7b7e3 Roll Flutter Engine from 29d09845f21e to 97d27ff59459 (2 revisions) (flutter/flutter#119765) * 475fc4a Run Mac hostonly tests on any available arch (flutter/flutter#119762) * 322d10e 18118e10a Add iOS spring animation objc files (flutter/engine#38801) (flutter/flutter#119768) * f767f86 check if directory exists before listing content (flutter/flutter#119748) * 34730c7 Revert "Run Mac hostonly tests on any available arch (#119762)" (flutter/flutter#119784) * f9daa9a Roll Flutter Engine from 18118e10a0a5 to 679c4b42e222 (4 revisions) (flutter/flutter#119783) * fd76ef0 Reland "Add API for discovering assets" (flutter/flutter#119277) * ca0596e Fix `pub get --unknown-flag` (flutter/flutter#119622) * 9abb6d7 Roll Plugins from 9da327c to 9302d87 (11 revisions) (flutter/flutter#119825) * 9eafbcc Roll Flutter Engine from 679c4b42e222 to 388890a98e5b (6 revisions) (flutter/flutter#119830) * 1ee8799 Revert "[Re-land] Exposed tooltip longPress (#118796)" (flutter/flutter#119832) * 07b51a0 Add missing variants and *new* indicators to `useMaterial3` docs (flutter/flutter#119799) * 201380a e9e601c7c [web] Hide autofill overlay (flutter/engine#39294) (flutter/flutter#119833) * 1c0065c 27f55219d Roll Fuchsia Linux SDK from QxkjqmRgowkk_n2NZ... to pWloCaRzjLEAUvQEz... (flutter/engine#39339) (flutter/flutter#119838) * e7d934a Marks Linux_android android_choreographer_do_frame_test to be flaky (flutter/flutter#119721) * 3f986e4 Roll Flutter Engine from 27f55219df79 to ae38c9585a61 (2 revisions) (flutter/flutter#119840) * b0f1714 Make Flex,Row,Column const for real (flutter/flutter#119673) * d4b6898 [web] Put all index.html operations in one place (flutter/flutter#118188) * d63987f Parser machine logs (flutter/flutter#118707) * 22bbdf0 Android defines target update (flutter/flutter#119766) * 8387c23 [flutter_tools] Use base DAP detach and ensure correct output (flutter/flutter#119076) * d820aec Manual pub roll with dwds fix (flutter/flutter#119575) * 72f9cf5 Roll Flutter Engine from ae38c9585a61 to 616ecd8be3de (3 revisions) (flutter/flutter#119859) * cfdc358 roll packages (flutter/flutter#119865) * d875899 Bump test Chrome version for Mac arm support (flutter/flutter#119773) * 9b86a48 Fix gets removedItem instead of its index (flutter/flutter#119638) * 66b2ca6 Roll Flutter Engine from 616ecd8be3de to 2871970337df (3 revisions) (flutter/flutter#119870) * c626460 Make `_focusDebug` not interpolate in debug mode (flutter/flutter#119680) * a27802e flutter_tool: remove explicit length header in HTTP response (flutter/flutter#119869) * 3570cce Remove deprecated kind in GestureRecognizer et al (flutter/flutter#119572) * bc45b18 2696fff87 Roll Skia from c2d81db3ef41 to 4f0166baf5a4 (13 revisions) (flutter/engine#39348) (flutter/flutter#119879) * f3effce Roll Flutter Engine from 2696fff8716d to e3fe6dade964 (3 revisions) (flutter/flutter#119892) * 69421c1 [framework] use shader tiling instead of repeated calls to drawImage (flutter/flutter#119495) * 6b83eff Roll Flutter Engine from e3fe6dade964 to 655530e3fd15 (5 revisions) (flutter/flutter#119905) * a5d8a4a 67d35267c [Impeller] Use minimal coverage for stencil restores after overdraw prevention (flutter/engine#39358) (flutter/flutter#119910) * fc8ea56 0fb48ce5b Roll Dart SDK from 69452c5012d9 to be795cc64bd7 (1 revision) (flutter/engine#39360) (flutter/flutter#119926) * e0b2138 Dispose OverlayEntry in TooltipState. (flutter/flutter#117291) * c5e8757 Add M3 support for iconbuttons in error state in TextFields (flutter/flutter#119925)

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 19, 2023

gspencergoog force-pushed the m3_counter branch from 0f209df to fe16d6e Compare January 19, 2023 22:45

gspencergoog requested review from anderdobo, craiglabenz and darrenaustin January 19, 2023 23:07

gspencergoog marked this pull request as ready for review January 19, 2023 23:10