CupertinoDatePicker with month and year (#93508) #118492
Conversation
Continuing with the pattern between the modes `date` and `time` having two different states. Made a `monthYear` state that renders and stores values for month and year Is compatible with the localization of the `date` mode.
flutter-dashboard
bot
added
f: cupertino
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I am stuck on making the tests. I am not understanding the |
|
Hi @hunterwilhelm. Thanks for the contribution! This looks like a really great addition. I saw you are asking in the discord about setting up a golden test, and that is the place to ask about it. In the mean time, it'd be best to also add some testing that don't use golden files that can be ran locally easier. Also, it looks like you have some linting errors still. |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Hi @hunterwilhelm. Hope all is well. Are you still working on this? |
|
Hi @hunterwilhelm. I hope all is going well. As this has not been updated in some time I am going to close this PR to clear up our queue. Please feel free to reopen if you ever are able to work on this change again. :) |
|
For anyone wondering, this feature was added by the flutter team in 3.13! https://medium.com/flutter/whats-new-in-flutter-3-13-479d9b11df4d |
2 participants
Continuing with the pattern between the modes
dateandtimehaving two different states.Made a
monthYearstate that renders and stores values for month and year Is compatible with the localization of thedatemode.Changed asserts to match the same expectations.
Fixes issue/feature requests: [#93508]
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.