Skip to content

Added _ErrorDescription.toString() #118263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 1, 2023
Merged

Added _ErrorDescription.toString() #118263

auto-submit merged 2 commits into from
Mar 1, 2023

Conversation

@Danau5tin
Copy link
Contributor

@Danau5tin Danau5tin commented Jan 10, 2023 •
edited
Loading

fixes: #106504

Minor change where I implemented the override of toString() in order to print a useful message in release mode as well as debug mode for an ErrorDescription. See issue for more info.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 10, 2023
@Danau5tin Danau5tin changed the title Added .toString() to ErrorDescription Added .toString() for ErrorDescription Jan 10, 2023
@Danau5tin Danau5tin closed this Jan 10, 2023
@Danau5tin Danau5tin deleted the danau5tin_errordiagnostic branch January 10, 2023 18:26
@Danau5tin Danau5tin restored the danau5tin_errordiagnostic branch January 10, 2023 18:28
@Danau5tin Danau5tin reopened this Jan 10, 2023
@Danau5tin Danau5tin mentioned this pull request Jan 10, 2023
Closed
@goderbauer
Copy link
Member

goderbauer commented Feb 1, 2023

(triage) @gspencergoog Do you still have this one on your radar for review? Thanks.

@gspencergoog
Copy link
Contributor

gspencergoog commented Feb 1, 2023

I do! Thanks for the reminder.

gspencergoog
gspencergoog approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog gspencergoog changed the title Added .toString() for ErrorDescription Added .toString() for _ErrorDescription Feb 1, 2023
@gspencergoog gspencergoog changed the title Added .toString() for _ErrorDescription Added _ErrorDescription.toString() Feb 1, 2023
@goderbauer
Copy link
Member

goderbauer commented Feb 7, 2023

(triage) @Danau5tin Looks like one of the checks got stuck and unfortunately I cannot restart it. Could you rebase this PR with master to trigger the check again?

goderbauer
goderbauer approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 28, 2023

auto label is removed for flutter/flutter, pr: 118263, due to - The status or check suite Linux web_long_running_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2023
@auto-submit auto-submit bot merged commit b10f25c into flutter:master Mar 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
f71797a 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
63bf4a9 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
99ac8b3 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
0a1d5d1 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
d448cb6 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
28b1952 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
b10e4e3 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
9b0ed4f 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
117edf3 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
b0a974c 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
6b28a71 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
6412abe 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
1a46348 
…sage in release mode as well as debug mode (flutter/flutter#118263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
357d0e6 
…sage in release mode as well as debug mode (flutter/flutter#118263)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
f456926 
…sage in release mode as well as debug mode (flutter/flutter#118263)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
86bc45f 
…sage in release mode as well as debug mode (flutter/flutter#118263)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
910eeea 
…sage in release mode as well as debug mode (flutter/flutter#118263)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
b10f25c implement override of toString() in order to print useful mes…
3bc186b 
…sage in release mode as well as debug mode (flutter/flutter#118263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_ErrorDiagnostic.toString() prints "Instance of"

4 participants

@Danau5tin @goderbauer @gspencergoog @Piinks