-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix Finnish TimeOfDate format #118204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thkim1011
merged 2 commits into
flutter:master
from
thkim1011:tae/fix-finnish-time-format
Jan 11, 2023
Merged
Fix Finnish TimeOfDate format #118204
thkim1011
merged 2 commits into
flutter:master
from
thkim1011:tae/fix-finnish-time-format
Jan 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
approved these changes
Jan 10, 2023
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 11, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 11, 2023
* 669a3d2 Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (flutter/flutter#118253) * cb62cfd Manually mark Windows run_debug_test_windows as unflaky (flutter/flutter#118112) * 0cd8d84 Marks Mac_arm64_android run_debug_test_android to be unflaky (flutter/flutter#117469) * 3cee38e Marks Mac_arm64_ios run_debug_test_macos to be unflaky (flutter/flutter#117990) * 1d2e62b remove unsound mode web test (flutter/flutter#118256) * 3d3f8e8 Update `CupertinoPicker` example (flutter/flutter#118248) * 594333b roll packages (flutter/flutter#118117) * a6f17e6 Add option for opting out of enter route snapshotting. (flutter/flutter#118086) * 01583b7 roll packages (flutter/flutter#118272) * cf529ec Roll Flutter Engine from 687e3cb0fbe2 to c1d61cf11da8 (6 revisions) (flutter/flutter#118274) * b7881e5 Align `flutter pub get/upgrade/add/remove/downgrade` (flutter/flutter#117896) * 12b43ed ae9e181e3 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (flutter/flutter#118287) * b13f83a Fix Finnish TimeOfDate format (flutter/flutter#118204) * 55e3894 Roll Flutter Engine from ae9e181e30c2 to 53bd4bbf9646 (3 revisions) (flutter/flutter#118289) * a40fb9b 9ade91c8b removed forbidden skia include (flutter/engine#38761) (flutter/flutter#118296) * 32b1ea3 8d7beac82 Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (flutter/flutter#118297) * 957781a 6256f05db Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (flutter/flutter#118300) * f10965f FIX: UnderlineInputBorder hashCode and equality by including borderRadius (flutter/flutter#118284)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 12, 2023
auto-submit bot
pushed a commit
to flutter/plugins
that referenced
this pull request
Jan 12, 2023
* 5335a96 0a0e3d2 Roll Flutter from 43b9120 to 5070620 (9 revisions) (#6919) (flutter/flutter#118183) * 6c225dd Roll Flutter Engine from 33d7f8a1b307 to 03609b420beb (6 revisions) (flutter/flutter#118125) * 478d1da remove the unused check in selectable_text (flutter/flutter#117716) * c87cfd7 Roll Flutter Engine from 03609b420beb to b5513d7a442a (2 revisions) (flutter/flutter#118186) * 234452f Roll Flutter Engine from b5513d7a442a to 5bdb04f33f99 (2 revisions) (flutter/flutter#118187) * 78416d8 51baed6e0 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (flutter/flutter#118189) * a02b9d2 Update to Xcode 14.2 (flutter/flutter#117507) * eaaacdc Allow iOS and macOS plugins to share darwin directory (flutter/flutter#115337) * 5bf6357 Roll Flutter Engine from 51baed6e01b8 to 5df0072a0e63 (3 revisions) (flutter/flutter#118192) * 46e48ba Use program during attach if provided (flutter/flutter#118130) * 31da712 eb5c6f0b4 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (flutter/flutter#118197) * fa1a4ee Update `ListTile` to support Material 3 (flutter/flutter#117965) * 02a8bbf 3a7d8862f Re-enable UIA text/range provider unit tests (flutter/engine#38718) (flutter/flutter#118201) * e9bbb11 Fix path for require.js (flutter/flutter#118120) * 851611b ee0c4d26b Roll flutter/packages to 25454e (flutter/engine#38685) (flutter/flutter#118205) * 00a9db8 Roll Flutter Engine from ee0c4d26b0fa to 264aa032cf75 (2 revisions) (flutter/flutter#118208) * d6cd9c0 9c0b187a1 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (flutter/flutter#118210) * 4205357 add closed/open focus traversal; use open on web (flutter/flutter#115961) * 466cb54 Roll Flutter Engine from 9c0b187a1139 to 716bb9172c0d (3 revisions) (flutter/flutter#118220) * ad7322d Hide InkWell hover highlight when an hovered InkWell is disabled (flutter/flutter#118026) * 583a812 Allow select cases to be numbers (flutter/flutter#116625) * 700fe3d [Impeller Scene] Add SceneC asset importing (flutter/flutter#118157) * 07bc245 Add a comment about repeat event + fix typos (flutter/flutter#118095) * 5d96d61 Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (flutter/flutter#116894) * f2c088b Roll Flutter Engine from 716bb9172c0d to 687e3cb0fbe2 (2 revisions) (flutter/flutter#118242) * 669a3d2 Roll Plugins from 0a0e3d2 to 9fdc899 (8 revisions) (flutter/flutter#118253) * cb62cfd Manually mark Windows run_debug_test_windows as unflaky (flutter/flutter#118112) * 0cd8d84 Marks Mac_arm64_android run_debug_test_android to be unflaky (flutter/flutter#117469) * 3cee38e Marks Mac_arm64_ios run_debug_test_macos to be unflaky (flutter/flutter#117990) * 1d2e62b remove unsound mode web test (flutter/flutter#118256) * 3d3f8e8 Update `CupertinoPicker` example (flutter/flutter#118248) * 594333b roll packages (flutter/flutter#118117) * a6f17e6 Add option for opting out of enter route snapshotting. (flutter/flutter#118086) * 01583b7 roll packages (flutter/flutter#118272) * cf529ec Roll Flutter Engine from 687e3cb0fbe2 to c1d61cf11da8 (6 revisions) (flutter/flutter#118274) * b7881e5 Align `flutter pub get/upgrade/add/remove/downgrade` (flutter/flutter#117896) * 12b43ed ae9e181e3 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (flutter/flutter#118287) * b13f83a Fix Finnish TimeOfDate format (flutter/flutter#118204) * 55e3894 Roll Flutter Engine from ae9e181e30c2 to 53bd4bbf9646 (3 revisions) (flutter/flutter#118289) * a40fb9b 9ade91c8b removed forbidden skia include (flutter/engine#38761) (flutter/flutter#118296) * 32b1ea3 8d7beac82 Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (flutter/flutter#118297) * 957781a 6256f05db Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (flutter/flutter#118300) * f10965f FIX: UnderlineInputBorder hashCode and equality by including borderRadius (flutter/flutter#118284) * 33c71be Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter/flutter#118116) * 2e0849e Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/flutter#118052) * aabf146 Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter/flutter#117104) * a50e2c8 6048f9110 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (flutter/flutter#118320) * e697805 Roll Plugins from 9fdc899 to 620a059 (4 revisions) (flutter/flutter#118317) * b4a07de ee76ab71e Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (flutter/flutter#118335) * c6be43a Roll Flutter Engine from ee76ab71e0a6 to cccaae2f3d8b (3 revisions) (flutter/flutter#118349) * 4b2d3eb 764a9e012 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (flutter/flutter#118355) * b2b4050 Roll Flutter Engine from 764a9e01204d to 4a8d6866a1c0 (2 revisions) (flutter/flutter#118357) * 727e860 Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (flutter/flutter#111570) * 13ebde6 Marks Mac channels_integration_test to be unflaky (flutter/flutter#111571) * f8628b5 Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (flutter/flutter#116668) * 44f5403 Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (flutter/flutter#118322) * 51c2af5 docs: update docs about color property in material card (flutter/flutter#117263) * 0d91c03 Fix M3 `Drawer` default shape in RTL (flutter/flutter#118185)
esouthren
pushed a commit
to esouthren/flutter
that referenced
this pull request
Jan 15, 2023
* init * add test
esouthren
pushed a commit
that referenced
this pull request
Jan 16, 2023
From an issue filed internally. TimeOfDateFormat for locale
fishould beHH.mmnotHH:mmas per this link. For TimeOfDateFormat only, I think it should be ok to directly modify thematerial_*.arbfiles as the source of truth isn't from Translation Console.