Skip to content

Post a ToolEvent when selecting widget for inspection #118098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CoderDake merged 29 commits into from
Jan 17, 2023
Merged

Post a ToolEvent when selecting widget for inspection #118098

CoderDake merged 29 commits into from
Jan 17, 2023

Conversation

@CoderDake
Copy link
Contributor

@CoderDake CoderDake commented Jan 6, 2023 •
edited
Loading

This PR changes our inspection behaviour so that it also sends a postEvent on the toolEvent stream.

IDEs will be able to listen to this so they can navigate when they receive it.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 6, 2023
jacob314
jacob314 reviewed Jan 6, 2023
View reviewed changes
jacob314
jacob314 reviewed Jan 6, 2023
View reviewed changes
jacob314
jacob314 reviewed Jan 6, 2023
View reviewed changes
jacob314
jacob314 reviewed Jan 6, 2023
View reviewed changes
jacob314
jacob314 reviewed Jan 6, 2023
View reviewed changes
jacob314
jacob314 reviewed Jan 6, 2023
View reviewed changes
jacob314
jacob314 reviewed Jan 6, 2023
View reviewed changes
jacob314
jacob314 reviewed Jan 6, 2023
View reviewed changes
jacob314
jacob314 reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Only non-style advice is to avoid creating any magic group names in widget_inspector.dart
If it is completely unavoidable, you must call dispose on the magic group names after each operation to avoid leaking memory.

DanTup
DanTup reviewed Jan 9, 2023
View reviewed changes
DanTup
DanTup reviewed Jan 9, 2023
View reviewed changes
@DanTup
Copy link
Contributor

DanTup commented Jan 9, 2023

Had a quick test with this and it's working well :)

Jan-09-2023 12-11-24

I made a few comments above and will wait to land the Dart-Code changes based on responses, but I'll prepare a CL for the DAP changes (which are very simple, since it just forwards the event on).

@DanTup DanTup mentioned this pull request Jan 9, 2023
Merged
bkonyi
bkonyi reviewed Jan 9, 2023
View reviewed changes
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
71d9fe6 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
289609f 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
3abaad1 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
e50ae4e 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
358f3f6 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
2a4ca8f 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
accd659 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
e350908 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
a173256 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
606b421 
…r/flutter#118098)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
963f08e 
…r/flutter#118098)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@CoderDake @gspencergoog
Post a ToolEvent when selecting widget for inspection (flutter#118098)
a6cb29f 
Changes our inspection behaviour so that it also sends a postEvent on the ToolEvent stream.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2023
@engine-flutter-autoroll
cc7845e Post a ToolEvent when selecting widget for inspection (flutte…
c82c747 
…r/flutter#118098)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 20, 2023
@engine-flutter-autoroll
Roll Flutter from 68dd63d to 73096fd (57 revisions) (#3073)
d69a96d 
* da5f8cf Roll Flutter Engine from a512cebdcd30 to 7dc5e7efa66a (2 revisions) (flutter/flutter#118505)

* baefecc 35479aa1c Roll Fuchsia Mac SDK from 21nYb648VWbpxc36t... to w0hr1ZMvYGJnWInwK... (flutter/engine#38880) (flutter/flutter#118509)

* ca300ce 25cb82272 Add include to make g3 happy (flutter/engine#38850) (flutter/flutter#118510)

* 1220245 f79030440 Roll Skia from c72c7bf7e45b to c64a10d525d1 (7 revisions) (flutter/engine#38858) (flutter/flutter#118511)

* 7188c3e Update documentation about accent color (flutter/flutter#116778)

* 8c2fdb8 M3 Button padding adjustments (flutter/flutter#118449)

* f22280a Revert "M3 Button padding adjustments (#118449)" (flutter/flutter#118598)

* cc7845e Post a ToolEvent when selecting widget for inspection (flutter/flutter#118098)

* a3629a2 Roll Plugins from 92a5367d58df to 4e5cf2d2da27 (8 revisions) (flutter/flutter#118624)

* ae7b99e Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070)

* 6fafbc3 Updated tokens to v0.152 (flutter/flutter#118594)

* 4b3cf9b Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607)

* 0449030 Disable Xcode cache cleanup (flutter/flutter#118641)

* f989d55 Devicelab android emulator (flutter/flutter#113472)

* 0eaa83a Fix some Focus related documentation typos (flutter/flutter#118576)

* 780563c Add const constructor to TextInputFormatter (flutter/flutter#116654)

* 973cff4 [Re-land] Button padding m3 (flutter/flutter#118640)

* 3348987 Add new macos target configured for flavors (flutter/flutter#117352)

* 6277520 Roll Plugins from 4e5cf2d2da27 to 11361d01099d (4 revisions) (flutter/flutter#118682)

* 997d436 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185)

* 8a58ec5 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720)

* 374f09e [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491)

* ae1cc18 remove single-view assumption from `paintImage` (flutter/flutter#118721)

* bb8b96a Fix path for require.js (flutter/flutter#118722)

* c83a698 update uikit view documentation (flutter/flutter#118715)

* 2b3ca0d Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735)

* 666dccc [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717)

* d07b88e Docs fix an=>a (flutter/flutter#118652)

* 11d21e0 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738)

* 7d9eaab Appbar iconTheme override fix (flutter/flutter#118681)

* 6f70830 Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743)

* b3059d2 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745)

* ffcf63a Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755)

* 2609212 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751)

* 21fb443 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758)

* e5c9d06 Forgot to remove emulator flag. (flutter/flutter#118762)

* 6a9b2db 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763)

* 0bbb5ec 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771)

* d53cc4a [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754)

* 3e71e0c Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705)

* 213b3cb Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556)

* 06909cc Update packages + fix tests for javascript mime change (flutter/flutter#118617)

* 46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793)

* b9ab640 Remove incorrect statement in documentation (flutter/flutter#118636)

* ea36b3a Add focus detector to CupertinoSwitch (flutter/flutter#118345)

* 9b5ea30 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807)

* 67ffaef 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817)

* 5cd2d4c Support iOS wireless debugging (flutter/flutter#118104)

* cbf2e16 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826)

* 2258590 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828)

* 1dd7f45 Add `build macos --config-only` option. (flutter/flutter#118649)

* 22520f5 [macOS] Add timeline summary benchmarks (flutter/flutter#118748)

* 99e4ca5 Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829)

* c5ceff1 [flutter_tools] Ensure service worker starts caching assets since first load  (flutter/flutter#116833)

* 818bb4e Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839)

* 09bd0f6 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674)

* 73096fd [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 8c2fdb8 to cc7845e (2 revisions) (flutter#6983)
37c5934 
* f22280a Revert "M3 Button padding adjustments (#118449)" (flutter/flutter#118598)

* cc7845e Post a ToolEvent when selecting widget for inspection (flutter/flutter#118098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi left review comments

@DanTup DanTup DanTup approved these changes

@jacob314 jacob314 jacob314 approved these changes

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CoderDake @DanTup @jacob314 @bkonyi @kenzieschmoll