-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add support for Gradle Kotlin DSL #118067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Gradle Kotlin DSL #118067
Conversation
Attempt to reland #100442
|
@GaryQian could you review this one? I believe you landed a change related to Kotlin DSL? |
|
I will try to give this a look next week. You are correct there is some additional work that needs to happen for use to bring this feature out at a production ready level and I am not sure when my team will be able to do the rest of the work. Also our testing in this area is not such that I can rely on automated tests alone to trust that this will work. All that said I agree that many would rather work in kotlin gradle rather than learn groovy and I dont want to discourage this sort of contribution. In the mean time can you look at https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/features.dart |
|
The feature flag sounds reasonable, though I think that if somebody has |
|
Yes that is one way of looking at it. Another, and the one I am using, is an android dev happens to use build.gradle.kts either because of a suggestion they find on the broader internet or because of previous android experience. An explicit opt in with the understanding that kotlin gradle support is experimental/under-development/baking or whatever phrase we decide to use helps align expectations better. |
|
I am open to coming back to this discussion but for now I think i need to reject this cl. My team does not have the capacity to support adding a new build system. We know that build systems are not where app engineers want to spend their time and do not have the testing setup to ensure that this will keep working. Additionally at the current time there is partial support for other IDE's. https://docs.gradle.org/current/userguide/kotlin_dsl.html#sec:ide_support Thank you for the contribution. |
|
@reidbaker Sorry for not responding for a prolonged time. I agree with your comment and am willing to add a feature flag for this. |
Fixes #93238.
Gradle Kotlin DSL, at least for me, makes the experience of editing build scripts 10x better. Flutter developers should be able to harness this power :)
With this PR I'm aiming to make it possible to use
build.gradle.ktsinstead ofbuild.gradle, but there's more work to be done:build.gradle/build.gradle.ktsinstead of onlybuild.gradlebuild.gradle/build.gradle.ktsinstead of onlybuild.gradlePre-launch Checklist
///).