Skip to content

Fix documentation error in README of integration_test #117977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Feb 28, 2023
Merged

Fix documentation error in README of integration_test #117977

auto-submit merged 4 commits into from
Feb 28, 2023

Conversation

@bartekpacia
Copy link
Member

@bartekpacia bartekpacia commented Jan 4, 2023 •
edited
Loading

Synopsis

I think I found a tiny error in integration_test docs.

The related subsection of the README:

The xcodebuild invocation is wrong. It says:

xcodebuild -workspace Runner.xcworkspace -scheme Runner -config Flutter/Release.xcconfig -derivedDataPath $output -sdk iphoneos build-for-testing

but I'm pretty sure it should say:

xcodebuild -workspace Runner.xcworkspace -scheme Runner -xcconfig Flutter/Release.xcconfig -derivedDataPath $output -sdk iphoneos build-for-testing

What's the difference?

When using xcodebuild -config Runner/Debug.xcconfig, the console output says:

Command line invocation:
    /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -workspace Runner.xcworkspace -scheme Runner -config Flutter/Debug.xcconfig -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 14"

User defaults from command line:
    IDEPackageSupportUseBuiltinSCM = YES

Build settings from command line:
    SDKROOT = iphonesimulator16.2

Prepare packages

<ommited for brevity>

Meanwhile with xcodebuild -xcconfig Runner/Debug.xcconfig:

Command line invocation:
    /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -workspace Runner.xcworkspace -scheme Runner -xcconfig Flutter/Debug.xcconfig -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 14"

User defaults from command line:
    IDEPackageSupportUseBuiltinSCM = YES

Build settings from command line:
    SDKROOT = iphonesimulator16.2

Build settings from configuration file 'Flutter/Debug.xcconfig':
    ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES
    CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES
    CLANG_CXX_LANGUAGE_STANDARD = c++14
    CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO
    COCOAPODS_PARALLEL_CODE_SIGN = true
    DART_OBFUSCATION = false
    DEBUG_INFORMATION_FORMAT = dwarf-with-dsym
    EXCLUDED_ARCHS =
    FLUTTER_APPLICATION_PATH = /Users/bartek/dev/bartekpacia/discover_rudy
    FLUTTER_BUILD_DIR = build
    FLUTTER_BUILD_NAME = 1.0.0
    FLUTTER_BUILD_NUMBER = 1
    FLUTTER_ROOT = /Users/bartek/fvm/versions/stable
    FLUTTER_TARGET = lib/main.dart
    <many more>

Prepare packages

<ommited for brevity>

List which issues are fixed by this PR. You must list at least one issue.

Well, I described above what the problem is. I think creating a separate issue is not necessary.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

See also:

@flutter-dashboard flutter-dashboard bot added the f: integration_test The flutter/packages/integration_test plugin label Jan 4, 2023
@bartekpacia bartekpacia mentioned this pull request Jan 4, 2023
Closed
@jmagman jmagman self-requested a review February 21, 2023 17:35
jmagman
jmagman approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the catch, and apologies this hung out so long without a review.

@jmagman
Copy link
Member

jmagman commented Feb 21, 2023

@pdblasi-google could you give this a second flutter-hackers review?

pdblasi-google
pdblasi-google approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@jmagman jmagman mentioned this pull request Feb 22, 2023
Merged
8 tasks
@jmagman jmagman added the framework flutter/packages/flutter repository. See also f: labels. label Feb 22, 2023
@auto-submit auto-submit bot merged commit f97a515 into flutter:master Feb 28, 2023
@bartekpacia bartekpacia deleted the fix/wrong_ios_test_build_instructions branch March 1, 2023 00:05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
7cbb141 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
737635c 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
ab4d633 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
ccdcc79 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
10453fa 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
0ad3cd4 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
7fd5289 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
90f1ca4 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
95ae239 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
3b136f2 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
8c366d9 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
3cd9e2a 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
6bb1876 
…ter/flutter#117977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
a9a8136 
…ter/flutter#117977)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
ec5a3d4 
…ter/flutter#117977)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
91a6d3d 
…ter/flutter#117977)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
1e79537 
…ter/flutter#117977)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
f97a515 Fix documentation error in README of integration_test (flut…
a27604d 
…ter/flutter#117977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@pdblasi-google pdblasi-google pdblasi-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bartekpacia @jmagman @pdblasi-google @goderbauer