Skip to content

Separate theme logic #117818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Feb 27, 2023
Merged

Separate theme logic #117818

auto-submit merged 3 commits into from
Feb 27, 2023

Conversation

@MahanRahmati
Copy link
Contributor

@MahanRahmati MahanRahmati commented Dec 30, 2022 •
edited
Loading

When I was working on Arna, I saw an opportunity to improve readability of MaterialApp. This PR separates the logic of themebuilder from materialBuilder.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Dec 30, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 30, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Dec 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bernaferrari
Copy link
Contributor

bernaferrari commented Dec 30, 2022

Why?

@cedvdb
Copy link
Contributor

cedvdb commented Dec 30, 2022 •
edited
Loading

Why?

imo it makes it more readable by separating the tree view from details, as someone who had never read it before seeing this PR I'd say say it's better than before.

@MahanRahmati
Copy link
Contributor Author

MahanRahmati commented Dec 31, 2022

I have no idea why Windows build_tests_3_3 failed 😞

@Hixie
Copy link
Contributor

Hixie commented Dec 31, 2022 •
edited
Loading

test-exempt: code refactor with no semantic change

(this should not influence the reviewers' decision about whether this is a good idea or not; in particular, this change might have an imperceptible performance cost since it adds another method call, so if the readability benefit is not substantial then maybe we should explore other ways to improve the readability)

HansMuller
HansMuller reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that it has taken so long to get this PR reviewed! This is a small change and I think the title may have scared off the original reviewer.

The changes you're proposing seem reasonable. If you'd be willing to sync your PR up, I think we could land this.

@HansMuller HansMuller removed the request for review from darrenaustin February 24, 2023 23:12
@MahanRahmati
Copy link
Contributor Author

MahanRahmati commented Feb 25, 2023

@HansMuller Thanks for the review! I will sync it later.

@MahanRahmati
Copy link
Contributor Author

MahanRahmati commented Feb 25, 2023

@HansMuller It's done! 🚀

@cedvdb
Copy link
Contributor

cedvdb commented Feb 25, 2023

the title may have scared off the original reviewer

🐔

HansMuller
HansMuller approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 27, 2023

auto label is removed for flutter/flutter, pr: 117818, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 27, 2023

auto label is removed for flutter/flutter, pr: 117818, due to Validations Fail.

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@auto-submit auto-submit bot merged commit 14a9c23 into flutter:master Feb 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
14a9c23 Separate theme logic (flutter/flutter#117818)
4160bb5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
14a9c23 Separate theme logic (flutter/flutter#117818)
269d4be
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
14a9c23 Separate theme logic (flutter/flutter#117818)
6e20d29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MahanRahmati @bernaferrari @cedvdb @Hixie @reidbaker @HansMuller