Skip to content

Conversation

@XilaiZhang
Copy link
Contributor

Reverts #117547.

revert along with #117557 to fix tooltip tests.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels Dec 22, 2022
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should this merge with the original revert as one commit. It will be easier to reland as well

@XilaiZhang
Copy link
Contributor Author

LGTM, should this merge with the original revert as one commit. It will be easier to reland as well

umm sorry if i am misunderstanding, like combining #117557 with this PR into one PR?, so that this combined PR would revert 2 PRs?

@chunhtai
Copy link
Contributor

yes

@XilaiZhang
Copy link
Contributor Author

Sure, thanks for explaining! updated #117557 to include both reverts

@guidezpl guidezpl deleted the revert-117547-issues/117479 branch April 18, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants