fixes android_semantics_integration_test to expect long press for too… #117547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: accessibility
jmagman
approved these changes
Dec 22, 2022
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
It's supposed to have both actions, is that right?
Actual change LGTM if you're confident that's right.
Contributor
Author
|
yes the goal for the pr that broke this test was to add a longpress semantics action to tooltip, so this is expected |
chunhtai
added
the
autosubmit
This was referenced Dec 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Dec 23, 2022
auto-submit bot
pushed a commit
to flutter/plugins
that referenced
this pull request
Dec 23, 2022
* 95ff839 Roll Plugins from 54fc206 to 2dd85ec (3 revisions) (flutter/flutter#117535) * b8d5d9c Revert "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117545) * bd482eb fixes android_semantics_integration_test to expect long press for tooltip (flutter/flutter#117547) * 725c141 Fix screenshot testing for flutter web integration_test (flutter/flutter#117114) * 999356b Remove single-view assumption from ScrollPhysics (flutter/flutter#117503) * 6eb002a Reland "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117549) * 08209b7 Explain how to test onSubmitted in its docs (flutter/flutter#117550) * 20bc2ba Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision) (flutter/flutter#117555) * abd5217 Bump ossf/scorecard-action from 2.1.1 to 2.1.2 (flutter/flutter#117554) * 6781576 Reland iOS 16 context menu (flutter/flutter#117234) * daa2ecf Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (flutter/flutter#117563) * 6441a7d Roll Flutter Engine from ca0c843bf75f to 12badb54598d (2 revisions) (flutter/flutter#117566) * a0cecbe 3b5fb86a5 delete unused lib/src/engine/canvaskit/viewport_metrics.dart (flutter/engine#38474) (flutter/flutter#117572) * fbfda23 Roll Flutter Engine from 3b5fb86a5982 to 6295d9198da1 (3 revisions) (flutter/flutter#117576) * 3eca29b f2a071692 Roll Skia from 3e39affa3e1d to 45466d04ca49 (1 revision) (flutter/engine#38480) (flutter/flutter#117579) * 05914e7 948d0bffa Roll Dart SDK from 47f192463696 to 442614a6c1bb (1 revision) (flutter/engine#38481) (flutter/flutter#117581) * a34dec2 00995b7b9 Roll Skia from 45466d04ca49 to e206aa0c44f0 (4 revisions) (flutter/engine#38482) (flutter/flutter#117585) * 4ef24cf 238f40bb9 Roll Fuchsia Mac SDK from W0GUdjHi4gI48optN... to 9w7QDlttR9f7Gu7U6... (flutter/engine#38483) (flutter/flutter#117587) * a45a2f3 ad042d863 Roll Skia from e206aa0c44f0 to a8b7ce3b6391 (1 revision) (flutter/engine#38484) (flutter/flutter#117589)
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 27, 2022
* 95ff839 Roll Plugins from 54fc2066d636 to 2dd85ec81d06 (3 revisions) (flutter/flutter#117535) * b8d5d9c Revert "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117545) * bd482eb fixes android_semantics_integration_test to expect long press for tooltip (flutter/flutter#117547) * 725c141 Fix screenshot testing for flutter web integration_test (flutter/flutter#117114) * 999356b Remove single-view assumption from ScrollPhysics (flutter/flutter#117503) * 6eb002a Reland "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117549) * 08209b7 Explain how to test onSubmitted in its docs (flutter/flutter#117550) * 20bc2ba Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision) (flutter/flutter#117555) * abd5217 Bump ossf/scorecard-action from 2.1.1 to 2.1.2 (flutter/flutter#117554) * 6781576 Reland iOS 16 context menu (flutter/flutter#117234) * daa2ecf Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (flutter/flutter#117563) * 6441a7d Roll Flutter Engine from ca0c843bf75f to 12badb54598d (2 revisions) (flutter/flutter#117566) * a0cecbe 3b5fb86a5 delete unused lib/src/engine/canvaskit/viewport_metrics.dart (flutter/engine#38474) (flutter/flutter#117572) * fbfda23 Roll Flutter Engine from 3b5fb86a5982 to 6295d9198da1 (3 revisions) (flutter/flutter#117576) * 3eca29b f2a071692 Roll Skia from 3e39affa3e1d to 45466d04ca49 (1 revision) (flutter/engine#38480) (flutter/flutter#117579) * 05914e7 948d0bffa Roll Dart SDK from 47f192463696 to 442614a6c1bb (1 revision) (flutter/engine#38481) (flutter/flutter#117581) * a34dec2 00995b7b9 Roll Skia from 45466d04ca49 to e206aa0c44f0 (4 revisions) (flutter/engine#38482) (flutter/flutter#117585) * 4ef24cf 238f40bb9 Roll Fuchsia Mac SDK from W0GUdjHi4gI48optN... to 9w7QDlttR9f7Gu7U6... (flutter/engine#38483) (flutter/flutter#117587) * a45a2f3 ad042d863 Roll Skia from e206aa0c44f0 to a8b7ce3b6391 (1 revision) (flutter/engine#38484) (flutter/flutter#117589)
loic-sharma
pushed a commit
to fluttergithubbot/flutter
that referenced
this pull request
Jan 6, 2023
loic-sharma
pushed a commit
to fluttergithubbot/flutter
that referenced
this pull request
Jan 6, 2023
…#117557) * Revert "Exposed tooltip longPress action when available (flutter#117338)" This reverts commit 38e3930. * Revert "fixes android_semantics_integration_test to expect long press for tootip"
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#117557) * Revert "Exposed tooltip longPress action when available (flutter#117338)" This reverts commit 38e3930. * Revert "fixes android_semantics_integration_test to expect long press for tootip"
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* 95ff839 Roll Plugins from 54fc206 to 2dd85ec (3 revisions) (flutter/flutter#117535) * b8d5d9c Revert "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117545) * bd482eb fixes android_semantics_integration_test to expect long press for tooltip (flutter/flutter#117547) * 725c141 Fix screenshot testing for flutter web integration_test (flutter/flutter#117114) * 999356b Remove single-view assumption from ScrollPhysics (flutter/flutter#117503) * 6eb002a Reland "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117549) * 08209b7 Explain how to test onSubmitted in its docs (flutter/flutter#117550) * 20bc2ba Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision) (flutter/flutter#117555) * abd5217 Bump ossf/scorecard-action from 2.1.1 to 2.1.2 (flutter/flutter#117554) * 6781576 Reland iOS 16 context menu (flutter/flutter#117234) * daa2ecf Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (flutter/flutter#117563) * 6441a7d Roll Flutter Engine from ca0c843bf75f to 12badb54598d (2 revisions) (flutter/flutter#117566) * a0cecbe 3b5fb86a5 delete unused lib/src/engine/canvaskit/viewport_metrics.dart (flutter/engine#38474) (flutter/flutter#117572) * fbfda23 Roll Flutter Engine from 3b5fb86a5982 to 6295d9198da1 (3 revisions) (flutter/flutter#117576) * 3eca29b f2a071692 Roll Skia from 3e39affa3e1d to 45466d04ca49 (1 revision) (flutter/engine#38480) (flutter/flutter#117579) * 05914e7 948d0bffa Roll Dart SDK from 47f192463696 to 442614a6c1bb (1 revision) (flutter/engine#38481) (flutter/flutter#117581) * a34dec2 00995b7b9 Roll Skia from 45466d04ca49 to e206aa0c44f0 (4 revisions) (flutter/engine#38482) (flutter/flutter#117585) * 4ef24cf 238f40bb9 Roll Fuchsia Mac SDK from W0GUdjHi4gI48optN... to 9w7QDlttR9f7Gu7U6... (flutter/engine#38483) (flutter/flutter#117587) * a45a2f3 ad042d863 Roll Skia from e206aa0c44f0 to a8b7ce3b6391 (1 revision) (flutter/engine#38484) (flutter/flutter#117589)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ltip
fixes #117479
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.