-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Marks Windows run_debug_test_windows to be unflaky #117471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Update navigation_drawer.dart * Update navigation_drawer_test.dart * Update navigation_drawer_test.dart * update tests * Update navigation_drawer_test.dart * Update navigation_drawer_test.dart
* Improve Swift plugin implementation * Add iOS tests * Review feedback on structure * Remove duplicate scheme file * Add macOS * Add iOS * swift test tweaks * unit tests * Whitespace * Add e2e tests
* cacheWidth cacheHeight support for web canvaskit * comments * clarifying comment for loadTestImageProvider class Co-authored-by: alanwutang11 <[email protected]>
…lutter#117489) * 23a56ee9d Roll Skia from 7ad6f27aff57 to 239a9199a3d9 (5 revisions) (flutter/engine#38450) * 84ba80331 [Impeller Scene] Make Geometry/Materials own command binding behavior (flutter/engine#38437)
* Prevent possibility of null exceptions on widget.bottomSheet * New approach that fixes bug in updating the bottomSheet * Real-world test for bottomSheet error * Allow bottomSheet to animate out after being killed, even if it was rebuilt * Go back to the simple solution of SizedBox.shrink
Fixes an error that can occur when selection contains a partial glyph.
…er#109573)" (flutter#117497) This reverts commit cd0f15a. Co-authored-by: Renzo Olivares <[email protected]>
…lutter#117499) * afa2975aa Roll Skia from 239a9199a3d9 to cd149aaa33bd (2 revisions) (flutter/engine#38451) * a90c45db3 Roll Dart SDK from 62ea309071c6 to fc0a3217b39a (2 revisions) (flutter/engine#38452)
* Add fix and test * Add test owner * Print error for testing * Make sure locale is the problem * Test capitalization fix * Take out Android specific test * Verify eng fix * Test fix * Empty-Commit * Test all tests * Up string size for testing * Remove test * Undo ci.yaml testing changes * Test android variant: * Change to testwidgets * Add widget tester * Remove android only attempt * Revert ci.yaml changes
…#117535) * c61ac23fc [webview_flutter_wkwebview] Adds support for `WKNavigationAction.navigationType` (flutter/plugins#6863) * 15cfe8aa2 [webview_flutter_android] Adds support for selecting Hybrid Composition (flutter/plugins#6864) * 2dd85ec81 [webview_flutter_android] Fixes bug where a `AndroidNavigationDelegate` was required to load a request (flutter/plugins#6872)
…17480)" (flutter#117545) This reverts commit b8b3567.
* Fix screenshot testing for flutter web integration_test * update packages * fix method signature and todo * Run tests on CI * fix type * remove silences * Add docs * fix comment * fix whitespace * review comments
* Remove single-view assumption from ScrollPhysics * fix scrollable_dispose_test.dart * add deprecated method back
…17480)" (flutter#117549) * Revert "Revert "Remove single-view assumption from widgets library (flutter#117480)" (flutter#117545)" This reverts commit b8d5d9c. * check for mounted
* Explain how to test onSubmitted * Fix analyzer saying tester is undefined
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@15c10fc...e38b190) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports
…#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890)
flutter#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment
…lutter#117989) * Add timeout * Add library directive * Add comment, remove testing only changes
…lutter#118014) * 22f872d5e Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9ed0 Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3bd Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dcdb Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5bf3 Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440ccd5 fix roll (flutter/engine#38635) * 87bdde8fe Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf29e make DisplayListFlags constexpr throughout (flutter/engine#38649)
…#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891)
* Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests
… get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument
Co-authored-by: Gray Mackall <[email protected]>
…115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk what's going on here, but at a glance this looks very wrong
|
Closing this as I messed up the commit history in trying to rebase to latest master branch. I'll redo this manually. |
|
@christopherfujino Apparently over a decade of experience with git isn't enough to prevent noob mistakes 😅 |
The test has been passing for 50 consecutive runs.
This test can be marked as unflaky.