Reland iOS 16 context menu #117234

justinmc · 2022-12-16T21:10:52Z

This is a reland of #115805, which had a bug where the button text color used the wrong brightness in some cases (reverted in #116312). This fixes that problem by using the right brightness value.

Platform	Native iOS 16 light mode	Native iOS 16 dark mode
Flutter (this branch)
Native iOS 16

Test app

import 'package:flutter/cupertino.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';

void main() {
  debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> with WidgetsBindingObserver {
  Brightness _brightness = Brightness.light;

  @override
  void initState() {
    super.initState();
    WidgetsBinding.instance.addObserver(this);
    _brightness = WidgetsBinding.instance.window.platformBrightness;
  }

  @override
  void didChangePlatformBrightness() {
    if (mounted) {
      setState(() {
        _brightness = WidgetsBinding.instance.window.platformBrightness;
      });
    }

    super.didChangePlatformBrightness();
  }

  @override
  void dispose() {
    WidgetsBinding.instance.removeObserver(this);
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return CupertinoApp(
      debugShowCheckedModeBanner: false,
      theme: CupertinoThemeData(
        brightness: _brightness,
      ),
      home: const CupertinoPageScaffold(
        navigationBar: CupertinoNavigationBar(
          middle: Text('Flutter Forward 2023'),
        ),
        child: _MyPage(),
      ),
    );
  }
}

class _MyPage extends StatelessWidget {
  const _MyPage();

  @override
  Widget build(BuildContext context) {
    return Center(
      child: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: <Widget>[
          Icon(
            CupertinoTheme.of(context).brightness == Brightness.light
                ? Icons.light_mode
                : Icons.dark_mode,
            color: const CupertinoDynamicColor.withBrightness(
              color: CupertinoColors.black,
              darkColor: CupertinoColors.white,
            ).resolveFrom(context),
            size: 100.0,
          ),
          Text(
            'Im using CupertinoDynamicColor',
            style: TextStyle(
              color: const CupertinoDynamicColor.withBrightness(
                color: Color(0xFFFF0000),
                darkColor: Color(0xFF00FF00),
              ).resolveFrom(context),
            ),
          ),
          CupertinoTextField(
            contextMenuBuilder: (BuildContext context, EditableTextState editableTextState) {
              return AdaptiveTextSelectionToolbar(
                anchors: editableTextState.contextMenuAnchors,
                children: <Widget>[
                  ...AdaptiveTextSelectionToolbar.getAdaptiveButtons(context, editableTextState.contextMenuButtonItems),
                  CupertinoTextSelectionToolbarButton.text(
                    text: 'I am disabled',
                    onPressed: null,
                  ),
                ],
              );
            },
          ),
        ],
      ),
    );
  }
}

This reverts commit 014b441.

MitchellGoodwin

LGTM

* 95ff839 Roll Plugins from 54fc206 to 2dd85ec (3 revisions) (flutter/flutter#117535) * b8d5d9c Revert "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117545) * bd482eb fixes android_semantics_integration_test to expect long press for tooltip (flutter/flutter#117547) * 725c141 Fix screenshot testing for flutter web integration_test (flutter/flutter#117114) * 999356b Remove single-view assumption from ScrollPhysics (flutter/flutter#117503) * 6eb002a Reland "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117549) * 08209b7 Explain how to test onSubmitted in its docs (flutter/flutter#117550) * 20bc2ba Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision) (flutter/flutter#117555) * abd5217 Bump ossf/scorecard-action from 2.1.1 to 2.1.2 (flutter/flutter#117554) * 6781576 Reland iOS 16 context menu (flutter/flutter#117234) * daa2ecf Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (flutter/flutter#117563) * 6441a7d Roll Flutter Engine from ca0c843bf75f to 12badb54598d (2 revisions) (flutter/flutter#117566) * a0cecbe 3b5fb86a5 delete unused lib/src/engine/canvaskit/viewport_metrics.dart (flutter/engine#38474) (flutter/flutter#117572) * fbfda23 Roll Flutter Engine from 3b5fb86a5982 to 6295d9198da1 (3 revisions) (flutter/flutter#117576) * 3eca29b f2a071692 Roll Skia from 3e39affa3e1d to 45466d04ca49 (1 revision) (flutter/engine#38480) (flutter/flutter#117579) * 05914e7 948d0bffa Roll Dart SDK from 47f192463696 to 442614a6c1bb (1 revision) (flutter/engine#38481) (flutter/flutter#117581) * a34dec2 00995b7b9 Roll Skia from 45466d04ca49 to e206aa0c44f0 (4 revisions) (flutter/engine#38482) (flutter/flutter#117585) * 4ef24cf 238f40bb9 Roll Fuchsia Mac SDK from W0GUdjHi4gI48optN... to 9w7QDlttR9f7Gu7U6... (flutter/engine#38483) (flutter/flutter#117587) * a45a2f3 ad042d863 Roll Skia from e206aa0c44f0 to a8b7ce3b6391 (1 revision) (flutter/engine#38484) (flutter/flutter#117589)

* 95ff839 Roll Plugins from 54fc2066d636 to 2dd85ec81d06 (3 revisions) (flutter/flutter#117535) * b8d5d9c Revert "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117545) * bd482eb fixes android_semantics_integration_test to expect long press for tooltip (flutter/flutter#117547) * 725c141 Fix screenshot testing for flutter web integration_test (flutter/flutter#117114) * 999356b Remove single-view assumption from ScrollPhysics (flutter/flutter#117503) * 6eb002a Reland "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117549) * 08209b7 Explain how to test onSubmitted in its docs (flutter/flutter#117550) * 20bc2ba Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision) (flutter/flutter#117555) * abd5217 Bump ossf/scorecard-action from 2.1.1 to 2.1.2 (flutter/flutter#117554) * 6781576 Reland iOS 16 context menu (flutter/flutter#117234) * daa2ecf Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (flutter/flutter#117563) * 6441a7d Roll Flutter Engine from ca0c843bf75f to 12badb54598d (2 revisions) (flutter/flutter#117566) * a0cecbe 3b5fb86a5 delete unused lib/src/engine/canvaskit/viewport_metrics.dart (flutter/engine#38474) (flutter/flutter#117572) * fbfda23 Roll Flutter Engine from 3b5fb86a5982 to 6295d9198da1 (3 revisions) (flutter/flutter#117576) * 3eca29b f2a071692 Roll Skia from 3e39affa3e1d to 45466d04ca49 (1 revision) (flutter/engine#38480) (flutter/flutter#117579) * 05914e7 948d0bffa Roll Dart SDK from 47f192463696 to 442614a6c1bb (1 revision) (flutter/engine#38481) (flutter/flutter#117581) * a34dec2 00995b7b9 Roll Skia from 45466d04ca49 to e206aa0c44f0 (4 revisions) (flutter/engine#38482) (flutter/flutter#117585) * 4ef24cf 238f40bb9 Roll Fuchsia Mac SDK from W0GUdjHi4gI48optN... to 9w7QDlttR9f7Gu7U6... (flutter/engine#38483) (flutter/flutter#117587) * a45a2f3 ad042d863 Roll Skia from e206aa0c44f0 to a8b7ce3b6391 (1 revision) (flutter/engine#38484) (flutter/flutter#117589)

Updates the iOS text selection toolbar to look like iOS 16 (reland)

* 95ff839 Roll Plugins from 54fc206 to 2dd85ec (3 revisions) (flutter/flutter#117535) * b8d5d9c Revert "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117545) * bd482eb fixes android_semantics_integration_test to expect long press for tooltip (flutter/flutter#117547) * 725c141 Fix screenshot testing for flutter web integration_test (flutter/flutter#117114) * 999356b Remove single-view assumption from ScrollPhysics (flutter/flutter#117503) * 6eb002a Reland "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117549) * 08209b7 Explain how to test onSubmitted in its docs (flutter/flutter#117550) * 20bc2ba Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision) (flutter/flutter#117555) * abd5217 Bump ossf/scorecard-action from 2.1.1 to 2.1.2 (flutter/flutter#117554) * 6781576 Reland iOS 16 context menu (flutter/flutter#117234) * daa2ecf Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (flutter/flutter#117563) * 6441a7d Roll Flutter Engine from ca0c843bf75f to 12badb54598d (2 revisions) (flutter/flutter#117566) * a0cecbe 3b5fb86a5 delete unused lib/src/engine/canvaskit/viewport_metrics.dart (flutter/engine#38474) (flutter/flutter#117572) * fbfda23 Roll Flutter Engine from 3b5fb86a5982 to 6295d9198da1 (3 revisions) (flutter/flutter#117576) * 3eca29b f2a071692 Roll Skia from 3e39affa3e1d to 45466d04ca49 (1 revision) (flutter/engine#38480) (flutter/flutter#117579) * 05914e7 948d0bffa Roll Dart SDK from 47f192463696 to 442614a6c1bb (1 revision) (flutter/engine#38481) (flutter/flutter#117581) * a34dec2 00995b7b9 Roll Skia from 45466d04ca49 to e206aa0c44f0 (4 revisions) (flutter/engine#38482) (flutter/flutter#117585) * 4ef24cf 238f40bb9 Roll Fuchsia Mac SDK from W0GUdjHi4gI48optN... to 9w7QDlttR9f7Gu7U6... (flutter/engine#38483) (flutter/flutter#117587) * a45a2f3 ad042d863 Roll Skia from e206aa0c44f0 to a8b7ce3b6391 (1 revision) (flutter/engine#38484) (flutter/flutter#117589)

Revert "Revert "iOS 16 context menu (#115805)" (#116312)"

5df3182

This reverts commit 014b441.

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Dec 16, 2022

justinmc changed the title ~~Revert "Revert "iOS 16 context menu" due to theme color mix up"~~ Reland iOS 16 context menu Dec 16, 2022

justinmc added 4 commits December 16, 2022 15:15

Fix reversed colors

9fdaeb7

Resolve unresolved text color

06a0573

Resolve divider color

e91bc7a

Fix CupertinoTextFieldTest, test that theme DOES change

4b8a8a8

justinmc force-pushed the revert-116312-revert-115805-ios-16-context-menu branch from 6cc4c3b to f2946fa Compare December 19, 2022 21:42

Fix toolbar test, test both MediaQuery and CupertinoTheme brightness

e30228f

justinmc force-pushed the revert-116312-revert-115805-ios-16-context-menu branch from f2946fa to e30228f Compare December 19, 2022 21:45

justinmc self-assigned this Dec 19, 2022

justinmc marked this pull request as ready for review December 19, 2022 22:30

justinmc requested review from LongCatIsLooong and MitchellGoodwin December 19, 2022 22:30

MitchellGoodwin approved these changes Dec 20, 2022

View reviewed changes

justinmc merged commit 6781576 into master Dec 22, 2022

justinmc deleted the revert-116312-revert-115805-ios-16-context-menu branch December 22, 2022 23:55

This was referenced Dec 23, 2022

Roll Flutter from 9fb1ae839e0a to a45a2f311990 (19 revisions) flutter/packages#3001

Merged

Roll Flutter from 9fb1ae839e0a to a45a2f311990 (19 revisions) flutter/plugins#6879

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2022

6781576 Reland iOS 16 context menu (flutter/flutter#117234)

b5f9dbe

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 23, 2022

6781576 Reland iOS 16 context menu (flutter/flutter#117234)

7cd3301

loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023

Reland iOS 16 context menu (flutter#117234)

df6c5cf

Updates the iOS text selection toolbar to look like iOS 16 (reland)

Jethro87 mentioned this pull request Jan 18, 2023

[SuperEditor] Update design of mobile floating toolbar Flutter-Bounty-Hunters/super_editor#963

Closed

gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023

Reland iOS 16 context menu (flutter#117234)

3b7aab3

Updates the iOS text selection toolbar to look like iOS 16 (reland)

justinmc mentioned this pull request Mar 9, 2023

Update Cupertino desktop text selection toolbar #121829

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reland iOS 16 context menu #117234

Reland iOS 16 context menu #117234

Uh oh!

justinmc commented Dec 16, 2022 •

edited

Loading

Uh oh!

MitchellGoodwin left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reland iOS 16 context menu #117234

Reland iOS 16 context menu #117234

Uh oh!

Conversation

justinmc commented Dec 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

justinmc commented Dec 16, 2022 •

edited

Loading