Repository navigation
Fix flutter update-packages regression by fixing parameters in "pub get" runner - #116687
auto-submit[bot] merged 15 commits into
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
christopherfujino
left a comment
There was a problem hiding this comment.
Code LGTM. Your CI tests are failing from an infra issue, and I think you'll need to add tests.
|
Sounds good, I'll add the test(s). |
flutter update-packages regression by fixing parameters in "pub get" runnerflutter update-packages regression by fixing parameters in "pub get" runner
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
cc @andrewkolos |
flutter update-packages regression by fixing parameters in "pub get" runnerflutter update-packages regression by fixing parameters in "pub get" runner
So what's happening here is that LUCI is trying to run
Given the logs in the succeeding step you linked, I'm guessing step 5 finished. I'm not sure exactly what happened, I think you need to investigate more, but maybe your change made the tool stop logging "Running pub upgrade...", then invoked pub. Then, for whatever reason, it's retrying forever until it gets timed out? One thing you could do is hack the tool to always run this sub-command in verbose mode just for your PR, push it to github, and then look at the verbose LUCI logs. |
|
Thanks for taking a look! I'll give that a shot. |
|
Looks like the issue was fixed. Apparently it was because I was using ProcessUtils.start for the non-output mode, which I now see does warn you in the documentation to make sure to read all the data from the stdout / stderr streams, but as of now only trips up on Windows if you don't do that. I left a comment about it in pub.dart. 😵💫 This issue and comment clued me to it: dart-lang/sdk#50689 (comment) |
… in "pub get" runner (flutter/flutter#116687)
… in "pub get" runner (flutter/flutter#116687)
* 7a5ae7c Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter/flutter#118040) * 43b9120 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter-team-archive/engine#38646) (flutter/flutter#118039) * 5a87a82 bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter-team-archive/engine#38659) (flutter/flutter#118042) * 0a2e0a4 Avoid using `TextAffinity` in `TextBoundary` (flutter/flutter#117446) * 36a1caf 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter-team-archive/engine#38393) (flutter/flutter#118048) * 9b864b8 5bd90d6e7 Consider more roles as text (flutter-team-archive/engine#38645) (flutter/flutter#118049) * 70d5834 [EMPTY] Commit to refresh the tree that is currently red (flutter/flutter#118062) * 4f3ed80 Remove doc reference to the deprecated ui.FlutterWindow API (flutter/flutter#118064) * de2a424 Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter/flutter#116687) * 57dc071 Adding 'is' to list of kotlin reserved keywords (flutter/flutter#116299) * 5070620 Added expandIconColor property on ExpansionPanelList Widget (flutter/flutter#115950)
* 5a87a82 bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter-team-archive/engine#38659) (flutter/flutter#118042) * 0a2e0a4 Avoid using `TextAffinity` in `TextBoundary` (flutter/flutter#117446) * 36a1caf 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter-team-archive/engine#38393) (flutter/flutter#118048) * 9b864b8 5bd90d6e7 Consider more roles as text (flutter-team-archive/engine#38645) (flutter/flutter#118049) * 70d5834 [EMPTY] Commit to refresh the tree that is currently red (flutter/flutter#118062) * 4f3ed80 Remove doc reference to the deprecated ui.FlutterWindow API (flutter/flutter#118064) * de2a424 Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter/flutter#116687) * 57dc071 Adding 'is' to list of kotlin reserved keywords (flutter/flutter#116299) * 5070620 Added expandIconColor property on ExpansionPanelList Widget (flutter/flutter#115950)
… get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument
… get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument
… get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument
With the update to the "pub get" runner in #115801, there were a couple parameters (printProgress and retry) that were left out. This causes
flutter update-packagesto print unexpected output as seen in #116627.This PR fixes that by hooking up the parameters.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.