Skip to content

Conversation

@XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Dec 7, 2022

…y rather than JSON (#113637)" (#116662)

This reverts commit 56cad89.

cherrypicks #116662. cherry pick for now and not updating to head so that we might be able to fix all current failures and get going.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 7, 2022
@christopherfujino
Copy link
Contributor

I want to make sure analysis passes on this, as there are pubspec changes

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tool revert LGTM

@XilaiZhang XilaiZhang merged commit e937e15 into flutter:flutter-3.7-candidate.3 Dec 7, 2022
@CaseyHillers
Copy link
Contributor

@XilaiZhang do you know why the bot didn't approve this? CPs for rolls should be bot approved

@XilaiZhang
Copy link
Contributor Author

umm my understanding might be wrong, but I remember Godofredo mentioned a while ago that autosubmit bot does not work on release branches, or maybe it now works on release branches as well

@CaseyHillers
Copy link
Contributor

Approval != autosubmit.

You shouldn't be blocked on landing roll CPs as the bot will approve them

@XilaiZhang
Copy link
Contributor Author

Synced with Casey and learnt about auto approve from a cocoon bot. Casey added my name to the bot config so in the future roll cherry picks will be auto approved by the bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants