Add const constructor to TextInputFormatter #116654

shogohida · 2022-12-07T13:23:16Z

Fixes #114401

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

shogohida · 2022-12-07T13:25:18Z

@goderbauer
I made a new pull request as I commented in the previous one.

#114592 (comment)

LongCatIsLooong · 2022-12-08T23:23:39Z

The tests are failing because:

  error • Missing concrete implementation of 'TextInputFormatter.formatEditUpdate' • packages/flutter/test/services/text_formatter_test.dart:9:7 • non_abstract_class_inherits_abstract_member
   info • Specify type annotations • packages/flutter/test/services/text_formatter_test.dart:15:5 • always_specify_types
   info • Specify type annotations • packages/flutter/test/services/text_formatter_test.dart:16:5 • always_specify_types

kevmoo · 2022-12-08T23:41:13Z

packages/flutter/test/services/text_formatter_test.dart

Suggested change

expect(testValue1, equals(testValue2));

expect(testValue1, same(testValue2));

https://pub.dev/documentation/matcher/latest/matcher/same.html

shogohida · 2022-12-09T10:04:07Z

I thought I changed the code correctly with these commits but some tests are still failing...

c8bf9a8
fc0df2e

LongCatIsLooong · 2022-12-09T18:40:50Z

That doesn't compile you can't instantiate an abstract class. Could you follow https://github.com/flutter/flutter/wiki/Running-and-writing-tests#running-unit-tests to run the test locally? If you run flutter test you'll see the errors immediately and that may help shorten the feedback loop.

goderbauer · 2023-01-03T23:15:57Z

(triage): @shogohida Do you still have plans to come back to this one soon and address the feedback given above?

shogohida · 2023-01-04T06:17:18Z

@goderbauer
Sorry for the inconvenience. I tried to create local environment on my PC but I got stuck and have not been able to run flutter test locally yet....

shogohida · 2023-01-07T05:58:32Z

@goderbauer
I made this PR ready for review. I added noSuchMethod to the test file so that it passes but I'm not sure if this is correct.

LongCatIsLooong

LGTM.

packages/flutter/lib/src/services/text_formatter.dart

packages/flutter/test/services/text_formatter_test.dart

shogohida · 2023-01-11T04:50:43Z

@LongCatIsLooong
Thanks for reviewing! And sorry for taking so much time until I finished. I changed the text and the position of the test with the following commit so please check it

f7b6e92

Piinks

The last commit's tweaks LGTM

shogohida · 2023-01-11T23:49:31Z

@Piinks
Thanks for your comment! I'm glad to receive your review too! Hope to contribute more!

goderbauer · 2023-01-17T23:14:04Z

@shogohida Could you rebase this PR with the latest master to get the google testing check to pass? Thanks!

Signed-off-by: Shogo Hida <[email protected]>

…116654)

* a3629a2 Roll Plugins from 92a5367 to 4e5cf2d (8 revisions) (flutter/flutter#118624) * ae7b99e Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070) * 6fafbc3 Updated tokens to v0.152 (flutter/flutter#118594) * 4b3cf9b Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607) * 0449030 Disable Xcode cache cleanup (flutter/flutter#118641) * f989d55 Devicelab android emulator (flutter/flutter#113472) * 0eaa83a Fix some Focus related documentation typos (flutter/flutter#118576) * 780563c Add const constructor to TextInputFormatter (flutter/flutter#116654) * 973cff4 [Re-land] Button padding m3 (flutter/flutter#118640)

…116654)

@OverRide

* Add const constructor to TextInputFormatter * Fix test * Add abstract * Add noSuchMethod Signed-off-by: Shogo Hida <[email protected]> * Add @OverRide and void Signed-off-by: Shogo Hida <[email protected]> * Fix text and position of test Signed-off-by: Shogo Hida <[email protected]> Signed-off-by: Shogo Hida <[email protected]>

…116654)

@pragma

* da5f8cf Roll Flutter Engine from a512cebdcd30 to 7dc5e7efa66a (2 revisions) (flutter/flutter#118505) * baefecc 35479aa1c Roll Fuchsia Mac SDK from 21nYb648VWbpxc36t... to w0hr1ZMvYGJnWInwK... (flutter/engine#38880) (flutter/flutter#118509) * ca300ce 25cb82272 Add include to make g3 happy (flutter/engine#38850) (flutter/flutter#118510) * 1220245 f79030440 Roll Skia from c72c7bf7e45b to c64a10d525d1 (7 revisions) (flutter/engine#38858) (flutter/flutter#118511) * 7188c3e Update documentation about accent color (flutter/flutter#116778) * 8c2fdb8 M3 Button padding adjustments (flutter/flutter#118449) * f22280a Revert "M3 Button padding adjustments (#118449)" (flutter/flutter#118598) * cc7845e Post a ToolEvent when selecting widget for inspection (flutter/flutter#118098) * a3629a2 Roll Plugins from 92a5367d58df to 4e5cf2d2da27 (8 revisions) (flutter/flutter#118624) * ae7b99e Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070) * 6fafbc3 Updated tokens to v0.152 (flutter/flutter#118594) * 4b3cf9b Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607) * 0449030 Disable Xcode cache cleanup (flutter/flutter#118641) * f989d55 Devicelab android emulator (flutter/flutter#113472) * 0eaa83a Fix some Focus related documentation typos (flutter/flutter#118576) * 780563c Add const constructor to TextInputFormatter (flutter/flutter#116654) * 973cff4 [Re-land] Button padding m3 (flutter/flutter#118640) * 3348987 Add new macos target configured for flavors (flutter/flutter#117352) * 6277520 Roll Plugins from 4e5cf2d2da27 to 11361d01099d (4 revisions) (flutter/flutter#118682) * 997d436 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185) * 8a58ec5 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720) * 374f09e [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491) * ae1cc18 remove single-view assumption from `paintImage` (flutter/flutter#118721) * bb8b96a Fix path for require.js (flutter/flutter#118722) * c83a698 update uikit view documentation (flutter/flutter#118715) * 2b3ca0d Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735) * 666dccc [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717) * d07b88e Docs fix an=>a (flutter/flutter#118652) * 11d21e0 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738) * 7d9eaab Appbar iconTheme override fix (flutter/flutter#118681) * 6f70830 Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743) * b3059d2 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745) * ffcf63a Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755) * 2609212 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751) * 21fb443 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758) * e5c9d06 Forgot to remove emulator flag. (flutter/flutter#118762) * 6a9b2db 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763) * 0bbb5ec 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771) * d53cc4a [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754) * 3e71e0c Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705) * 213b3cb Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556) * 06909cc Update packages + fix tests for javascript mime change (flutter/flutter#118617) * 46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793) * b9ab640 Remove incorrect statement in documentation (flutter/flutter#118636) * ea36b3a Add focus detector to CupertinoSwitch (flutter/flutter#118345) * 9b5ea30 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807) * 67ffaef 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817) * 5cd2d4c Support iOS wireless debugging (flutter/flutter#118104) * cbf2e16 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826) * 2258590 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828) * 1dd7f45 Add `build macos --config-only` option. (flutter/flutter#118649) * 22520f5 [macOS] Add timeline summary benchmarks (flutter/flutter#118748) * 99e4ca5 Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829) * c5ceff1 [flutter_tools] Ensure service worker starts caching assets since first load (flutter/flutter#116833) * 818bb4e Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839) * 09bd0f6 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674) * 73096fd [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421)

* a3629a2 Roll Plugins from 92a5367 to 4e5cf2d (8 revisions) (flutter/flutter#118624) * ae7b99e Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070) * 6fafbc3 Updated tokens to v0.152 (flutter/flutter#118594) * 4b3cf9b Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607) * 0449030 Disable Xcode cache cleanup (flutter/flutter#118641) * f989d55 Devicelab android emulator (flutter/flutter#113472) * 0eaa83a Fix some Focus related documentation typos (flutter/flutter#118576) * 780563c Add const constructor to TextInputFormatter (flutter/flutter#116654) * 973cff4 [Re-land] Button padding m3 (flutter/flutter#118640)

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Dec 7, 2022

justinmc requested a review from LongCatIsLooong December 8, 2022 23:18

kevmoo reviewed Dec 8, 2022

View reviewed changes

shogohida force-pushed the add-const-constructor-to-TextInputFormatter branch from fc0df2e to 1b93653 Compare January 7, 2023 03:57

shogohida marked this pull request as ready for review January 7, 2023 05:56

LongCatIsLooong approved these changes Jan 11, 2023

View reviewed changes

packages/flutter/lib/src/services/text_formatter.dart Outdated Show resolved Hide resolved

packages/flutter/test/services/text_formatter_test.dart Outdated Show resolved Hide resolved

Piinks approved these changes Jan 11, 2023

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 11, 2023

shogohida added 6 commits January 18, 2023 09:24

Add const constructor to TextInputFormatter

a918e53

Fix test

fac403d

Add abstract

7b002a0

Add noSuchMethod

3391278

Signed-off-by: Shogo Hida <[email protected]>

Add @OverRide and void

cebd21a

Signed-off-by: Shogo Hida <[email protected]>

Fix text and position of test

3f2571b

Signed-off-by: Shogo Hida <[email protected]>

shogohida force-pushed the add-const-constructor-to-TextInputFormatter branch from f7b6e92 to 3f2571b Compare January 18, 2023 00:25

auto-submit bot merged commit 780563c into flutter:master Jan 18, 2023

shogohida deleted the add-const-constructor-to-TextInputFormatter branch January 18, 2023 02:11

This was referenced Jan 18, 2023

Roll Flutter from 68dd63d66ba6 to 973cff40b402 (17 revisions) flutter/packages#3061

Closed

Roll Flutter from cc7845e71a9d to 973cff40b402 (9 revisions) flutter/plugins#6987

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

e0ce7ee

…116654)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

b872731

…116654)

engine-flutter-autoroll mentioned this pull request Jan 18, 2023

Roll Flutter from 68dd63d66ba6 to 3348987546df (18 revisions) flutter/packages#3062

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

8f3f4a0

…116654)

engine-flutter-autoroll mentioned this pull request Jan 18, 2023

Roll Flutter from 68dd63d66ba6 to 62775206461c (19 revisions) flutter/packages#3063

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

9b0ece6

…116654)

engine-flutter-autoroll mentioned this pull request Jan 18, 2023

Roll Flutter from 68dd63d66ba6 to 997d43618dc7 (20 revisions) flutter/packages#3064

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

29e39e7

…116654)

engine-flutter-autoroll mentioned this pull request Jan 19, 2023

Roll Flutter from 68dd63d66ba6 to 06909ccfa4ef (42 revisions) flutter/packages#3068

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

5462aae

…116654)

engine-flutter-autoroll mentioned this pull request Jan 19, 2023

Roll Flutter from 68dd63d66ba6 to 46c7fd14da02 (43 revisions) flutter/packages#3069

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

6f93f00

…116654)

engine-flutter-autoroll mentioned this pull request Jan 19, 2023

Roll Flutter from 68dd63d66ba6 to b9ab64049152 (44 revisions) flutter/packages#3070

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

0e62080

…116654)

engine-flutter-autoroll mentioned this pull request Jan 19, 2023

Roll Flutter from 68dd63d66ba6 to ea36b3a5a708 (45 revisions) flutter/packages#3071

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

91c4f8d

…116654)

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 68dd63d66ba6 to 73096fd96ef5 (57 revisions) flutter/packages#3073

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2023

780563c Add const constructor to TextInputFormatter (flutter/flutter#…

d09ffe7

…116654)

	expect(testValue1, equals(testValue2));
	expect(testValue1, same(testValue2));

Add const constructor to TextInputFormatter #116654

Add const constructor to TextInputFormatter #116654

Uh oh!

Conversation

shogohida commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

shogohida commented Dec 7, 2022

Uh oh!

LongCatIsLooong commented Dec 8, 2022

Uh oh!

kevmoo Dec 8, 2022

Choose a reason for hiding this comment

Uh oh!

shogohida commented Dec 9, 2022

Uh oh!

LongCatIsLooong commented Dec 9, 2022

Uh oh!

goderbauer commented Jan 3, 2023

Uh oh!

shogohida commented Jan 4, 2023

Uh oh!

shogohida commented Jan 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shogohida commented Jan 11, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

shogohida commented Jan 11, 2023

Uh oh!

goderbauer commented Jan 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shogohida commented Dec 7, 2022 •

edited

Loading

shogohida commented Jan 7, 2023 •

edited

Loading